From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: Matan Azrad <matan@mellanox.com>, dev@dpdk.org
Cc: Viacheslav Ovsiienko <viacheslavo@mellanox.com>,
Shahaf Shuler <shahafs@mellanox.com>
Subject: Re: [dpdk-dev] [PATCH 0/3] vdpa/mlx5: recteate a virtq becoming enabled
Date: Fri, 17 Apr 2020 16:58:52 +0200 [thread overview]
Message-ID: <16899db2-574e-f4bf-c4b7-05a8c6d83ab5@redhat.com> (raw)
In-Reply-To: <1585653143-21987-1-git-send-email-matan@mellanox.com>
Hi Matan,
On 3/31/20 1:12 PM, Matan Azrad wrote:
> Since a virtq configuration may be changed in disable state it is better to recreate a virtq becoming enabled.
> This series adding this behaviour to the mlx5 driver for vDPA.
>
> Matan Azrad (3):
> vdpa/mlx5: manage virtqs by array
> vdpa/mlx5: separate virtq stop
> vdpa/mlx5: recteate a virtq becoming enabled
>
> drivers/vdpa/mlx5/mlx5_vdpa.c | 47 +++++++--------
> drivers/vdpa/mlx5/mlx5_vdpa.h | 54 +++++++++++++++--
> drivers/vdpa/mlx5/mlx5_vdpa_lm.c | 57 ++++++++----------
> drivers/vdpa/mlx5/mlx5_vdpa_steer.c | 103 ++++++++++++++++----------------
> drivers/vdpa/mlx5/mlx5_vdpa_virtq.c | 113 +++++++++++++++++++++++++++---------
> 5 files changed, 231 insertions(+), 143 deletions(-)
>
I wanted to apply your series, but it fails to apply:
$ git am -3 vdpa-mlx5-recteate-a-virtq-becoming-enabled.patch
Applying: vdpa/mlx5: manage virtqs by array
error: sha1 information is lacking or useless
(drivers/vdpa/mlx5/mlx5_vdpa.c).
error: could not build fake ancestor
Patch failed at 0001 vdpa/mlx5: manage virtqs by array
hint: Use 'git am --show-current-patch' to see the failed patch
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
Could you please rebase it on top of dpdk-next-virtio/master?
While doing that, if you could take fix the minor issues/typos I *
reported, that would be great!
Thanks,
Maxime
next prev parent reply other threads:[~2020-04-17 14:59 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-31 11:12 Matan Azrad
2020-03-31 11:12 ` [dpdk-dev] [PATCH 1/3] vdpa/mlx5: manage virtqs by array Matan Azrad
2020-04-09 15:18 ` Maxime Coquelin
2020-04-10 13:58 ` Matan Azrad
2020-04-10 13:59 ` Maxime Coquelin
2020-04-15 14:06 ` Maxime Coquelin
2020-03-31 11:12 ` [dpdk-dev] [PATCH 2/3] vdpa/mlx5: separate virtq stop Matan Azrad
2020-04-09 15:28 ` Maxime Coquelin
2020-04-10 13:59 ` Matan Azrad
2020-04-10 14:04 ` Maxime Coquelin
2020-03-31 11:12 ` [dpdk-dev] [PATCH 3/3] vdpa/mlx5: recteate a virtq becoming enabled Matan Azrad
2020-04-15 14:06 ` Maxime Coquelin
2020-04-17 14:58 ` Maxime Coquelin [this message]
2020-04-26 12:07 ` [dpdk-dev] [PATCH 0/3] vdpa/mlx5: recreate " Matan Azrad
2020-04-26 12:07 ` [dpdk-dev] [PATCH 1/3] vdpa/mlx5: manage virtqs by array Matan Azrad
2020-04-27 7:45 ` Maxime Coquelin
2020-04-26 12:07 ` [dpdk-dev] [PATCH 2/3] vdpa/mlx5: separate virtq stop Matan Azrad
2020-04-26 12:07 ` [dpdk-dev] [PATCH 3/3] vdpa/mlx5: recreate a virtq becoming enabled Matan Azrad
2020-04-28 16:07 ` [dpdk-dev] [PATCH 0/3] " Maxime Coquelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=16899db2-574e-f4bf-c4b7-05a8c6d83ab5@redhat.com \
--to=maxime.coquelin@redhat.com \
--cc=dev@dpdk.org \
--cc=matan@mellanox.com \
--cc=shahafs@mellanox.com \
--cc=viacheslavo@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).