From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4B54BA04B3; Tue, 28 Jan 2020 18:35:30 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 15A7D1D584; Tue, 28 Jan 2020 18:35:30 +0100 (CET) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 6D9DA1D56E for ; Tue, 28 Jan 2020 18:35:28 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 28 Jan 2020 09:35:23 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,374,1574150400"; d="scan'208";a="229350426" Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.237.221.61]) ([10.237.221.61]) by orsmga003.jf.intel.com with ESMTP; 28 Jan 2020 09:35:21 -0800 Cc: Hariprasad Govindharajan , dev@dpdk.org, Stephen Hemminger , Thomas Monjalon References: <1580121053-26083-1-git-send-email-hariprasad.govindharajan@intel.com> <1580121053-26083-3-git-send-email-hariprasad.govindharajan@intel.com> To: David Marchand From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@intel.com; prefer-encrypt=mutual; keydata= mQINBFXZCFABEADCujshBOAaqPZpwShdkzkyGpJ15lmxiSr3jVMqOtQS/sB3FYLT0/d3+bvy qbL9YnlbPyRvZfnP3pXiKwkRoR1RJwEo2BOf6hxdzTmLRtGtwWzI9MwrUPj6n/ldiD58VAGQ +iR1I/z9UBUN/ZMksElA2D7Jgg7vZ78iKwNnd+vLBD6I61kVrZ45Vjo3r+pPOByUBXOUlxp9 GWEKKIrJ4eogqkVNSixN16VYK7xR+5OUkBYUO+sE6etSxCr7BahMPKxH+XPlZZjKrxciaWQb +dElz3Ab4Opl+ZT/bK2huX+W+NJBEBVzjTkhjSTjcyRdxvS1gwWRuXqAml/sh+KQjPV1PPHF YK5LcqLkle+OKTCa82OvUb7cr+ALxATIZXQkgmn+zFT8UzSS3aiBBohg3BtbTIWy51jNlYdy ezUZ4UxKSsFuUTPt+JjHQBvF7WKbmNGS3fCid5Iag4tWOfZoqiCNzxApkVugltxoc6rG2TyX CmI2rP0mQ0GOsGXA3+3c1MCdQFzdIn/5tLBZyKy4F54UFo35eOX8/g7OaE+xrgY/4bZjpxC1 1pd66AAtKb3aNXpHvIfkVV6NYloo52H+FUE5ZDPNCGD0/btFGPWmWRmkPybzColTy7fmPaGz cBcEEqHK4T0aY4UJmE7Ylvg255Kz7s6wGZe6IR3N0cKNv++O7QARAQABtCVGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBpbnRlbC5jb20+iQJUBBMBCgA+AhsDAh4BAheABQsJCAcDBRUK CQgLBRYCAwEAFiEE0jZTh0IuwoTjmYHH+TPrQ98TYR8FAl1meboFCQlupOoACgkQ+TPrQ98T YR9ACBAAv2tomhyxY0Tp9Up7mNGLfEdBu/7joB/vIdqMRv63ojkwr9orQq5V16V/25+JEAD0 60cKodBDM6HdUvqLHatS8fooWRueSXHKYwJ3vxyB2tWDyZrLzLI1jxEvunGodoIzUOtum0Ce gPynnfQCelXBja0BwLXJMplM6TY1wXX22ap0ZViC0m714U5U4LQpzjabtFtjT8qOUR6L7hfy YQ72PBuktGb00UR/N5UrR6GqB0x4W41aZBHXfUQnvWIMmmCrRUJX36hOTYBzh+x86ULgg7H2 1499tA4o6rvE13FiGccplBNWCAIroAe/G11rdoN5NBgYVXu++38gTa/MBmIt6zRi6ch15oLA Ln2vHOdqhrgDuxjhMpG2bpNE36DG/V9WWyWdIRlz3NYPCDM/S3anbHlhjStXHOz1uHOnerXM 1jEjcsvmj1vSyYoQMyRcRJmBZLrekvgZeh7nJzbPHxtth8M7AoqiZ/o/BpYU+0xZ+J5/szWZ aYxxmIRu5ejFf+Wn9s5eXNHmyqxBidpCWvcbKYDBnkw2+Y9E5YTpL0mS0dCCOlrO7gca27ux ybtbj84aaW1g0CfIlUnOtHgMCmz6zPXThb+A8H8j3O6qmPoVqT3qnq3Uhy6GOoH8Fdu2Vchh TWiF5yo+pvUagQP6LpslffufSnu+RKAagkj7/RSuZV25Ag0EV9ZMvgEQAKc0Db17xNqtSwEv mfp4tkddwW9XA0tWWKtY4KUdd/jijYqc3fDD54ESYpV8QWj0xK4YM0dLxnDU2IYxjEshSB1T qAatVWz9WtBYvzalsyTqMKP3w34FciuL7orXP4AibPtrHuIXWQOBECcVZTTOdZYGAzaYzxiA ONzF9eTiwIqe9/oaOjTwTLnOarHt16QApTYQSnxDUQljeNvKYt1lZE/gAUUxNLWsYyTT+22/ vU0GDUahsJxs1+f1yEr+OGrFiEAmqrzpF0lCS3f/3HVTU6rS9cK3glVUeaTF4+1SK5ZNO35p iVQCwphmxa+dwTG/DvvHYCtgOZorTJ+OHfvCnSVjsM4kcXGjJPy3JZmUtyL9UxEbYlrffGPQ I3gLXIGD5AN5XdAXFCjjaID/KR1c9RHd7Oaw0Pdcq9UtMLgM1vdX8RlDuMGPrj5sQrRVbgYH fVU/TQCk1C9KhzOwg4Ap2T3tE1umY/DqrXQgsgH71PXFucVjOyHMYXXugLT8YQ0gcBPHy9mZ qw5mgOI5lCl6d4uCcUT0l/OEtPG/rA1lxz8ctdFBVOQOxCvwRG2QCgcJ/UTn5vlivul+cThi 6ERPvjqjblLncQtRg8izj2qgmwQkvfj+h7Ex88bI8iWtu5+I3K3LmNz/UxHBSWEmUnkg4fJl Rr7oItHsZ0ia6wWQ8lQnABEBAAGJAjwEGAEKACYCGwwWIQTSNlOHQi7ChOOZgcf5M+tD3xNh HwUCXWZ5wAUJB3FgggAKCRD5M+tD3xNhH2O+D/9OEz62YuJQLuIuOfL67eFTIB5/1+0j8Tsu o2psca1PUQ61SZJZOMl6VwNxpdvEaolVdrpnSxUF31kPEvR0Igy8HysQ11pj8AcgH0a9FrvU /8k2Roccd2ZIdpNLkirGFZR7LtRw41Kt1Jg+lafI0efkiHKMT/6D/P1EUp1RxOBNtWGV2hrd 0Yg9ds+VMphHHU69fDH02SwgpvXwG8Qm14Zi5WQ66R4CtTkHuYtA63sS17vMl8fDuTCtvfPF HzvdJLIhDYN3Mm1oMjKLlq4PUdYh68Fiwm+boJoBUFGuregJFlO3hM7uHBDhSEnXQr5mqpPM 6R/7Q5BjAxrwVBisH0yQGjsWlnysRWNfExAE2sRePSl0or9q19ddkRYltl6X4FDUXy2DTXa9 a+Fw4e1EvmcF3PjmTYs9IE3Vc64CRQXkhujcN4ZZh5lvOpU8WgyDxFq7bavFnSS6kx7Tk29/ wNJBp+cf9qsQxLbqhW5kfORuZGecus0TLcmpZEFKKjTJBK9gELRBB/zoN3j41hlEl7uTUXTI JQFLhpsFlEdKLujyvT/aCwP3XWT+B2uZDKrMAElF6ltpTxI53JYi22WO7NH7MR16Fhi4R6vh FHNBOkiAhUpoXRZXaCR6+X4qwA8CwHGqHRBfYFSU/Ulq1ZLR+S3hNj2mbnSx0lBs1eEqe2vh cA== Message-ID: <1689bec2-91f3-77cd-8604-f7123023b109@intel.com> Date: Tue, 28 Jan 2020 17:35:20 +0000 MIME-Version: 1.0 In-Reply-To: <1580121053-26083-3-git-send-email-hariprasad.govindharajan@intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH 2/2] eal: add eal_parse_optionlist to parse user input X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 1/27/2020 10:30 AM, Hariprasad Govindharajan wrote: > In current version, there is a function which parses > the corelist based on user value. A new generic > function eal_parse_optionlist is added which will > parse corelist as well as similar user input so > that we can use it as a public API too. > > Signed-off-by: Hariprasad Govindharajan Hi David, Overall this patchset is to add '--portlist' command to testpmd and remove existing 64 port limitation. And in this patch re-uses the exiting parser function in eal and converts it to API, question is if eal is good place to have this API, what do you think about it? > --- > lib/librte_eal/common/eal_common_options.c | 45 ++++++++++++++++++------------ > lib/librte_eal/common/include/rte_eal.h | 34 ++++++++++++++++++++++ > lib/librte_eal/rte_eal_version.map | 1 + > 3 files changed, 62 insertions(+), 18 deletions(-) > > diff --git a/lib/librte_eal/common/eal_common_options.c b/lib/librte_eal/common/eal_common_options.c > index 5920233..aa59f8b 100644 > --- a/lib/librte_eal/common/eal_common_options.c > +++ b/lib/librte_eal/common/eal_common_options.c > @@ -571,33 +571,36 @@ eal_parse_service_corelist(const char *corelist) > return 0; > } > > -static int > -eal_parse_corelist(const char *corelist, int *cores) > +int > +eal_parse_optionlist(const char *list, int *values, int maxsize) > { > unsigned count = 0; > char *end = NULL; > int min, max; > int idx; > > - for (idx = 0; idx < RTE_MAX_LCORE; idx++) > - cores[idx] = -1; > + if (list == NULL || values == NULL || maxsize < 0) > + return -1; > + > + for (idx = 0; idx < maxsize; idx++) > + values[idx] = -1; > > /* Remove all blank characters ahead */ > - while (isblank(*corelist)) > - corelist++; > + while (isblank(*list)) > + list++; > + > + min = maxsize; > > - /* Get list of cores */ > - min = RTE_MAX_LCORE; > do { > - while (isblank(*corelist)) > - corelist++; > - if (*corelist == '\0') > + while (isblank(*list)) > + list++; > + if (*list == '\0') > return -1; > errno = 0; > - idx = strtol(corelist, &end, 10); > + idx = strtol(list, &end, 10); > if (errno || end == NULL) > return -1; > - if (idx < 0 || idx >= RTE_MAX_LCORE) > + if (idx < 0 || idx >= maxsize) > return -1; > while (isblank(*end)) > end++; > @@ -605,18 +608,18 @@ eal_parse_corelist(const char *corelist, int *cores) > min = idx; > } else if ((*end == ',') || (*end == '\0')) { > max = idx; > - if (min == RTE_MAX_LCORE) > + if (min == maxsize) > min = idx; > for (idx = min; idx <= max; idx++) { > - if (cores[idx] == -1) { > - cores[idx] = count; > + if (values[idx] == -1) { > + values[idx] = count; > count++; > } > } > - min = RTE_MAX_LCORE; > + min = maxsize; > } else > return -1; > - corelist = end + 1; > + list = end + 1; > } while (*end != '\0'); > > if (count == 0) > @@ -624,6 +627,12 @@ eal_parse_corelist(const char *corelist, int *cores) > return 0; > } > > +static int > +eal_parse_corelist(const char *corelist, int *cores) > +{ > + return eal_parse_optionlist(corelist, cores, RTE_MAX_LCORE); > +} > + > /* Changes the lcore id of the master thread */ > static int > eal_parse_master_lcore(const char *arg) > diff --git a/lib/librte_eal/common/include/rte_eal.h b/lib/librte_eal/common/include/rte_eal.h > index 2f9ed29..567b754 100644 > --- a/lib/librte_eal/common/include/rte_eal.h > +++ b/lib/librte_eal/common/include/rte_eal.h > @@ -71,6 +71,40 @@ enum rte_proc_type_t rte_eal_process_type(void); > int rte_eal_iopl_init(void); > > /** > + * Parse the user input > + * > + * This function can be used to read and parse the user input > + * from the command line. For example, when the user specifies > + * corelist or port list this function will read the input > + * and set the forwarding cores or ports > + * > + * @param[in] list > + * String containing the user input. User can specify > + * in these formats 1,3,5 or 1-3 or 1-2,5 or 3,5-6. > + * For example, if the user wants to use all the available > + * 4 ports in his system, then the input can be 0-3 or 0,1,2,3. > + * If the user wants to use only the ports 1,2 then the input > + * is 1,2. > + * valid characters are '-' and ',' > + * invalid chars like '.' or '#' will result in > + * EAL: Error - exiting with code: 1 > + * Cause: Invalid fwd port list > + * @param[in] values > + * An array pointer, used by this function to set the > + * array contents to a positive value if they are listed > + * in the input > + * else sets it to -1 > + * @param[in] maxsize > + * This is the maximum value the list string can contain > + * @return > + * -On success, returns 0. > + * -On failure, returns -1. > + */ > +__rte_experimental > +int > +eal_parse_optionlist(const char *list, int *values, int maxsize); > + > +/** > * Initialize the Environment Abstraction Layer (EAL). > * > * This function is to be executed on the MASTER lcore only, as soon > diff --git a/lib/librte_eal/rte_eal_version.map b/lib/librte_eal/rte_eal_version.map > index e38d025..3d72df8 100644 > --- a/lib/librte_eal/rte_eal_version.map > +++ b/lib/librte_eal/rte_eal_version.map > @@ -332,4 +332,5 @@ EXPERIMENTAL { > # added in 19.11 > rte_log_get_stream; > rte_mcfg_get_single_file_segments; > + eal_parse_optionlist; > }; >