From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wi0-f179.google.com (mail-wi0-f179.google.com
 [209.85.212.179]) by dpdk.org (Postfix) with ESMTP id 225735A6D
 for <dev@dpdk.org>; Mon, 10 Aug 2015 22:40:23 +0200 (CEST)
Received: by wibhh20 with SMTP id hh20so167050045wib.0
 for <dev@dpdk.org>; Mon, 10 Aug 2015 13:40:23 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:organization
 :user-agent:in-reply-to:references:mime-version
 :content-transfer-encoding:content-type;
 bh=ygKh92geT789deOQqgxzl1IU7ckIvebiN3/X1BbEM+k=;
 b=EA/j/y9vqxqzHOCr+s01IXs47R5qmgpRKSLvla1/YxpmWdICLuTZG8Q8MH+LKbwmEq
 xikk5AMjSUBhycdtRxCvaZmSRXIHE09BOW7s7B3QsVzVeDH+4qzYMuUJ+cU7hOdgp9lw
 aoAJZnbT4x8lsN5r68+wNCnHlBg8CKRHL8lURqB+xhyFyGDsxSZTEA/YmZItZD8X7uWs
 HZZa9qxazBvyjfMEbm10aF2R63tO45PT1cHm8ogl1xB67usNDNDfYuKduOOg6zp3Vm1U
 FwG0wNZtKLmoXgfGYcL3pnnk5Of56TPUN8cywWTF1DEtB5ZQfT4bsmGWcPF1kbLt7MYG
 j8sg==
X-Gm-Message-State: ALoCoQmGe/dseIY/GB9UtlFMVCukoIKeK0H4sKN9YVfCDxNXN8wnABX7qzFmmn59ZvIz7O0PAFBo
X-Received: by 10.194.11.7 with SMTP id m7mr47904133wjb.56.1439239222959;
 Mon, 10 Aug 2015 13:40:22 -0700 (PDT)
Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136])
 by smtp.gmail.com with ESMTPSA id fa8sm15491769wib.14.2015.08.10.13.40.20
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Mon, 10 Aug 2015 13:40:21 -0700 (PDT)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Pablo de Lara <pablo.de.lara.guarch@intel.com>
Date: Mon, 10 Aug 2015 22:39:08 +0200
Message-ID: <1690471.oTkHzXzv9N@xps13>
Organization: 6WIND
User-Agent: KMail/4.14.8 (Linux/4.0.4-2-ARCH; KDE/4.14.8; x86_64; ; )
In-Reply-To: <3011799.hGDSXbeMWp@xps13>
References: <1438938514-10304-1-git-send-email-pablo.de.lara.guarch@intel.com>
 <2075004.thyST47qJM@xps13> <3011799.hGDSXbeMWp@xps13>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2] examples/l3fwd: fix compilation issue
	when using exact-match
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 10 Aug 2015 20:40:23 -0000

2015-08-10 19:13, Thomas Monjalon:
> 2015-08-10 18:58, Thomas Monjalon:
> > Hi Pablo,
> > 
> > 2015-08-09 11:28, Pablo de Lara:
> > > From: "Pablo de Lara" <pablo.de.lara.guarch@intel.com>
> > > 
> > > L3fwd was trying to use an inexistent function "simple_ipv6_fwd_4pkts",
> > > instead it should be "simple_ipv6_fwd_8pkts", and "simple_ipv8_fwd_4pkts"
> > > instead of "simple_ipv4_fwd_8pkts".
> > > 
> > > Fixes: 80fcb4d4 ("examples/l3fwd: increase lookup burst size to 8")
> > > 
> > > Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
> > > Acked-by: Sergio Gonzalez Monroy <sergio.gonzalez.monroy@intel.com>
> > > ---
> > > 
> > > Changes in v2:
> > > 
> > > - Missing to fix additional type
> > 
> > More fixes are needed:
> > 
> > make RTE_SDK=$(readlink -m ../..) RTE_TARGET=x86_64-native-linuxapp-clang \
> > 	EXTRA_CFLAGS='-DAPP_LOOKUP_METHOD=APP_LOOKUP_EXACT_MATCH'
> > 
> > examples/l3fwd/main.c:545:1: error: unused function 'send_packetsx4'
> > examples/l3fwd/main.c:1165:1: error: unused function 'rfc1812_process'
> > 
> > The right fix would be to remove one APP_LOOKUP_METHOD.
> 
> Build flags are:
> - APP_LOOKUP_METHOD
> - DO_RFC_1812_CHECKS
> - defined(__SSE4_1__) -> ENABLE_MULTI_BUFFER_OPTIMIZE
> - RTE_NEXT_ABI
> 
> Waiting a cleanup for 2.2, this fix should be OK and will be applied:

Applied with additional fix.