From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id BFDF243036;
Fri, 11 Aug 2023 19:32:57 +0200 (CEST)
Received: from mails.dpdk.org (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id 3206A4327D;
Fri, 11 Aug 2023 19:32:27 +0200 (CEST)
Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182])
by mails.dpdk.org (Postfix) with ESMTP id 9746940E03;
Fri, 11 Aug 2023 19:32:20 +0200 (CEST)
Received: by linux.microsoft.com (Postfix, from userid 1086)
id 4665420FD0DE; Fri, 11 Aug 2023 10:32:19 -0700 (PDT)
DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 4665420FD0DE
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;
s=default; t=1691775139;
bh=sMKBL+NohsDO6AZHSYdW1rf/6l1XPI4Xiz05sRsAP6c=;
h=From:To:Cc:Subject:Date:In-Reply-To:References:From;
b=rOUN1a3+za8JFw6d+8lx0G4kIc4mycK+4E0ndzq+mxhHgZxqAjElghJvHPLnTxYLd
CXvD6RW+zG+RvFsLxj4Jif0ODA44w3l8kCXZK2JXuPl5Zo1l4tGHQaQrFUi7BxB4mQ
g9eaPYNqiZD9KXCydPU/YCvda0moGj1IqSS8n0U0=
From: Tyler Retzlaff <roretzla@linux.microsoft.com>
To: dev@dpdk.org
Cc: techboard@dpdk.org, Bruce Richardson <bruce.richardson@intel.com>,
Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>,
Ruifeng Wang <ruifeng.wang@arm.com>, Jerin Jacob <jerinj@marvell.com>,
Sunil Kumar Kori <skori@marvell.com>,
=?UTF-8?q?Mattias=20R=C3=B6nnblom?= <mattias.ronnblom@ericsson.com>,
Joyce Kong <joyce.kong@arm.com>,
David Christensen <drc@linux.vnet.ibm.com>,
Konstantin Ananyev <konstantin.v.ananyev@yandex.ru>,
David Hunt <david.hunt@intel.com>, Thomas Monjalon <thomas@monjalon.net>,
David Marchand <david.marchand@redhat.com>,
Tyler Retzlaff <roretzla@linux.microsoft.com>
Subject: [PATCH v2 6/6] devtools: forbid new direct use of GCC atomic builtins
Date: Fri, 11 Aug 2023 10:32:16 -0700
Message-Id: <1691775136-6460-7-git-send-email-roretzla@linux.microsoft.com>
X-Mailer: git-send-email 1.8.3.1
In-Reply-To: <1691775136-6460-1-git-send-email-roretzla@linux.microsoft.com>
References: <1691717521-1025-1-git-send-email-roretzla@linux.microsoft.com>
<1691775136-6460-1-git-send-email-roretzla@linux.microsoft.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Refrain from using compiler __atomic_xxx builtins DPDK now requires
the use of rte_atomic_<op>_explicit macros when operating on DPDK
atomic variables.
Signed-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>
Suggested-by: Morten Brørup <mb@smartsharesystems.com>
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
---
devtools/checkpatches.sh | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/devtools/checkpatches.sh b/devtools/checkpatches.sh
index 43f5e36..b15c3f7 100755
--- a/devtools/checkpatches.sh
+++ b/devtools/checkpatches.sh
@@ -111,11 +111,11 @@ check_forbidden_additions() { # <patch>
-f $(dirname $(readlink -f $0))/check-forbidden-tokens.awk \
"$1" || res=1
- # refrain from using compiler __atomic_{add,and,nand,or,sub,xor}_fetch()
+ # refrain from using compiler __atomic_xxx builtins
awk -v FOLDERS="lib drivers app examples" \
- -v EXPRESSIONS="__atomic_(add|and|nand|or|sub|xor)_fetch\\\(" \
+ -v EXPRESSIONS="__atomic_.*\\\(" \
-v RET_ON_FAIL=1 \
- -v MESSAGE='Using __atomic_op_fetch, prefer __atomic_fetch_op' \
+ -v MESSAGE='Using __atomic_xxx builtins' \
-f $(dirname $(readlink -f $0))/check-forbidden-tokens.awk \
"$1" || res=1
--
1.8.3.1