From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4FC2BA04F0; Mon, 16 Dec 2019 17:47:07 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2EFCF288C; Mon, 16 Dec 2019 17:47:07 +0100 (CET) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id 62D53288C for ; Mon, 16 Dec 2019 17:47:06 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 0E3EE21F7D; Mon, 16 Dec 2019 11:47:06 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Mon, 16 Dec 2019 11:47:06 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=Z/OdqHINLv2tu7zH2OalBwcbfaUxXsPw19d+2zSlk+g=; b=cYz+SFl6Zs4Y Ts7hMNq9nPTjizSySl7Lnfl41pJDvcGu9cQAhkLZGlS0pRqTU42Xr9St+2+FQdWb oWRJ59NYZR9HSCAJnxiSrl+RxddToilSTSjYLG4K6Db2u0pD16Gp/z1AFBXYAkbO ZC6sn3SrRaBg5bRoxrLjGdSARCxm9vg= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=Z/OdqHINLv2tu7zH2OalBwcbfaUxXsPw19d+2zSlk +g=; b=F1kGRd2xrDDJD/j909GleuO09E0iY/RzS5HnES1srOaGio0nm5sDg/bNy 8ZekGm+4ep+0uGKckJ96pzI+ysRvUQC6bb1GlR+omf9POMyiwI2U7Fk3WLkdgbVj BrV+FB36P4oem88sTxDI6xHkA4i0oXjizCWusULOqavgS4xVBx/1rcDxcthayDef iLQew10haIgNpcENtIlJrHA/ZY6Dz0Hidyoju3Ya/gAxuB7n73gmGVrJiVc3JvzU FTbkQXYTRf3Yr3LP8GOlE6m8ReB1/h7s/Xeembfm6q/t1Fw+JsC4apCphayeZnFP jAfDclC8Xx7z83KiXnUIYNbeJtxeA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedufedrvddthedgleefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecuff homhgrihhnpehfrhgvvggsshgurdhorhhgnecukfhppeejjedrudefgedrvddtfedrudek geenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnh gvthenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id EF78780059; Mon, 16 Dec 2019 11:47:04 -0500 (EST) From: Thomas Monjalon To: Bruce Richardson Cc: dev@dpdk.org, olivier.matz@6wind.com, Ali Alnubani , David Marchand Date: Mon, 16 Dec 2019 17:47:03 +0100 Message-ID: <1692365.TPV5GobrPX@xps> In-Reply-To: <20191216164011.GA445@bricha3-MOBL.ger.corp.intel.com> References: <20191216162242.1898285-1-thomas@monjalon.net> <20191216164011.GA445@bricha3-MOBL.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] devtools: avoid config backup during test build setup X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 16/12/2019 17:40, Bruce Richardson: > On Mon, Dec 16, 2019 at 05:22:42PM +0100, Thomas Monjalon wrote: > > The config options are updated with sed and the short inline option. > > In FreeBSD, the suffix argument of the inline option is mandatory. > > In order to avoid creating a backup file when using sed inline, > > the argument is set as an empty suffix. > > > > The short option '-i' does not expect '=' before the suffix argument, > > so it understands '=' as the file suffix. > > As a consequence, a backup file named '.config=' was created > > in the build directory. > > > > Removing the '=' sign while keeping an empty suffix > > avoids creating a backup file. > > > > Fixes: 4a4a20c4775b ("devtools: support FreeBSD") > > Cc: olivier.matz@6wind.com > > Cc: stable@dpdk.org > > > > Reported-by: Ali Alnubani > > Signed-off-by: Thomas Monjalon > > --- > > > > This patch does not work on FreeBSD. > > Does it mean the equal sign is required on FreeBSD? > > This is not what I see on the documentation: > > https://www.freebsd.org/cgi/man.cgi?query=sed&sektion=&n=1 > > > > --- > > It appears it is needed, which is why the "=" was added in the first place. > See commit: 4a4a20c4775b ("devtools: support FreeBSD"), by Olivier > > Is having the backup file a big issue? No it's not a big issue. But I really would like to know how to have a common behaviour on BSD an Linux for a thing as simple as "sed -i" ! And why the mandatory "=" is not documented on FreeBSD? It cannot be so much broken. We probably miss something...