From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Jianfeng Tan <jianfeng.tan@intel.com>
Cc: dev@dpdk.org,
Sergio Gonzalez Monroy <sergio.gonzalez.monroy@intel.com>,
benjamin.walker@intel.com, stable@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] eal/linux: fix multi-process cannot work
Date: Tue, 04 Apr 2017 11:58:39 +0200 [thread overview]
Message-ID: <1692898.PdBQoVJhCZ@xps13> (raw)
In-Reply-To: <7c01afcd-20a7-f2a0-f230-04e5b04fb3c9@intel.com>
2017-03-29 16:19, Sergio Gonzalez Monroy:
> On 16/03/2017 16:28, Jianfeng Tan wrote:
> > When binding with vfio-pci, secondary process cannot be started with
> > an error message:
> >
> > cannot find TAILQ entry for PCI device.
> >
> > It's due to: struct rte_pci_addr is padded with 1 byte for alignment
> > by compiler. Then below comparison in commit 2f4adfad0a69
> > ("vfio: add multiprocess support") will fail if the last byte is not
> > initialized.
> >
> > memcmp(&vfio_res->pci_addr, &dev->addr, sizeof(dev->addr)
> >
> > And commit cdc242f260e7 ("eal/linux: support running as unprivileged user")
> > just triggers this bug by using a stack un-initialized variable.
> >
> > The fix is to use rte_eal_compare_pci_addr() for pci addr comparison.
> >
> > Fixes: 2f4adfad0a69 ("vfio: add multiprocess support")
> > Fixes: cdc242f260e7 ("eal/linux: support running as unprivileged user")
> > CC: stable@dpdk.org
> >
> > Reported-by: Rutkowski, Pawel <pawelx.rutkowski@intel.com>
> > Signed-off-by: Jianfeng Tan <jianfeng.tan@intel.com>
>
> Acked-by: Sergio Gonzalez Monroy <sergio.gonzalez.monroy@intel.com>
Applied, thanks
prev parent reply other threads:[~2017-04-04 9:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-16 16:28 Jianfeng Tan
2017-03-29 15:19 ` Sergio Gonzalez Monroy
2017-04-04 9:58 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1692898.PdBQoVJhCZ@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=benjamin.walker@intel.com \
--cc=dev@dpdk.org \
--cc=jianfeng.tan@intel.com \
--cc=sergio.gonzalez.monroy@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).