From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wg0-f47.google.com (mail-wg0-f47.google.com [74.125.82.47]) by dpdk.org (Postfix) with ESMTP id 2056F255 for ; Fri, 30 Jan 2015 11:18:46 +0100 (CET) Received: by mail-wg0-f47.google.com with SMTP id n12so26021755wgh.6 for ; Fri, 30 Jan 2015 02:18:46 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=hL1inhK4Me21YPqHRoSkGknBKpBQWcPdr5wlVDVzPuo=; b=YvLMWfJP5jRCglW4bd4SgVZYWJDEGWLRzxKpyVf/jHZ4EN6Ov7T2+xxeygAa0VDsXA Ao2ase46nnOvkX0uGLqv7hLdSLQaVrdJgzkb5O0UQYTUvFYWg2zbYfUg2iiYVuPC4ehD 13+V5tnfUS/EaykUjv5GP9pKMEzZme3mlfHS4YVD/BWLAKwk74Q3Pmi04lnP7xD2Q1OU tkq+/ByV7gPysRzeKZs3sR0rPGyPNXry2o56AcsJVWFBT6cXem1Jf1KXVGIqT6FIdq5y wIYw8Te3J2qriswcIQtNXKYJEl9EEC7E/AK4hv06GFeVfJq+bIlPO1/FFH5H+PTAdiCJ kioQ== X-Gm-Message-State: ALoCoQmw46gUm66uoWrqvYhLZ+weRpBteCStSlFOSvrwJkj0SD3uuyG3k33MaDgGSd6cJn1EGWBC X-Received: by 10.181.28.168 with SMTP id jp8mr3388151wid.40.1422613126000; Fri, 30 Jan 2015 02:18:46 -0800 (PST) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id p6sm14237192wjf.39.2015.01.30.02.18.44 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 30 Jan 2015 02:18:45 -0800 (PST) From: Thomas Monjalon To: Neil Horman Date: Fri, 30 Jan 2015 11:18:19 +0100 Message-ID: <1692949.19G84kSIeU@xps13> Organization: 6WIND User-Agent: KMail/4.14.4 (Linux/3.18.4-1-ARCH; KDE/4.14.4; x86_64; ; ) In-Reply-To: <20150127180640.GB20118@hmsreliant.think-freely.org> References: <1422373493-9816-1-git-send-email-danielx.t.mrzyglod@intel.com> <20150127180640.GB20118@hmsreliant.think-freely.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v3] test: fix missing NULL pointer checks X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 30 Jan 2015 10:18:46 -0000 2015-01-27 13:06, Neil Horman: > On Tue, Jan 27, 2015 at 04:44:53PM +0100, Daniel Mrzyglod wrote: > > In test_sched, we are missing NULL pointer checks after create_mempool() > > and rte_pktmbuf_alloc(). Add in these checks using TEST_ASSERT_NOT_NULL macros. > > > > VERIFY macro was removed and replaced by standard test ASSERTS from "test.h" header. > > This provides additional information to track when the failure occured. > > > > v3 changes: > > - remove VERIFY macro > > - fix spelling error. > > - change unproper comment > > > > v2 changes: > > - Replace all VERIFY macros instances by proper TEST_ASSERT* macros. > > - fix description > > > > v1 changes: > > - first iteration of patch using VERIFY macro. > > > > Signed-off-by: Daniel Mrzyglod > > These TEST_ASSERT macros are no better than the VERIFY macro, they contain > exaxtly the same return issue that I outlined in my first post on the subject. Neil, you are suggesting to rework the assert macros of the unit tests. It should be another patch. Here, Daniel is improving the sched test with existing macros. I think it should be applied. -- Thomas