From: Thomas Monjalon <thomas@monjalon.net>
To: Maxime Gouin <maxime.gouin@6wind.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"Zhang, Qi Z" <qi.z.zhang@intel.com>,
"Zhang, Tianfei" <tianfei.zhang@intel.com>,
Olivier Matz <olivier.matz@6wind.com>,
"Huang, Wei" <wei.huang@intel.com>,
"Xu, Rosen" <rosen.xu@intel.com>
Subject: Re: [PATCH] bus/ifpga: remove useless check while browsing devices
Date: Wed, 19 Jan 2022 17:53:39 +0100 [thread overview]
Message-ID: <1693683.K4a6FZZPjd@thomas> (raw)
In-Reply-To: <DM6PR11MB425209550932B9F31BE167E489539@DM6PR11MB4252.namprd11.prod.outlook.com>
> > reported by code analysis tool C++test (version 10.4):
> >
> > > /build/dpdk-20.11/drivers/bus/ifpga/ifpga_bus.c
> > > 67 Condition "afu_dev" is always evaluated to true
> > > 81 Condition "afu_dev" is always evaluated to true
> >
> > The "for" loop already checks that afu_dev is not NULL.
> >
> > Fixes: 05fa3d4a6539 ("bus/ifpga: add Intel FPGA bus library")
> >
> > Signed-off-by: Maxime Gouin <maxime.gouin@6wind.com>
> > Reviewed-by: Olivier Matz <olivier.matz@6wind.com>
>
> Acked-by: Rosen Xu <rosen.xu@intel.com>
Applied, thanks
prev parent reply other threads:[~2022-01-19 16:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-05 10:26 Maxime Gouin
2022-01-11 15:12 ` Kevin Traynor
2022-01-13 14:19 ` Xu, Rosen
2022-01-19 16:53 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1693683.K4a6FZZPjd@thomas \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=maxime.gouin@6wind.com \
--cc=olivier.matz@6wind.com \
--cc=qi.z.zhang@intel.com \
--cc=rosen.xu@intel.com \
--cc=tianfei.zhang@intel.com \
--cc=wei.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).