From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (xvm-189-124.dc0.ghst.net [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E5137A0524; Thu, 7 Jan 2021 11:11:50 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 85202140F26; Thu, 7 Jan 2021 11:11:50 +0100 (CET) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by mails.dpdk.org (Postfix) with ESMTP id AEC43140F1C for ; Thu, 7 Jan 2021 11:11:48 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id 142565C018D; Thu, 7 Jan 2021 05:11:48 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Thu, 07 Jan 2021 05:11:48 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm3; bh= TSGQ7Tkp3+YTDaqYO2zaPyqj1GVf4iM8Mp4HKxwTQtk=; b=dqHSKqjcaV8+lo+r 5Lr7MJB2GJCdg7MCYelrT8w6EvVkw5lBFb3oSp9r954RbAYZiIyiJewOnXl9iByu MjSQxWaa0iE9arAvE+e/9i49+yTOlH+Q2waRRO+QhQvnEsD7OSvPMPw3BiHuhIqG +yAY4+qYI9m+vFuuiN79W4cJ/hE5RnvmeDPm8cWDHMh44YqmToqayMajouG+zmu4 PKXmXEmIi8qy8XLyh96o9uW5OeRt7KTKDBZCthUIQABps54BqfIavFNJ4JJB4vj4 hS0aHCz0fk4qN5xyXgLTfcFTYXMsIcbNlhEZCp4UD5T+3/pRWl2TnW/qCoEPf5ag rRcsSg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=TSGQ7Tkp3+YTDaqYO2zaPyqj1GVf4iM8Mp4HKxwTQ tk=; b=iA/tVCsmtDU2CBmIElKEiTunr9ifcb736c1Zwf5/OGMGGvOa3ZdQWh0KH HuHtUwTJVijQ46Tm9GlZA/m8KpKRog/wJyjcBjwMMmBIE/dfN2D2pwY+1CgtwDaV n9+gvitzzfI7nZ+swQFTddHNB3uCa4uBxQZdaEZ0lEOE3gxeifW0b5GO3CIuGepd 3Ma5I+NpAaOzEWM0Amh3yiPq1gxwfR4Y7nOkV73azQqQgGHAURz6YX7A0Ue+tCzA Rbe1h7vIn1TA/8gDaBSpGDfOyE6fRdCl26tDZDL2pmQmosCrWuklFzN4PJFhFKZY UCs7zW2fMEBTxmAcrc1QwOzGK4b4A== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrvdegvddgudefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 0A5DD1080059; Thu, 7 Jan 2021 05:11:45 -0500 (EST) From: Thomas Monjalon To: "Guo, Jia" Cc: "Zhang, Qi Z" , "Wu, Jingjing" , "Yang, Qiming" , "Wang, Haiyue" , "dev@dpdk.org" , "Yigit, Ferruh" , "andrew.rybchenko@oktetlabs.ru" , orika@nvidia.com, getelson@nvidia.com Date: Thu, 07 Jan 2021 11:11:44 +0100 Message-ID: <1693993.jziF1hSf6E@thomas> In-Reply-To: References: <20201216085854.7842-1-jia.guo@intel.com> <8091331.oFBQTsvStG@thomas> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [dpdk-dev v2 1/2] ethdev: add new tunnel type for ecpri X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 07/01/2021 10:32, Guo, Jia: > From: Thomas Monjalon > > 24/12/2020 07:59, Jeff Guo: > > > Add type of RTE_TUNNEL_TYPE_ECPRI into the enum of ethdev tunnel > > type. > > > > > > Signed-off-by: Jeff Guo > > > Reviewed-by: Qi Zhang > > [...] > > > --- a/lib/librte_ethdev/rte_ethdev.h > > > +++ b/lib/librte_ethdev/rte_ethdev.h > > > @@ -1219,6 +1219,7 @@ enum rte_eth_tunnel_type { > > > RTE_TUNNEL_TYPE_IP_IN_GRE, > > > RTE_L2_TUNNEL_TYPE_E_TAG, > > > RTE_TUNNEL_TYPE_VXLAN_GPE, > > > + RTE_TUNNEL_TYPE_ECPRI, > > > RTE_TUNNEL_TYPE_MAX, > > > }; > > > > We tried to remove all these legacy API in DPDK 20.11. > > Andrew decided to not remove this one because it is not yet completely > > replaced by rte_flow in all drivers. > > However, I am against continuing to update this API. > > The opposite work should be done: migrate to rte_flow. > > Agree but seems that the legacy api and driver legacy implementation > still keep in this release, and there is no a general way to replace > the legacy by rte_flow right now. I think rte_flow is a complete replacement with more features. You can match, encap, decap. There is even a new API to get tunnel infos after decap. What is missing? > > Sorry, it is a nack. > > BTW, it is probably breaking the ABI because of RTE_TUNNEL_TYPE_MAX. > > Oh, the ABI break should be a problem. > > > PS: please Cc ethdev maintainers for such patch, thanks. > > tip: use --cc-cmd devtools/get-maintainer.sh > > Thanks for your helpful tip.