DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: "Iremonger, Bernard" <bernard.iremonger@intel.com>,
	"Li, Xiaoyun" <xiaoyun.li@intel.com>
Cc: "Lu, Wenzhuo" <wenzhuo.lu@intel.com>,
	"Wu, Jingjing" <jingjing.wu@intel.com>,
	"dev@dpdk.org" <dev@dpdk.org>,
	ferruh.yigit@intel.com
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] app/testpmd: fix dcb config failure
Date: Thu, 26 Jul 2018 19:18:20 +0200	[thread overview]
Message-ID: <1694337.hYEmcJhZCz@xps> (raw)
In-Reply-To: <8CEF83825BEC744B83065625E567D7C260CCF024@IRSMSX107.ger.corp.intel.com>

> > After adding RSS hash offload check, default rss_hf will fail on devices that do
> > not support all bits. This will lead to dcb config failure. The patch fixes this
> > issue by taking rss_hf as a suggested value and only setting bits that the
> > device supports based on rte_eth_dev_get_info.
> > 
> > Fixes: 8863a1fbfc66 ("ethdev: add supported hash function check")
> > Fixes: 1a572499beb6 ("app/testpmd: setup DCB forwarding based on traffic
> > class")
> > Cc: stable@dpdk.org
> > 
> > Signed-off-by: Xiaoyun Li <xiaoyun.li@intel.com>
> 
> Acked-by: Bernard Iremonger <bernard.iremonger@intel.com>

NACK

testpmd is a test application for developpers.
It must fail if the PMD cannot support user-requested features.

For other applications, there can be a smooth fallback
if and only if there are appropriate logs.
This is what Ferruh did for examples:
	http://git.dpdk.org/dpdk/commit/?id=4f5701f28bd

  reply	other threads:[~2018-07-26 17:18 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-24 11:32 [dpdk-dev] " Xiaoyun Li
2018-07-24 16:16 ` Iremonger, Bernard
2018-07-26 17:18   ` Thomas Monjalon [this message]
2018-07-31 14:43 ` [dpdk-dev] [PATCH v2] " Konstantin Ananyev
2018-08-01  8:46   ` Iremonger, Bernard
2018-08-01 14:32     ` Thomas Monjalon
2018-08-02  2:31   ` Zhao, MeijuanX

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1694337.hYEmcJhZCz@xps \
    --to=thomas@monjalon.net \
    --cc=bernard.iremonger@intel.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=jingjing.wu@intel.com \
    --cc=wenzhuo.lu@intel.com \
    --cc=xiaoyun.li@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).