From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C05CFA00C5; Wed, 2 Feb 2022 15:44:55 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4A35640688; Wed, 2 Feb 2022 15:44:55 +0100 (CET) Received: from wout5-smtp.messagingengine.com (wout5-smtp.messagingengine.com [64.147.123.21]) by mails.dpdk.org (Postfix) with ESMTP id C797840141 for ; Wed, 2 Feb 2022 15:44:53 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id 661FB3202254; Wed, 2 Feb 2022 09:44:52 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Wed, 02 Feb 2022 09:44:52 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; bh=D+TMmwEKZY284o oU2rWRrhSJdezP2wzw8TTtPEmWdSI=; b=jxyxTNYmwV7MQZc5iYwERZPiw7EPI2 PHmIUu7Pdo0k+jQhTvlcyclGzDGEKDldSOCzlARS62KsyZo41U5aGB2Dat9yxyYE q6uLxg1Cv0D4wv+XVWtkIWe3L1nZ6l5gQE00rcgTqBuKAu3+hjtYoFEuj/s0NFG+ HJmj+KqrD5hQJBCVRv/PQ4ZOnHwuKq06fvmrhaANskPaShVuj85PRlkKQ1WKK1z9 JXr+ehJ8pfzMp3w3SnYe5xc8X9Jxy0h6EicZm/+JrVWWoJpjG1JofwTqkAgoX8Pv 8rGjFPSIWsOZBv2h9AqRglNiWRM5tTXjiwuWgfleugbsiQ/X+ss62o5g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=D+TMmwEKZY284ooU2rWRrhSJdezP2wzw8TTtPEmWd SI=; b=GV8yCNG6yIpfR4p6zM8DeDiRZdGUhkMwxop5sjbINon3j7OG/fd6/lb+j VxMto3knJ04k/2Tm8CBWh6pSFTsDxwwkO0QbLzpwHBA9adax+jXaUFUkI+kAhWOY nmPjji9LpS25o7dACZZ33yHvtLtUWI0RKzV65AvdmpbrEB4A45Rox4U4QmmRST07 rC/GuwphyjwgWlB879vfQnTgnQXaACn/LE2IP3XI9zGQC2xxTagbdVKn0uRZ3FrL l3NvAe1qilddZPa87DyKylXDmzYZlLqgiCtC5VfUi0uTRG2UUie/El0rdXPhqZkX rPRe1YsHqjz1J68WNekCdYTjl/S9w== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrgeehgdeilecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdejueei iedvffegheenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhroh hmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 2 Feb 2022 09:44:51 -0500 (EST) From: Thomas Monjalon To: Bruce Richardson Cc: dev@dpdk.org, Jerin Jacob Subject: Re: [PATCH v2] build: fix warnings when running external commands Date: Wed, 02 Feb 2022 15:44:49 +0100 Message-ID: <1694573.X513TT2pbd@thomas> In-Reply-To: References: <20220120180639.808436-1-bruce.richardson@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 24/01/2022 15:08, Jerin Jacob: > On Thu, Jan 20, 2022 at 11:37 PM Bruce Richardson > wrote: > > > > Meson 0.61.1 is giving warnings that the calls to run_command do not > > always explicitly specify if the result is to be checked or not, i.e. > > there is a missing "check" parameter. This is because the default > > behaviour without the parameter is due to change in the future. > > > > We can fix these warnings by explicitly adding into each call whether > > the result should be checked by meson or not. This patch therefore > > adds in "check: false" to each run_command call where the result is > > being checked by the DPDK meson.build code afterwards, and adds in > > "check: true" to any calls where the result is currently unchecked. > > > > Bugzilla-id: 921 > > > > Reported-by: Jerin Jacob > > Signed-off-by: Bruce Richardson > > Tested-by: Jerin Jacob Applied, thanks.