From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 3A5251B6D4 for ; Tue, 6 Feb 2018 18:50:39 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id C094620D38; Tue, 6 Feb 2018 12:50:38 -0500 (EST) Received: from frontend1 ([10.202.2.160]) by compute1.internal (MEProxy); Tue, 06 Feb 2018 12:50:38 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=0qa85aj/bkvYK6bSI680ABEJFH KQK76OP3i08Iw1eJo=; b=hK4G4sfrU2XSrgbNSPbOURvJbQs3AU/V5GWwGPsRCD uVbGYnMqtXBZwyKZncs8o4dAxag+Sud9jjgSz+xqHl54DQkzVqnrYIo1McC5wzYc hnqqHS7x3BBOHuCTm+wBfKE0wmhLTzIlwx/WHJP9xV0ga3lCw/EvRH2nEPZF6Lq/ A= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=0qa85a j/bkvYK6bSI680ABEJFHKQK76OP3i08Iw1eJo=; b=ThPEVeFa/0o96/7/B316UB hk00MbfrmHKQ2jsk+Eh1uf56piQEg7hDkdh9rI4Z9ozHNh+c3ed+dXM077BMBjUk QzVg8YczEOSPWGeWUWHxhRy35oiGYSnm+72d43xQZVWhUF40zjmURhIevt6lqjRd FkVZETOfheXwzWktpP693LBQCLs2CduEeyJHdzwFQMeyFZfQaA9zVR2m+1q+Uj+9 AjYx0ilOOu6eAa2a+PebL20mUev9wU1tkq5uWH3grQmHlyatp+r05QSnLrd1QFjO taYTc6XwgdeWA49PPT95dDHm6bbTYrhmF2njoKYVMjXAJ35JHV2wffjJ7LHndwMA == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 836677E571; Tue, 6 Feb 2018 12:50:38 -0500 (EST) From: Thomas Monjalon To: Amr Mokhtar Cc: dev@dpdk.org, ferruh.yigit@intel.com Date: Tue, 06 Feb 2018 18:50:34 +0100 Message-ID: <1695986.x6khAz695a@xps> In-Reply-To: <1517923770-45640-1-git-send-email-amr.mokhtar@intel.com> References: <1517869651-145451-1-git-send-email-amr.mokhtar@intel.com> <1517923770-45640-1-git-send-email-amr.mokhtar@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2] bbdev: fix exported dynamic log type X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Feb 2018 17:50:39 -0000 06/02/2018 14:29, Amr Mokhtar: > This patch fixes shared library compilation due to undefined > reference to an exported variable 'bbdev_logtype'. > > v2: > * In this fix, > * - The logtype has become static and owned individually by each > * component. > * - Helper logging macros are removed from bbdev lib header files > * and replaced with macros defined by each driver at its ease. > * - 'bbdev_logtype' removed from .map > > v1: > * This patch fixes shared library compilation due to undefined > * reference to an exported variable 'bbdev_logtype'. > * In this fix, the logtype is converted to static in the bbdev lib, > * in bbdev null pmd and turbo sw pmd. > > > Fixes: 4935e1e9f76e ("bbdev: introduce wireless base band device lib") > Fixes: b8cfe2c9aed2 ("bb/turbo_sw: add software turbo driver") > Fixes: 7dc2b1589440 ("bb/null: add null base band device driver") > Cc: thomas@monjalon.net > > Signed-off-by: Amr Mokhtar Applied, thanks