From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 975BAA00C5; Wed, 16 Feb 2022 09:45:41 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 82707410FB; Wed, 16 Feb 2022 09:45:41 +0100 (CET) Received: from wnew3-smtp.messagingengine.com (wnew3-smtp.messagingengine.com [64.147.123.17]) by mails.dpdk.org (Postfix) with ESMTP id 7B9744013F for ; Wed, 16 Feb 2022 09:45:40 +0100 (CET) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailnew.west.internal (Postfix) with ESMTP id 676E42B00222; Wed, 16 Feb 2022 03:45:38 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Wed, 16 Feb 2022 03:45:39 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; bh=bk7Ky4Vg+9OsSF ikpWmBe5Ufxiummk0MOOeqhjIclUg=; b=G1g7jkXid4SojCulIi7/1rankc8xOt QhuE1Xqo/k6vA2BpQQCEbD3tV3l7lRlo4FcNDK0hE80dP7CXGXhWCy0DW8wJDHKe x+Dlh/gshC3Irv5wf0d0X5Jgao1bnJFCKeXrtUZ/jjBP31Hz3rO0cSmzkBVO9teE VjX72Lak4lrlXehy9Y0mJpZOdyEzBc3uLRpnz/VegbQdzSObtC8tEtW72vbuBDbv Tbkv1jYS4ILbg+Chrtd1N0VbWiNd4Nixql2Sb2puTBaFM/guWgZRt9GrhBUrs7wC H6p82ODFNQ8iWhRsmnlxdQgxqzyPW7u4edwSgrpwiMqw3Cr1Ojqo/9/g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=bk7Ky4Vg+9OsSFikpWmBe5Ufxiummk0MOOeqhjIcl Ug=; b=olnteFhjYdIOs6ZQW3WOD5tzM/3CE+Rf6tgBSau9Tksy1QPpyU1K7g9GH 4X55WmXbFHHg+If3Kfgy8lMoKTPL1s7lQXDKAEeFBgPvtNwJlKJ0G4W9wqAms4A3 Lm9Jzcuf0OGHhoEEb8m7l0ZU/0aAJWDX34EjPA36rdWMydhEH3VFgweBPiQXwnOy CsNTiw0XFuQc7OFdEyeppU+FRt8FbmfXzfFceNttDUXAfUumFJrJjNjzHqY+10hX srlUkDdixkQqo/j0LA10FH3/nIXQFLuGtrmDMTj9SsSKB4mF8dAzd2xetUW8ZmsV WVlbjTg30p+XyBGPN/d16fwh8Nu+w== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrjeehgdduvdduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 16 Feb 2022 03:45:36 -0500 (EST) From: Thomas Monjalon To: "Zhang, RobinX" , "Yigit, Ferruh" Cc: dev@dpdk.org, "Zhang, Qi Z" , "Li, Xiaoyun" , "Singh, Aman Deep" , "Zhang, Yuying" , "Guo, Junfeng" , "Yang, SteveX" , David Marchand , bruce.richardson@intel.com, ciara.power@intel.com Subject: Re: [PATCH] app/testpmd: format dump information of module EEPROM Date: Wed, 16 Feb 2022 09:45:33 +0100 Message-ID: <1696182.K4a6FZZPjd@thomas> In-Reply-To: References: <20220215101853.919735-1-robinx.zhang@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 16/02/2022 09:03, David Marchand: > On Wed, Feb 16, 2022 at 3:27 AM Zhang, RobinX wrote: > > The idea behind this is to monitor the quality of the link in the field during testpmd operations. > > It is supported in Linux driver with ethtool command "ethtool -m xxx", but missing in DPDK. That's why the bifurcated model used by mlx drivers is so much valuable: you can use such ethtool command while using DPDK. > > This feature is requested by customer 6WIND and we have been told this is highly important in production. > > 6WIND also mentioned some other customers: NEC, EOLO and Open Systems. > > Similar request also received from customer CheckPoint. > > > > > > What do you think to have this as a sample application? > > > > > > It can be in the directory app/ maybe. > > > > Base on the above background, I'm not sure if customer could accept this feature as a sample application. > > Rather than add this in testpmd or a sample app, does it make sense to > provide this info as a telemetry command? > This makes those status information available in any dpdk application. +1 Production code should be in a DPDK library. > There is a "but" with this proposal. > Existing applications might have been calling "eeprom" ethdev API > already, and adding such a callback in telemetry could lead to > concurrency issues. > > I see that we have other telemetry callbacks for stats, link status > which might already have the issue. You mean there is no lock protection? Neither in the API, nor in telemetry?