From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 843A0A0A05; Wed, 20 Jan 2021 14:15:43 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 19627140D20; Wed, 20 Jan 2021 14:15:43 +0100 (CET) Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by mails.dpdk.org (Postfix) with ESMTP id 01767140D1D for ; Wed, 20 Jan 2021 14:15:40 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id 0BA775C01BA; Wed, 20 Jan 2021 08:15:38 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Wed, 20 Jan 2021 08:15:38 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm3; bh= Tk/WH9OC12oePWlOJu6rYzunDbhaWhopTWc0KR4kMRQ=; b=a9mb9Sh7fb5tDH22 nVyQs35s8dhecqQwl5N0Z/PHovl76MeUjVGvr/q7w0ExH24DpGNr0B9mNHx8ZxfY kw2AzDwLLx2rYLTYehsqXs67qYR98yENz/+g6SDc+Tok+UGCMFratLFsGSd0QK8K b04whnL34KBYetmM6c2KkR7WBZ1WcXmzYwyc1Sj52mQJQQvXKN3FTOMVMu3wmMdJ gEQIDMRt8XSfR6OY64cb+9dHPMYrsTd6STuFctrqMQunhl36PrnP6Pc8NxdtIW0u zxFPVSEwb9k5DnssLdWR+XG9mxRbrtRnix1CFRV4PJUSREnLS3EPOhzUSDVCh8D4 OCGg4w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=Tk/WH9OC12oePWlOJu6rYzunDbhaWhopTWc0KR4kM RQ=; b=NnOzsQF+kQAFQviN23FpRxOZaPfhk6VqAh2m7O58rJ/5k4ubZfv5HgYcX mdDrE1l4bMIpfSmJle4JIXBVoAG6e1fTUHwR++vlGN/1H5bN+wYzmDsY6/n27Fj/ uFTL77FVkbEyZzi3dzK/oKJBkJ4OKgcmQjZScBZsDVEFxW/n+r0xfWXBTb0fYEMt pIXCyR78Y7OCb4qd+B91U1EMaV8iT6j9SuN57sKPdhok97oALRD99pH6I1CzBRNd lDEc/knRnjcyseXUplRbO9670+OvndI8gbZuf9fIZY11YLr5cLz9aYb1YSJB5wv/ ODqZa1YLEOaPm3Je+p4kxheges2+g== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledruddvgdehvdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdejueei iedvffegheenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuih iivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhho nhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 5FC3F24005A; Wed, 20 Jan 2021 08:15:36 -0500 (EST) From: Thomas Monjalon To: "Gujjar, Abhinandan S" , "Kinsella, Ray" , mdr@ashroe.eu Cc: "dev@dpdk.org" , "Ananyev, Konstantin" , Akhil Goyal , "aconole@redhat.com" , "david.marchand@redhat.com" Date: Wed, 20 Jan 2021 14:15:34 +0100 Message-ID: <1697053.2DkutoUMdu@thomas> In-Reply-To: References: <20201222144243.552262-1-abhinandan.gujjar@intel.com> <5458566.rWvySYnu6v@thomas> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v7 1/2] cryptodev: support enqueue and dequeue callback functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 20/01/2021 14:01, Kinsella, Ray: > From: Thomas Monjalon > > 15/01/2021 17:01, Akhil Goyal: > > > > This patch adds APIs to add/remove callback functions on crypto > > > > enqueue/dequeue burst. The callback function will be called for > > each > > > > burst of crypto ops received/sent on a given crypto device queue > > > > pair. > > > > > > > > Signed-off-by: Abhinandan Gujjar > > > > Acked-by: Konstantin Ananyev > > > > --- > > > Series applied to dpdk-next-crypto > > > > > > It is missing a rule to ignore the false positive ABI break: > > > > --- a/devtools/libabigail.abignore > > +++ b/devtools/libabigail.abignore > > @@ -11,3 +11,8 @@ > > ; Explicit ignore for driver-only ABI > > [suppress_type] > > name = eth_dev_ops > > + > > +; Ignore fields inserted in cacheline boundary of rte_cryptodev > > +[suppress_type] > > + name = rte_cryptodev > > + has_data_member_inserted_between = {0, 1023} > > > > This is a bit of a blunt instrument as the range quiet large? The range is in bits. It matches the actual size of the struct for 64B cacheline. > {offset_after(attached), end} instead works better - I will send a patch. Yes that's exactly what David told me earlier today. > > I'll add this change while pulling in the main tree. Yes please. Note: we missed requiring this exception rule in the original patch.