From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f49.google.com (mail-wm0-f49.google.com [74.125.82.49]) by dpdk.org (Postfix) with ESMTP id 1010D2C05 for ; Wed, 30 Mar 2016 12:54:45 +0200 (CEST) Received: by mail-wm0-f49.google.com with SMTP id 127so92222497wmu.1 for ; Wed, 30 Mar 2016 03:54:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=+TabWtEXpVHYJ351UziLKBfVwsOuhsC978CCmlmS2IY=; b=gIk1SSM1pdCY6olhhq/pt2vQSJfTbTUJpm/axq88kTYyjyuxDKGgnLhGMMAi8oJKU5 wBzXUp/5F1dPhISS3DBriIQ1Tbku/hHMU5MjWtG7Y4x5XMu3RNZFCYo9taHoG/XR+u+5 Pyy0TqascXm18YAb3ZRBtblYegnn0ri5PsifakZSwQifMprp4aIxftdE3DQPs9jaSSHq uDd9xXKSvPS6io4OxSZwsU3oZFOCBRE1V8+vRRMO4dr5CexZuGm3bAd/i77zwlGFYSru 226GE7XbxsZchsl13wEEtycIVhdWD1neJCY6VRst4HKNlxnFF2UgMhma9KsxoLfH669u 25mw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding; bh=+TabWtEXpVHYJ351UziLKBfVwsOuhsC978CCmlmS2IY=; b=jjV6M7q8gQ9dsjHrVyG1jcbFDdjIFvliUwJYuAlGfC44ijSnfdYFvE75s2h+lIxLB2 0AJ7+LgBDMfJW90s6aKZquawwAIpD0OHXikOGBZ7zX+3EUXtUGG0J15pQZ2V4hroNAQ4 ie8hu5Uxtghpp4RdaMinLrx2RXFFTAQ/He/scvFe8YQgqd5ao9gD85LuatsyCIbpBAzJ /wmxmqB45kp0ZuIUJjhL+u2x3Bfr8v9iPEbV5XSr5Il1wNrojZLMLIgq6VWK++6Zwm8h g5Jvz8Cv19WpXoFF0BpTLYqbkzd1BqaLyc7UeXYbY3h++93HR24h7k357eNNkJqKSPOL F/uQ== X-Gm-Message-State: AD7BkJI6LepLiB2gOE/iLQ+HAWVvIci75BNmmUrYNZdnDgR0c/3IWQZAkWUHrOUUZop80Ral X-Received: by 10.28.139.129 with SMTP id n123mr9270602wmd.13.1459335284851; Wed, 30 Mar 2016 03:54:44 -0700 (PDT) Received: from xps13.localnet (guy78-3-82-239-227-177.fbx.proxad.net. [82.239.227.177]) by smtp.gmail.com with ESMTPSA id u14sm19106164wmu.8.2016.03.30.03.54.43 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 30 Mar 2016 03:54:44 -0700 (PDT) From: Thomas Monjalon To: Chao Zhu Cc: dev@dpdk.org, David Marchand , "Richardson, Bruce" , Panu Matilainen Date: Wed, 30 Mar 2016 12:52:52 +0200 Message-ID: <1697595.mIzdCROXzL@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: References: <1458893513-22406-1-git-send-email-chaozhu@linux.vnet.ibm.com> <1458893513-22406-2-git-send-email-chaozhu@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH 1/2] Fix CPU and memory parameters on IBM POWER8 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 Mar 2016 10:54:45 -0000 2016-03-25 09:48, David Marchand: > On Fri, Mar 25, 2016 at 9:11 AM, Chao Zhu wrote: > > This patch fixes the max logic number and memory channel number settings > > on IBM POWER8 platform. > > 1. The max number of logic cores of a POWER8 processor is 96. Normally, > > there are two sockets on a server. So the max number of logic cores > > are 192. So this parch set CONFIG_RTE_MAX_LCORE to 256. > > This is a power8 configuration item, this should go to power8 config > file, not common_base. > > > 2. Currently, the max number of memory channels are hardcoded to 4. However, > > on a POWER8 machine, the max number of memory channels are 8. To fix this, > > CONFIG_RTE_MAX_NCHANNELS is added to do the configuration. > > I don't see any reason why we would need a max value for force_nchannel. > We should just get rid of this check, this is an obscure parameter for > most people, so people playing with it know what they are doing > (hopefully ?). > > On the other hand, if power8 has some specifics about it, maybe we > should introduce some default value in a arch eal header for other > dpdk components to use (like in mempool). > Thoughts ? Chao? We are running out of time for 16.04.