From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wi0-f170.google.com (mail-wi0-f170.google.com
 [209.85.212.170]) by dpdk.org (Postfix) with ESMTP id 37CB72A5E
 for <dev@dpdk.org>; Wed,  8 Jul 2015 10:28:53 +0200 (CEST)
Received: by wifm2 with SMTP id m2so81891645wif.1
 for <dev@dpdk.org>; Wed, 08 Jul 2015 01:28:53 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:organization
 :user-agent:in-reply-to:references:mime-version
 :content-transfer-encoding:content-type;
 bh=F6ZLDrLQKeyQ+FdSJlabQVfBrrc6aEHI59oyA1790+s=;
 b=QrMjHsudyIFDrVxIli0mDdSz6k0MjlT4rkWNYJK3hL3YaGWGS+fqg5vLIrl9y+GX1i
 Pj4ItiaxU/ArjwTRMfUh6ieGZE5pwYEe5TV/sbKDGVWxNkAXAQsIdTeg/EMooHx/DrzM
 AFugm8aJYvQvmnxRWhRBAdTpDSOBLl+bazcyN7Fg3uHmMe4T8McW9NtBq2om06653091
 4Hh0QQ9FuCsZF50fTDWfZUbZE8YfArt7z6U5g+X2urJepX7cGaPG8M6/gJkC3ytqnZE0
 RNfjZ8BdsFVq5D8niPwdeT5bZioLjpFAd/NXh0OaMbrefnvDCWdO8W7uxz/6O7rXUiXg
 rM5g==
X-Gm-Message-State: ALoCoQndg7aHYpcsIbiG8UmHAqB3bU0dzsqvEy1ZqQBwkIcqHFK2/ouS7NcxC+p/lWRXL7v8BKWh
X-Received: by 10.180.210.177 with SMTP id mv17mr17281625wic.90.1436344133078; 
 Wed, 08 Jul 2015 01:28:53 -0700 (PDT)
Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136])
 by smtp.gmail.com with ESMTPSA id e2sm2180716wjw.12.2015.07.08.01.28.51
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Wed, 08 Jul 2015 01:28:52 -0700 (PDT)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Tetsuya Mukawa <mukawa@igel.co.jp>
Date: Wed, 08 Jul 2015 10:27:42 +0200
Message-ID: <1698963.eCjHRZebdj@xps13>
Organization: 6WIND
User-Agent: KMail/4.14.8 (Linux/4.0.4-2-ARCH; KDE/4.14.8; x86_64; ; )
In-Reply-To: <559C8E32.3070808@igel.co.jp>
References: <1435652668-3380-12-git-send-email-mukawa@igel.co.jp>
 <CALwxeUse35k41OfLg+rX3CYcOT9guNv+mYgEBrkm=jC-=BKxnQ@mail.gmail.com>
 <559C8E32.3070808@igel.co.jp>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v8 11/12] eal: Consolidate
	pci_map/unmap_device() of linuxapp and bsdapp
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 08 Jul 2015 08:28:53 -0000

2015-07-08 11:42, Tetsuya Mukawa:
> On 2015/07/07 17:06, David Marchand wrote:
> > On Mon, Jul 6, 2015 at 8:24 AM, Tetsuya Mukawa <mukawa@igel.co.jp
> >     +       /* FreeBSD has only one pass through driver */
> >     +       dev->kdrv = RTE_KDRV_NIC_UIO;
> >     +
> >
> > Do we need a new define for this ?
> >
> > I know this is not really part of this patchset, but this kdrv should
> > just disappear.
> 
> Do you mean kdrv member will disappear in next DPDK release?

No, it is not (yet) planned to be removed.
But David thinks it shouldn't be part of the public API.
So, as David said, this comment is not really related to your patch.
It may be addressed separately.
Please Tetsuya, go ahead with the v9.
Thanks