From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 45C95A0A0E; Mon, 10 May 2021 15:13:20 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AA9DB40140; Mon, 10 May 2021 15:13:19 +0200 (CEST) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by mails.dpdk.org (Postfix) with ESMTP id 7A4104003E for ; Mon, 10 May 2021 15:13:18 +0200 (CEST) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id BA8DE5C01B0; Mon, 10 May 2021 09:13:17 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Mon, 10 May 2021 09:13:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= 52rsYQLPUnmaddm8BWqNyUjU3R1IS8d/0b/g6rKzGWM=; b=ZHIHhGF/j1JnWIy8 WtS2cpEOgmS5Dzb7EdGGpgcErSj5kL0vL9+TfCuZDbPTt1OXnB+FW1HSDdDglkVH vXgK4SYqO/kExJCepuYVpM+bzBER3iWs9muRDf/C9088197N9KnFUtTBuA7IN175 hAWixZo0lvcDJufzpKZDhVg9uA7+ozj9/PaealwUi9yVQpXfaV5yxqLaQA2AzLMA d/1IpBg/GtXYWA8eDAM4Ly+EOhUzsx+zTY6RIFRJKWUsuH5pSaBfnebV4Lbk3hCw q8GyODfcAVDSTeSL9fAV4ABIdv8yxl6QWstRsq447yK5kl25T/8ZT/V8cI6C1QkF tjS2rg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=52rsYQLPUnmaddm8BWqNyUjU3R1IS8d/0b/g6rKzG WM=; b=a8Km0JfNfXT/E88fX8iJkVAFShlX9CXCfb3NDP5Kp+uOH+Tc18YR1FHQK 6m3f6pgtV4JFGk7e1TaUysO+Hb9sz7T1BmQV7JMBhgmtnWm2mBh9mQw16uxbdyWE EklR1UIO39kkfXiAl57zu1LDcmZqVaDEOLNLMRCTSez6ZREHdvWYxarcWrlLli2/ pxIDKYRnzk1Jf1lN3AyR8+3ipRYw4gDcor7HdKp8nTcnVObROuIOx5ICCkjCVFMZ WghfFeFBTIWGyygNFkUC+OemHj7ZjtgQDxR417NiwpchY989hfB01m070E9y8x7E LaQw7ZNNdVK8gVMfMZ22E+AfWsXVw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrvdegkedgiedvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepveettdekheegheeugfeihffgkeeuleduueeigedtleffueeugeet gfevgeefheehnecuffhomhgrihhnpegrrhhmrdgtohhmnecukfhppeejjedrudefgedrvd dtfedrudekgeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhr ohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 10 May 2021 09:13:16 -0400 (EDT) From: Thomas Monjalon To: Pavan Nikhilesh Cc: jerinj@marvell.com, juraj.linkes@pantheon.tech, Jan Viktorin , Ruifeng Wang , Bruce Richardson , dev@dpdk.org, honnappa.nagarahalli@arm.com Date: Mon, 10 May 2021 15:13:12 +0200 Message-ID: <1699304.vFISr3HHSL@thomas> In-Reply-To: <20210505121423.850-1-pbhagavatula@marvell.com> References: <20210505121423.850-1-pbhagavatula@marvell.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] config/arm: add ability to express arch extensions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 05/05/2021 14:14, pbhagavatula@marvell.com: > From: Pavan Nikhilesh > > The ARM architecture allows SoCs to have extensions in addition > to base profiles such as Large System Extension (LSE), CRC etc. > > Add ability to declare SoC specific extensions. > > Signed-off-by: Pavan Nikhilesh I don't know what it is fixing. It is an optimization? Is it candidate for next release? > --- > > More details about ARM extensions > https://developer.arm.com/documentation/102378/0200 > > config/arm/meson.build | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/config/arm/meson.build b/config/arm/meson.build > index 22cd81319..8aa961e5b 100644 > --- a/config/arm/meson.build > +++ b/config/arm/meson.build > @@ -230,6 +230,7 @@ soc_cn10k = { > ['RTE_MAX_LCORE', 24], > ['RTE_MAX_NUMA_NODES', 1] > ], > + 'extensions' : ['lse', 'crc'], > 'part_number': '0xd49', > 'numa': false > } > @@ -387,6 +388,7 @@ else > endif > > soc_flags = [] > + soc_extensions = [] > if soc_config.has_key('not_supported') > error('SoC @0@ not supported.'.format(soc)) > elif soc_config != {} > @@ -394,6 +396,7 @@ else > implementer_config = implementers[implementer_id] > part_number = soc_config['part_number'] > soc_flags = soc_config.get('flags', []) > + soc_extensions = soc_config.get('extensions', []) > if not soc_config.get('numa', true) > has_libnuma = 0 > endif > @@ -431,6 +434,11 @@ else > # apply supported machine args > machine_args = [] # Clear previous machine args > foreach flag: part_number_config['machine_args'] > + if flag.startswith('-march') and soc_extensions.length() != 0 Why condition on start with -march? > + foreach ex: soc_extensions > + flag += '+' + ex > + endforeach > + endif