From: Ferruh Yigit <ferruh.yigit@amd.com>
To: Howard Wang <howard_wang@realsil.com.cn>, dev@dpdk.org
Cc: pro_nic_dpdk@realtek.com
Subject: Re: [PATCH v5 09/18] net/r8169: add support for hw initialization
Date: Sun, 3 Nov 2024 02:19:26 +0000 [thread overview]
Message-ID: <169afa0e-b480-429b-9ee8-550a753d2e7a@amd.com> (raw)
In-Reply-To: <20241028073112.107535-10-howard_wang@realsil.com.cn>
On 10/28/2024 7:31 AM, Howard Wang wrote:
> Signed-off-by: Howard Wang <howard_wang@realsil.com.cn>
>
Can you please add some description to the commit log?
<...>
> diff --git a/drivers/net/r8169/r8169_phy.h b/drivers/net/r8169/r8169_phy.h
> index 1d8889f8dc..2576538a00 100644
> --- a/drivers/net/r8169/r8169_phy.h
> +++ b/drivers/net/r8169/r8169_phy.h
> @@ -24,8 +24,8 @@
> #define MII_EXPANSION 0x06 /* Expansion register */
> #define MII_CTRL1000 0x09 /* 1000BASE-T control */
> #define MII_STAT1000 0x0a /* 1000BASE-T status */
> -#define MII_MMD_CTRL 0x0d /* MMD Access Control Register */
> -#define MII_MMD_DATA 0x0e /* MMD Access Data Register */
> +#define MII_MMD_CTRL 0x0d /* MMD Access Control Register */
> +#define MII_MMD_DATA 0x0e /* MMD Access Data Register */
>
This seems unintendent modification.
next prev parent reply other threads:[~2024-11-03 2:19 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-28 7:30 [PATCH v5 00/18] modify code as suggested by the maintainer Howard Wang
2024-10-28 7:30 ` [PATCH v5 01/18] net/r8169: add PMD driver skeleton Howard Wang
2024-11-03 2:17 ` Ferruh Yigit
2024-11-04 9:43 ` 答复: " 王颢
2024-11-05 17:30 ` Ferruh Yigit
2024-10-28 7:30 ` [PATCH v5 02/18] net/r8169: add logging structure Howard Wang
2024-10-28 7:30 ` [PATCH v5 03/18] net/r8169: add hardware registers access routines Howard Wang
2024-11-03 2:18 ` Ferruh Yigit
2024-10-28 7:30 ` [PATCH v5 04/18] net/r8169: implement core logic for Tx/Rx Howard Wang
2024-10-28 7:30 ` [PATCH v5 05/18] net/r8169: add support for hw config Howard Wang
2024-10-28 7:31 ` [PATCH v5 06/18] net/r8169: add phy registers access routines Howard Wang
2024-10-28 7:31 ` [PATCH v5 07/18] net/r8169: add support for hardware operations Howard Wang
2024-10-28 7:31 ` [PATCH v5 08/18] net/r8169: add support for phy configuration Howard Wang
2024-10-28 7:31 ` [PATCH v5 09/18] net/r8169: add support for hw initialization Howard Wang
2024-11-03 2:19 ` Ferruh Yigit [this message]
2024-10-28 7:31 ` [PATCH v5 10/18] net/r8169: add link status and interrupt management Howard Wang
2024-10-28 7:31 ` [PATCH v5 11/18] net/r8169: implement Rx path Howard Wang
2024-10-28 7:31 ` [PATCH v5 12/18] net/r8169: implement Tx path Howard Wang
2024-10-28 7:31 ` [PATCH v5 13/18] net/r8169: implement device statistics Howard Wang
2024-10-28 7:31 ` [PATCH v5 14/18] net/r8169: implement promisc and allmulti modes Howard Wang
2024-10-28 7:31 ` [PATCH v5 15/18] net/r8169: implement MTU configuration Howard Wang
2024-10-28 7:31 ` [PATCH v5 16/18] net/r8169: add support for getting fw version Howard Wang
2024-10-28 7:31 ` [PATCH v5 17/18] net/r8169: add driver_start and driver_stop Howard Wang
2024-10-28 7:31 ` [PATCH v5 18/18] doc/guides/nics: add documents for r8169 pmd Howard Wang
2024-11-03 2:20 ` Ferruh Yigit
2024-11-03 2:23 ` [PATCH v5 00/18] modify code as suggested by the maintainer Ferruh Yigit
2024-11-04 2:05 ` 答复: " 王颢
2024-11-04 8:50 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=169afa0e-b480-429b-9ee8-550a753d2e7a@amd.com \
--to=ferruh.yigit@amd.com \
--cc=dev@dpdk.org \
--cc=howard_wang@realsil.com.cn \
--cc=pro_nic_dpdk@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).