From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C6DB445C59; Sun, 3 Nov 2024 03:19:38 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B3B77402A5; Sun, 3 Nov 2024 03:19:38 +0100 (CET) Received: from NAM04-BN8-obe.outbound.protection.outlook.com (mail-bn8nam04on2067.outbound.protection.outlook.com [40.107.100.67]) by mails.dpdk.org (Postfix) with ESMTP id 0BD664026B for ; Sun, 3 Nov 2024 03:19:37 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=EKf9A7h5XXQiLOnfch22+4L2O7vne/0OyeG307dYZGO/rWq5t9/3DNlhwBVI+ZgN1JIxQYR7O9xquNpDnNatYDQcGd+ekubrhClIOOEk9RAKhArkSnOdYYHLUV88q8yhYJssmPGBPQE8pu1Mfz1jHE1Cq9TaVRQ19drR/8Y4MmPEW+n7Is/ww3sVpBW2p1IzSENCJN3NE7vmUK9ANBVk0w2FmmZI6xj3sRUaEOSPtvz3ndX3q7EyYvi5ebueAkD2DQwUY86qyN+K7+PSZABGkhxmNRtmFDJDIc5FqQon2QTAYaWcI0CboFykxz6V2DrZUOR07QFZD2ndGk7xgbBi0Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GwZvOmCU3LMY7lxjH3IfQ3Ze4DJcEpuwX6uZ0aclEtI=; b=x3lQoeMnR28qDjss6jInpJg8Ct44fH+g37hOoycgv2ZBOTurRkShBvkPWgB2ZmWezuSMUIfOsA6d1sJ5MmoMYlMtYZ/0w+hHyNkLRDtAOHCorRPe4auBLbjU5uEANgX0LUaHHkpq5xXIfqCBuLswIGPKFIlc5LL576CTnHhBbqlPR3HaUp4+Tv4jg4npT/8haayYB81bre9dA2g7c3IgNLvrFB3JMnhZd/KDwOJjWXSDKw7UQNYxLwynyVipxir54GZyibmNK2vvWEjDOR3uDbuTvAnkgH97KQFnKRxWRuHK4G32DT/POpNg3qbPYR7M1wsaToVZ6pxu3bZcmsiHwA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GwZvOmCU3LMY7lxjH3IfQ3Ze4DJcEpuwX6uZ0aclEtI=; b=TvulH2cQ2AS6l/FmK3ldnTfjaX3tlyfFW2j+VnppwHpdyPv0rBPL/qkMiWkPd/IEEAd4LAS435W9a/HhnySIo6ZXuYaosgtI4YvGJpmM7NEbyv8yGoBymdGD57iBiEEjGjVKjA6He1BaSB2L9s5KJgg3EmZAzBolPpGrmurg6lI= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from SJ2PR12MB8830.namprd12.prod.outlook.com (2603:10b6:a03:4d0::9) by SJ2PR12MB8925.namprd12.prod.outlook.com (2603:10b6:a03:542::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8114.29; Sun, 3 Nov 2024 02:19:35 +0000 Received: from SJ2PR12MB8830.namprd12.prod.outlook.com ([fe80::c3eb:df02:eaa9:2055]) by SJ2PR12MB8830.namprd12.prod.outlook.com ([fe80::c3eb:df02:eaa9:2055%4]) with mapi id 15.20.8114.015; Sun, 3 Nov 2024 02:19:34 +0000 Message-ID: <169afa0e-b480-429b-9ee8-550a753d2e7a@amd.com> Date: Sun, 3 Nov 2024 02:19:26 +0000 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 09/18] net/r8169: add support for hw initialization To: Howard Wang , dev@dpdk.org Cc: pro_nic_dpdk@realtek.com References: <20241028073112.107535-1-howard_wang@realsil.com.cn> <20241028073112.107535-10-howard_wang@realsil.com.cn> Content-Language: en-US From: Ferruh Yigit In-Reply-To: <20241028073112.107535-10-howard_wang@realsil.com.cn> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: DUZPR01CA0266.eurprd01.prod.exchangelabs.com (2603:10a6:10:4b9::29) To SJ2PR12MB8830.namprd12.prod.outlook.com (2603:10b6:a03:4d0::9) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ2PR12MB8830:EE_|SJ2PR12MB8925:EE_ X-MS-Office365-Filtering-Correlation-Id: 78285e61-64e0-4ef1-0455-08dcfbadf50c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|1800799024|366016; X-Microsoft-Antispam-Message-Info: =?utf-8?B?azZqTzQrNzBXdzdWRlkwUE44MEwrTC9BdVRlb09BUDdNUU9jYktjcnlzU3Uw?= =?utf-8?B?RUN0a1ArT2Nqa1ZwaXA2Q2ZiZEFSbmhGK2dOMmF0YmpFNGRtWThjNWRWV2FE?= =?utf-8?B?OUxVRkxYcjhpVWxvNCsybFhVZGdwK29IUVlzL21oc3hmNHZyNVZ3R05tZEQv?= =?utf-8?B?UjBUQmdrcEJMeC9CN2xjK0tVTjJ5ZWhVTFBPYkVPMEZtTURHUDNqTnNSNmlw?= =?utf-8?B?TVlaQmcrZFBUTWdGbmZPZWdVYzhXQys3WVpIL0J2bktKaFpHUzhwaGs2Wk0r?= =?utf-8?B?WU9rS1dqNVFlY3pldnl4SVVEM3J0Yk9zOGpEcGcwL3hNeWhSVDB2Wlc4aVBi?= =?utf-8?B?ZzF1RWxwR2tzdFVVZ21pQ2h0WDNDUmRuWEdYVEtMWkxtTC9mSXRnalV5bmQv?= =?utf-8?B?T0NZVDgxS200akRYdm8wOTBYZ1FyckYrd1pvbnJkcW9Xa0dtMXNlYTJqZFk0?= =?utf-8?B?dUpXaDlWNjdrTTBGOU1KS0NNVk8zN0hGdm40RFUrNEcya1JPeWc0TnVKRzBi?= =?utf-8?B?UzRHSkQ3amdXZjlseVY3MFhQMnVkSURXOEpvcGFMcTFPU3F3NDhTeTJoOHFt?= =?utf-8?B?R25acUcraUlpT0xKSHJRKzNJQWtRdysrNjFQZW01aTk4Y2kwMWVsdjkyRUNB?= =?utf-8?B?UUIyVWFVeDFBOWNwM2V2aFJFUVdaN0RUYjk0THBHV0RkMWM5V3hNdjdDclVD?= =?utf-8?B?eXRKbDhZRmdudXNtS1ljQUNzdXg3Z2pwOW9ibjFYdlEwbnlmQ0FnL3hxYXkv?= =?utf-8?B?dk84QmQxRElCYlNOQnZocU1hZ1N4Y1pVbzIraUhLQWNwWW1UaTNCNlpYRlpo?= =?utf-8?B?Z0k0VGhLTnJqaU5KN3RsbkJSVTl3TUs4TnVGVjFFMHNrZDRtNnA0MCtlMXNy?= =?utf-8?B?RStiTUxRN0R4a0F3Y25XV1BNVkpKV3MyUEZLOENUZ2F2cTNELzZzSmNFeDZ4?= =?utf-8?B?WlVWNFZCdlo3ZE1JUU8wZEZpQzNKU002d2dSSU9iVWNCV1c2NDZCaUc2SDRL?= =?utf-8?B?QVY5OEw2TXZIM25pOXdPeWhOUGtaQUZGZVJ5OG9URE4rYWhLcnBpd1hDTWFm?= =?utf-8?B?bExVZVB0R09PRWgvamJJY0xBZUFqUVM4c3R4L3AzM3U3Vm8xUHNYSUNhd2hu?= =?utf-8?B?NHRrdEU1bGU3Qk0rSTlBeUQzUGkya2dUc0hDSzJFTnAraXJ0Q05hNHZBRUZx?= =?utf-8?B?TFBDUEQwTFlzV0RQSlJQZVpTWXFzNjBmM09COG0rbThKUDEvUjJxTGlVWkor?= =?utf-8?B?M2tYbFc1QmZCNTZ0S3UxZFJRYk95dDFacjl0TFJSMzlVTHR0VHkxanhnbmxD?= =?utf-8?B?Z2xwTmxKNHFQa2twZ1h2akladGxFeHlRUDc5Kzd3TG9Rc0JFc0dHQ1dBRWJt?= =?utf-8?B?M1FPMllDV0pYSSswV1Zkb1M1azZpaUJKeEdnQ1BqMUcyUlUraXFTbEl1ZlhL?= =?utf-8?B?RnRxekFpV0NRTDdtZHlacTYzNVMvU1BrMFJxczlsSXc1dkNFR1FmaHZJeEhI?= =?utf-8?B?NnpYcEFpU0EwS1FLQWZtNjBCa3ZHbVppd2kzTjYwK3c3WkxwT21EdnFWN3VM?= =?utf-8?B?QzFnQkpuSTZsT0lveThMRE5MLzJpMmhpNlJ2dEtsbTNqd0JWVWIrTDUydEFi?= =?utf-8?B?VENmWU5LZ3grZ0ROYzNQUTMzR3gzbWc3QnRvbXhmSWEzaDZER00xRE9WMFdK?= =?utf-8?B?LzRTY1dhSlkvbzExWFRNWVhhNmR5anRqVjYrd3lpOHlIdm5yQ0tGWjRNMkE3?= =?utf-8?Q?N+MuSrni8/Eq0pvFNgiVeBlxsC+75x7uwhJB3B/?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ2PR12MB8830.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(1800799024)(366016); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VTlGVUI2b1pIc0xsaXoxTmRTdllHNjV1R0paeG0xaFNXRXZXQzhQY1IrRkdI?= =?utf-8?B?aDdMUldKSCtycDl6Q1ZmTTNkT0RGb2RRTjRBLytXbERDVENvdXRVRWdKQzE5?= =?utf-8?B?NDhXT2M4a1pNYXFnMm96RHUweEF5SXF2a2JFR3pzNTV0WFgrNk5nRnVrRjEw?= =?utf-8?B?MDVlbVdHUGdFK3o0MFVkR1VQaS9jM21CN2pxTFFKcjZyMll3eGtZaTdDdDdz?= =?utf-8?B?U3dyZjNWM2VzTXZJUVpmeXFPZzZXeTRDc1ZlSVgwZzZ1Y2RzVVVuUXpUOEJO?= =?utf-8?B?TC9iR3IwUGN4ZTNWVGFYQVlaWDJhanM2dnRyeWNucEhhNTh1K1JIVno5RFZk?= =?utf-8?B?ZisvNFIwYmdiOHBQbUtvSFIrMjhRT1puaVdYb2s4aGRZL2Vpam5oZGxCd25y?= =?utf-8?B?ak9nVkQxeUxlVzU3dEliYTU4SjQ0Z0JLTjVIVkFMSWpOaHhPL05lTzVDRlhM?= =?utf-8?B?dDlKYnRjbzFoMVpKcURXQW5PZkxURzR6NUxPQjdaVExVK3hLU0JnKzRTcDFH?= =?utf-8?B?bVVKZ3djTkdyRkJJalJXSWptem1mRWp4UGhLSW5HZDZQMUtidWlKZGpudXNi?= =?utf-8?B?MGRuME5LUDFjYmpzSEhFU1VJR1hSbHo1Uy9BNnF0RmI5TWpJY20xN0k3bnhT?= =?utf-8?B?RGhkN1VVUld2Nk5uUDFLMlpqUndxVUFLaDR1MzZmMkMwVnA4am9HTGdwL0hY?= =?utf-8?B?VTVOZmMwZEV2aDBVMFE1b2JKb0tFQnJSWjduWkNGUjlMMW1QeFkyTVl3UEVR?= =?utf-8?B?WWh3NEJOaTBBa0JMb0thSGtTZWlwV1FqTDhxYjNCMDN0dmRwcUNyWkhaVkJK?= =?utf-8?B?R00yd0lIalZOV0FmbU4wZCtSdWIxbnJDMnlETHFJRDVvdmpmeEdSekhRZzll?= =?utf-8?B?MHVRZEJyLzdqblFTT1VZdG1ZaVNuRm83NmlYVnh5RXMzSmhSSy9GdDR6WHk5?= =?utf-8?B?bC9CRUxxcmM2d05zZlp6RldpeWFCTXJ5RkVRdHZXeHNQNGpOdjRmbGk2dWxZ?= =?utf-8?B?eUd1dVJnU1RYWnVHOStIelNSZkpsNERBOS9ScG5FVkxKWDNNeUZ5WlBxNmZ3?= =?utf-8?B?aU9DSVU4R3I1TEtpNmZHbjB0T0xGeklKYk1jVGlJaU5Ia25xZS8wa3AySHFu?= =?utf-8?B?OTNnTEYxRkl0QlRaYk5SZUhuVCtTV1EwMVZMcXJuMm9wVjZpNXFGc0dQQllI?= =?utf-8?B?TnEvZjJPc2V0T1FTOFlpSHlTWUFHZWZFVWgvUXBWbHVDaUpKekY1eTNCYTFi?= =?utf-8?B?ckpnbjZoNERPZmtlYXlLNWlpMUZQc1JFMVFvQXRaQmxVVGJqck9zVjFzbnoy?= =?utf-8?B?cmZzMW93ZjRpeFNyZGl0bDhXMU9tWDI5UDBjOCsvTjZ5WU9yY2haa0tMdzRR?= =?utf-8?B?NjJaQkZZWGF5ZFpjenBwRUJYL3ZicVBBUUpBN0Q1L091WGM5bEpaUUIwZzlN?= =?utf-8?B?VnpkZjVWRHY0UDFYbEt2MlVVQURob0g5blFqRWNTWDc4NHZmVXdvb20wRXNI?= =?utf-8?B?MFFKcldkY0NYeUZhUjBKSm0xSldWeW9RSzRZbzdicVRkRVMrM1l2YjFJcXFT?= =?utf-8?B?ZDJrQlM5SDZydUNnaUUybHZkdGk4Z1BEMlcwZUtYQWZCMDMrWXc3Qi8rTDJ0?= =?utf-8?B?ZitQUDkyNHluSWptaTFXYUhFdHZGQnplZjh6NTdqckFwZzh0VVh5a2R4cE5L?= =?utf-8?B?MUtQUDc3Y25hNm9wWkhYWHFVajdIQy9vU0ptcGt0WFB6WHYwcTF4TnJ1Nmhj?= =?utf-8?B?clorQ3pneW1mdGtNTC9La2J4NUZnOTlTQWlDQzRlZ3hlMFlLWjd2RUQ1bWtt?= =?utf-8?B?ZDgyZTA5ZU5wcHo5QjVBL3lBdXVHdHptMFRRL0l0MC9PN0NLNTVVSzRlRXkr?= =?utf-8?B?a2JqRiswc0hWQ1N2b2tucEg1WEpDRGJpbHhKMzl3MUcweWwzeUcyNlNHYmhm?= =?utf-8?B?U005U3JuU3JlZ0JWalBzMjJjM3FyZ0F4N3RiVzJ4WjJGTFNzQVBXV2krSnFu?= =?utf-8?B?djRJUG9BeEhzd3V2NnhvN0FudnRmdU5Oc2tQUmEwUlRQNXlLUlVlQmVlU1pP?= =?utf-8?B?WFlkdkpRaVFUdHlOa1E3enhsb1lhcWhsNS9weGR3bHBrQlhxTVBaNUlEU0hD?= =?utf-8?Q?z1GPqUX4A3Q/M3z+F6XuLvBVf?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 78285e61-64e0-4ef1-0455-08dcfbadf50c X-MS-Exchange-CrossTenant-AuthSource: SJ2PR12MB8830.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Nov 2024 02:19:33.9775 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: buyBONCvLF9L9VHfK0MeM49DqDMduMypFbzruKTdHuqejWseLVbLGoBxEgV7ldhh X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR12MB8925 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 10/28/2024 7:31 AM, Howard Wang wrote: > Signed-off-by: Howard Wang > Can you please add some description to the commit log? <...> > diff --git a/drivers/net/r8169/r8169_phy.h b/drivers/net/r8169/r8169_phy.h > index 1d8889f8dc..2576538a00 100644 > --- a/drivers/net/r8169/r8169_phy.h > +++ b/drivers/net/r8169/r8169_phy.h > @@ -24,8 +24,8 @@ > #define MII_EXPANSION 0x06 /* Expansion register */ > #define MII_CTRL1000 0x09 /* 1000BASE-T control */ > #define MII_STAT1000 0x0a /* 1000BASE-T status */ > -#define MII_MMD_CTRL 0x0d /* MMD Access Control Register */ > -#define MII_MMD_DATA 0x0e /* MMD Access Data Register */ > +#define MII_MMD_CTRL 0x0d /* MMD Access Control Register */ > +#define MII_MMD_DATA 0x0e /* MMD Access Data Register */ > This seems unintendent modification.