From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 99AAB41BAE; Thu, 2 Feb 2023 13:19:58 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 72262406A2; Thu, 2 Feb 2023 13:19:58 +0100 (CET) Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by mails.dpdk.org (Postfix) with ESMTP id 7678740689 for ; Thu, 2 Feb 2023 13:19:57 +0100 (CET) Received: from kwepemm600004.china.huawei.com (unknown [172.30.72.55]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4P6yTx1lVbzRrmP; Thu, 2 Feb 2023 20:17:41 +0800 (CST) Received: from [10.67.103.231] (10.67.103.231) by kwepemm600004.china.huawei.com (7.193.23.242) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Thu, 2 Feb 2023 20:19:55 +0800 Message-ID: <16af3cdd-377b-a0ea-4b7d-510c38b5aea9@huawei.com> Date: Thu, 2 Feb 2023 20:19:55 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0 Subject: Re: [PATCH V7] ethdev: fix one address occupies two entries in MAC addrs To: Thomas Monjalon CC: , , , , , References: <20221020093102.20679-1-lihuisong@huawei.com> <3915735.ZaRXLXkqSa@thomas> <86a52aa2-4d1a-9243-4ca9-5ca49ed69652@huawei.com> <13477169.uLZWGnKmhe@thomas> From: "lihuisong (C)" In-Reply-To: <13477169.uLZWGnKmhe@thomas> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.67.103.231] X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To kwepemm600004.china.huawei.com (7.193.23.242) X-CFilter-Loop: Reflected X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 在 2023/2/2 19:50, Thomas Monjalon 写道: > 02/02/2023 02:11, lihuisong (C): >> 在 2023/2/2 0:37, Thomas Monjalon 写道: >>> 01/02/2023 14:15, Huisong Li: >>>> This section is a comment. Do not overwrite or remove it. >>>> Also, make sure to start the actual text at the margin. >>>> ======================================================= >>> Please check the comment: "make sure to start the actual text at the margin." >> It means to start the actual text at the beginning of the line, right? > It means no extra space at the beginning of the line. > >>>> - /** Device Ethernet link address. @see rte_eth_dev_release_port() */ >>>> + /** >>>> + * Device Ethernet link addresses. >>>> + * All entries are unique. The first entry (index zero) is the >>>> + * default address. >>>> + */ >>> You remember I asked to split lines after the dot? >> Sorry for my misunderstanding. Need to occupy one line for each sentence >> here? > A sentence may be longer than one line, > but it is better split lines logically (after dots, commas, etc). > >> Do we generally use this style to make comments? or are we just trying >> to highlight it here? > That's a recommendation when writing text (comments and rst doc). > Having lines split logically may help reading, > and will make simpler patches when updating in future, > because in general we change a single sentence. All right, got it. The next version will be out soon. > > > .