From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ferruh.yigit@intel.com>
Received: from mga14.intel.com (mga14.intel.com [192.55.52.115])
 by dpdk.org (Postfix) with ESMTP id 9F9401B2F0
 for <dev@dpdk.org>; Thu, 18 Jan 2018 15:49:03 +0100 (CET)
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from fmsmga003.fm.intel.com ([10.253.24.29])
 by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
 18 Jan 2018 06:49:02 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.46,378,1511856000"; d="scan'208";a="20780246"
Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.48])
 ([10.237.220.48])
 by FMSMGA003.fm.intel.com with ESMTP; 18 Jan 2018 06:49:00 -0800
To: Shahaf Shuler <shahafs@mellanox.com>, Rafal Kozik <rk@semihalf.com>,
 "dev@dpdk.org" <dev@dpdk.org>
Cc: "mw@semihalf.com" <mw@semihalf.com>, "mk@semihalf.com" <mk@semihalf.com>, 
 "gtzalik@amazon.com" <gtzalik@amazon.com>,
 "evgenys@amazon.com" <evgenys@amazon.com>,
 "matua@amazon.com" <matua@amazon.com>, "igorch@amazon.com"
 <igorch@amazon.com>
References: <1516103563-9275-1-git-send-email-rk@semihalf.com>
 <1516103563-9275-2-git-send-email-rk@semihalf.com>
 <VI1PR05MB3149A725C6AE527E388A9A36C3E90@VI1PR05MB3149.eurprd05.prod.outlook.com>
 <40a3b871-094f-0873-789d-d24a5ad4dc19@intel.com>
 <VI1PR05MB31493CDB377B149443457727C3E80@VI1PR05MB3149.eurprd05.prod.outlook.com>
From: Ferruh Yigit <ferruh.yigit@intel.com>
Message-ID: <16b16b11-32b5-aeae-353e-a81611d42dd6@intel.com>
Date: Thu, 18 Jan 2018 14:49:00 +0000
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101
 Thunderbird/52.5.2
MIME-Version: 1.0
In-Reply-To: <VI1PR05MB31493CDB377B149443457727C3E80@VI1PR05MB3149.eurprd05.prod.outlook.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH 1/2] net/ena: convert to new Tx offloads API
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 18 Jan 2018 14:49:04 -0000

On 1/18/2018 6:26 AM, Shahaf Shuler wrote:
> Wednesday, January 17, 2018 8:58 PM, Ferruh Yigit :
>>> Here is it better to check also the ETH_TXQ_FLAGS_IGNORE.
>>> If application has not yet moved to the new API, then it won't set any port
>> Tx offloads. So for old applications, the
>> ena_are_tx_queue_offloads_allowed is not necessary.
>>
>> But ethdev layer will set the offloads if ETH_TXQ_FLAGS_IGNORE is missing,
>> can't PMD always only rely on tx_conf->offloads ?
> 
> This is to address PMD which moved to the new offloads API but the application still uses the old offloads API.
> 
> There are many Tx offloads which are per port (as there is a burst function per port, and not per queue). However the application will not set any offload on the device configuration rather only in the queue setup. The PMD can fail the setup function on such case, as per-port offload is requested on the queue setup without being requested first on the device configuration. 

I see, dev->data->dev_conf.txmode.offloads will be empty for old applications
which ena_are_tx_queue_offloads_allowed() compares against txq->offload. So I
agree, thanks.