From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C07DD41D93; Mon, 27 Feb 2023 22:48:54 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A3DA740A84; Mon, 27 Feb 2023 22:48:54 +0100 (CET) Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2062.outbound.protection.outlook.com [40.107.94.62]) by mails.dpdk.org (Postfix) with ESMTP id 36F4840A7D for ; Mon, 27 Feb 2023 22:48:53 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fobMGekCIRYiT5OL2PMus5dkYAgmc4raF4heKKGZx9wXkLIgeS3mjLBwH1A/ALRegoxhG154s2dpiOQSe9UMqI+tkFa1M3ccT2ziZAxuKfqWPmym+5ChtS3VFnTk3sZHQeGUBN2ehMTAKgGzeXU50Ws3cMzJfSgMNP875f53+vdTRFtKQw17BqviDiAdWfWRktBFcZY8nyTPWukxn7u2TciY43rrdfyMgGh2wPAZw4xltTC0F0EgfTxRfJ1+0t0TSdMv1Wnwwqh7At9hbPaC8XeodubfEVrQE/vO4XPPuojB1rP/qKElqm+1YdVln3XPKEfijzqJ0u1hOcJRtoQyUA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+wjM5BTL2JUPi1bUBExUtYHRytTBcBawjHWhGoC321k=; b=ZXnYLUT7rpQdrSE0IeUix8C0kBfKVVODMCjbmkwjOv1rkLYu95glvk9MloUNzQla5ioGoEnleIvi9MSn5EkOVsMuMkmTHKx0lPXCJ0Su15Yh/03Axu6d7YhEo0N4eSpx6+GN5Nl3NQpYdcFD8HOBvNRctmTRIktYuEXtw12G01kmNC1cnRGlp0VJ+1/sEsyecqi22NA5Dx/g+DmCbhSPA3MP40WxAvpsKaowhbkQdlO43TsVw8q/FVeyuvoXD9+8+y94HVdL7JqaTCuP+bmmVDsRm+aTknBGgLNkTHxBMIArBnc7r/05FSGjQ/kf5zpFs8+2NW1jKTfE3rD0xDPNpw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+wjM5BTL2JUPi1bUBExUtYHRytTBcBawjHWhGoC321k=; b=IdU9pov9M0/PNT0bIRh0sbcbsvbbSd5DsAO0C04gHFyoaxX9PExd7ToATHfOCwDY/1z2XUQoCkgqN+xkgSt9+ZoDlmHLAaP6iZ1U6c94MVTgZQgxt9Mtso3UsnOrrYr1JEK4x/MZQAHP8YNOEHh3BvDYVBgEzWJgyvXMST8ISHQ= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by CH0PR12MB5170.namprd12.prod.outlook.com (2603:10b6:610:b9::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.29; Mon, 27 Feb 2023 21:48:50 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::3614:22ed:ed5:5b48]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::3614:22ed:ed5:5b48%7]) with mapi id 15.20.6134.029; Mon, 27 Feb 2023 21:48:50 +0000 Message-ID: <16be24b4-1baf-dbb3-9e14-420d222e2c30@amd.com> Date: Mon, 27 Feb 2023 21:48:45 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Content-Language: en-US To: Mingxia Liu , dev@dpdk.org, beilei.xing@intel.com, yuying.zhang@intel.com References: <20230213021956.2953088-1-mingxia.liu@intel.com> <20230216003010.3439881-1-mingxia.liu@intel.com> <20230216003010.3439881-7-mingxia.liu@intel.com> From: Ferruh Yigit Subject: Re: [PATCH v7 06/21] net/cpfl: support queue stop In-Reply-To: <20230216003010.3439881-7-mingxia.liu@intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0050.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:152::19) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|CH0PR12MB5170:EE_ X-MS-Office365-Filtering-Correlation-Id: 638ed3a0-a968-4625-aabb-08db190c6992 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: i4DrILE3Ft2L2OQWGaKwbfH7Jz3sfNuV5r6qkIy10w4rEaOwxrhZ6pS7OD8KgHIU0rK5XCbFJwDjLmUzmIdZaICtSl+j89X9GY6l58lsSausDjz5/kciUyQ5OFngouDVGs4z7JbI6Bv899mduty8vjbDHAs+xfq/jsaq9hdonKYvU+X6KXWKaDHekMFQi/OzmhehpazFdDUtDaTzI9aVQG5LOPmRfS69ipvWR6c3IG5gr7E6D3vSIFb7vFdgCTxiH8oj+HgJBMdawa6yNPMXOB8WuQAVmoWaz8ocehNf8Jewc3kcoXMJNHgkTEtNkUROKAC5O0raAwPJN6kAZIfrrZXTQgTW5ib8Vvdpd9EOislULN+iNJgORaoTk20IAz/5c+WV+JyhRfmRS7Q0gD5lyTktZ+pBpc1DJVFuw4FN8GIePfm/7hRIYFbob8i1K9Xmo2PPU+h7ot9/0oGMFl3La+rkMvrsFSzKr9jVTNMaPehx23RbHMpk8NEXhw+/s4EfXZyJEaM8H7lWCNk3KhQ+4kyDSBUvfiwMN6JlOxzCxOAxJat2ypMfYZWHEsqLRFPYzwJLRFYlM1tRzZAspNBIq+GWroMkHcsXURD1HVsVgsfmAjqe4ZeJrV+uAfaSilXpCG+XmCDmzEHyN8ArBsMNbmAc3RUaUtxBrDQN5lHbzDZgGWvYy90elOj9K28vLu3mfT6G8S/BJwTHEnDmKW/3X8Jrbf5kh91Ua3DkgxBdRrU= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(4636009)(39860400002)(366004)(136003)(346002)(396003)(376002)(451199018)(41300700001)(66556008)(66476007)(83380400001)(8676002)(66946007)(38100700002)(2906002)(36756003)(86362001)(31696002)(5660300002)(8936002)(44832011)(2616005)(478600001)(53546011)(186003)(6486002)(316002)(6666004)(6512007)(31686004)(26005)(6506007)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?L0ROZHlKYXM4WG10dXk2YzVwZ3dIaW9iWWxjQ0RYRTJRelJCc0RqQk9Mc1pt?= =?utf-8?B?NTM4TEhyVkRRR2NYQ1N4S1BBWldhVHgzMkVjaDVJR3hLN3R5aGIzSWZXWDZi?= =?utf-8?B?M3JuVjQrb1ZDbDQraHFJYkxiUlhNQ3NHZHdiU3lvYWFJWVZvVEpZMitvVlB3?= =?utf-8?B?Z052TUcyd2lVcnNvb3F5VlRGZXB5c3QzbXVYcmVEM2ZheDJDZVpqWFdwZkM1?= =?utf-8?B?M25oT1BCWFlicXczUUpKejU4VTNnRnA0cGhmZkxXU04wZlpzd0pRYzh1MFlP?= =?utf-8?B?SGJERFBQdTdxR09NditJU1FBcWI1akxURnJuM0FKUVlwQWpwcEVIUlNnV21K?= =?utf-8?B?NnMzd3lkODF4QUlYYlFONFVaaEQwajhnVVB2NG8xbEgzWmxyVHkvejFUSWI2?= =?utf-8?B?TVpoNnI4dFUzcEpKMDd2Q0FUbjFqOFhaUEhpd3B4VXRoKzFmSmNTeHFLcHVr?= =?utf-8?B?anExY3BHSnVmbnhXdnRIcE9aQkdSalc4VjA5S0dIL3haS2xTU2M2T05XelFk?= =?utf-8?B?cGgwTVRnWWlwbC81cTJrazdvQS9WMW1MaUtqdGdHb0FxNmNESlpJZEFnMC9u?= =?utf-8?B?enVKSWR2bXVmQWV0MCs3Q25TRmZOVTZlZnNDNVYwdzZZS0JSclRNNVcyQnNL?= =?utf-8?B?YWlxelc4aW5YbE0rcENhc09ndDBGbFRnUVkxOGg3UW0xUUkvQVZ6bjAxZXNa?= =?utf-8?B?Z0dVdGZkTSt3K2JsODl3d3MyenhzTU81cnVueXdTZzlURmFPMUFLZk1UbzdN?= =?utf-8?B?TkhMelcvbnlXbXFXdEdqemcrQWsvOFVFNkNpTkNNcjhHaC9tL1JIOVovdTZP?= =?utf-8?B?bDhEV3k1cm50M2RWTnBKUDhFRDFTMlVrcmVRM3BWcmo1Z0NaWTdDVFJDei9O?= =?utf-8?B?QUluckgwc3BlYXptTDFSQWxEb3U2SW1tckJFelFWYnlQa1AvK2hDdUg4am1m?= =?utf-8?B?a1JBZ1ZDdG5GeU5lMU1tRERvUFpoUTl1c2pEeWV6WEVncnJLWmwxR3QrSGpv?= =?utf-8?B?MmNoaFAzRjhRV2JyMnFlQmNacncrOFB3dlpiR0J0QjdLQVlPV05FWkFwaEJu?= =?utf-8?B?aENYc002eWhDdmhCeGpEelhlVEpiczhSRE1GWmwxRlJyeXJNTFlLMUpmN05Z?= =?utf-8?B?dXozRlBXc1BFN3daZThqUWVhYjhWaE05bThHQmNqcmNLQW83bC80NjF3ODNu?= =?utf-8?B?aWs0allBdVI5SUlKZmgrd0FVU2JqZWpZUWx1bERmMGpZNERZbGM5OWdCS09E?= =?utf-8?B?VUhpeVpBN2FVZFRDaEwzMG9ZRmRmcHJjRmtvRjkzSnNsZGNnUG81NEQ2eUV0?= =?utf-8?B?TVRlM3hpVXRHSnBsdkN1T25reE5Vc1hqMTNlNE5mZ1AvdmFtaHpIV2dMMmtE?= =?utf-8?B?ZXlwLzBVb0pzNnk2bFVKbVorY1BQcmFybll5NjVVWXkzeXNzNFJOR25MaFFH?= =?utf-8?B?R2ZGaEJzdEpNMThOcGtoSWxGRllwdktQQkxxbFAyRHhMajA3b3luOVhuUXE3?= =?utf-8?B?OE9VeEpjbDkwNTgvajQ0OHZxL3VHTlFiclFEUmlvRDlYeFpEM2hrMjc2VnB4?= =?utf-8?B?UWZpcmlNSkh2K00wcEdYYzJUNEJFSjNMaFpCYWlIWXVFYWk1UnpLdVZjYkFh?= =?utf-8?B?bjlLNXdQaS9OUE95NUVHcVArVUp0YXJhcXk2K2RNaEtCbkNMR3FSRjdPSzZq?= =?utf-8?B?bDc5bEpHVCtsbnozQ0t5TDlsbFNBYk94aUs0eDV1NGVjcURYb1RJNFR0SWx1?= =?utf-8?B?U0dMbDNLeVlnKzc2YjBsakVVbm9FZlo3Y1oyeDdIYmwvZjkrSHZFblM5QUdH?= =?utf-8?B?N1B0eXc2Tnk1YzdBajhYU1pCYkxQYi9vMHV2ZkdjYSs1aCsxbm1oS2hsa2d4?= =?utf-8?B?R3owTyt0Tmc3b0tVT1NKTGkzWTRBSUZ1cDcvWnRlNXNCa29uUXRqNWZFWFpu?= =?utf-8?B?L21pbTNVUnN6TTdXWmRqNUlSRmFFWEZtN2xJSFJyQlR6OGJzUjNSbXd5K0VO?= =?utf-8?B?dVk1TXFzNXNMV2o3dlBGbGpLV3gxT1pPZE5xRndLZ2gwSllQdDY4OHByOVFz?= =?utf-8?B?bGE4UXZVMUgzeDNLQnJjTEZmRGI2a3FBNGNaNWtWWkZ6QUlBcFN2MnE4cGd1?= =?utf-8?Q?9CHn+TjY4WtHcin9vsI4FAxOu?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 638ed3a0-a968-4625-aabb-08db190c6992 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Feb 2023 21:48:50.6765 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: g4ltXSXDkk7ptYUJ1anxIgqY+ooc9xatti4gou9UV3hOLFiJ0NXJn8aKwAtKVyye X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR12MB5170 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2/16/2023 12:29 AM, Mingxia Liu wrote: > Add support for these device ops: > - rx_queue_stop > - tx_queue_stop > > Signed-off-by: Mingxia Liu <...> > +int > +cpfl_rx_queue_stop(struct rte_eth_dev *dev, uint16_t rx_queue_id) > +{ > + struct idpf_vport *vport = dev->data->dev_private; > + struct idpf_rx_queue *rxq; > + int err; > + > + if (rx_queue_id >= dev->data->nb_rx_queues) > + return -EINVAL; > + > + err = idpf_vc_queue_switch(vport, rx_queue_id, true, false); > + if (err != 0) { > + PMD_DRV_LOG(ERR, "Failed to switch RX queue %u off", > + rx_queue_id); > + return err; > + } > + > + rxq = dev->data->rx_queues[rx_queue_id]; > + if (vport->rxq_model == VIRTCHNL2_QUEUE_MODEL_SINGLE) { > + rxq->ops->release_mbufs(rxq); > + idpf_qc_single_rx_queue_reset(rxq); > + } else { > + rxq->bufq1->ops->release_mbufs(rxq->bufq1); > + rxq->bufq2->ops->release_mbufs(rxq->bufq2); In this patch, queue ops (bufq1->ops) not set yet, it is set in next patch, switching order with next one may help.