From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 33E29A0032; Fri, 22 Apr 2022 09:20:37 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C2E864067B; Fri, 22 Apr 2022 09:20:36 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 46AA940042 for ; Fri, 22 Apr 2022 09:20:35 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1650612034; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1YAQLkVuGK9+6jOKureM0HflBzNofG6AThEoANTrz0I=; b=PtjRwoMllC5Fb3fjV9aHfc/SAKcILESm12uLTsx/cT/h8pSQM1HaPHzqGbyKisK6BK3Yio fYBKRRwEzJJwVNBJA8ZU8GiifyF5EvYV4jvY1eNLreFtdtwsdE3P3xYMxUOEWMwUxt1BOZ SC8QO4RAgr6+GVACEbIx0N8YUmnhHEE= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-446-o1QFQyWeNvSL7cjHuQ9m3Q-1; Fri, 22 Apr 2022 03:20:28 -0400 X-MC-Unique: o1QFQyWeNvSL7cjHuQ9m3Q-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 63E16833942; Fri, 22 Apr 2022 07:20:28 +0000 (UTC) Received: from [10.39.208.35] (unknown [10.39.208.35]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 1ECCF404D2CA; Fri, 22 Apr 2022 07:20:26 +0000 (UTC) Message-ID: <16ce7a9f-7635-fae0-812f-edfac8809d0d@redhat.com> Date: Fri, 22 Apr 2022 09:20:25 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [RFC PATCH v3 4/8] vhost: annotate async accesses To: David Marchand , dev@dpdk.org Cc: stephen@networkplumber.org, chenbo.xia@intel.com, jiayu.hu@intel.com, yuanx.wang@intel.com, xuan.ding@intel.com References: <20220328121758.26632-1-david.marchand@redhat.com> <20220411110013.18624-1-david.marchand@redhat.com> <20220411110013.18624-5-david.marchand@redhat.com> From: Maxime Coquelin In-Reply-To: <20220411110013.18624-5-david.marchand@redhat.com> X-Scanned-By: MIMEDefang 2.84 on 10.11.54.2 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=maxime.coquelin@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 4/11/22 13:00, David Marchand wrote: > vq->async is initialised and must be accessed under vq->access_lock. > > Top level "_thread_unsafe" functions could be checked at runtime (clang > provides a lock aware assert()-like check), but they are simply skipped > because those functions are not called in-tree, and as a result, > their annotations would not be tested. > > Signed-off-by: David Marchand > --- > lib/vhost/vhost.c | 14 +++++++++----- > lib/vhost/vhost.h | 2 +- > lib/vhost/vhost_user.c | 2 ++ > lib/vhost/virtio_net.c | 15 +++++++++++++++ > 4 files changed, 27 insertions(+), 6 deletions(-) > Reviewed-by: Maxime Coquelin Thanks, Maxime