From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7E07CA0C54; Fri, 3 Sep 2021 18:09:34 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 67F2A410D7; Fri, 3 Sep 2021 18:09:34 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mails.dpdk.org (Postfix) with ESMTP id 8757840E78 for ; Fri, 3 Sep 2021 18:09:31 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10096"; a="241741826" X-IronPort-AV: E=Sophos;i="5.85,265,1624345200"; d="scan'208";a="241741826" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Sep 2021 09:08:24 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,265,1624345200"; d="scan'208";a="467993450" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orsmga007.jf.intel.com with ESMTP; 03 Sep 2021 09:08:23 -0700 Received: from fmsmsx607.amr.corp.intel.com (10.18.126.87) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Fri, 3 Sep 2021 09:08:23 -0700 Received: from fmsmsx609.amr.corp.intel.com (10.18.126.89) by fmsmsx607.amr.corp.intel.com (10.18.126.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Fri, 3 Sep 2021 09:08:22 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx609.amr.corp.intel.com (10.18.126.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Fri, 3 Sep 2021 09:08:22 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.107) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.10; Fri, 3 Sep 2021 09:08:22 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aO4geW9DINf/vwTPHb4hWdHOcVIcMYWqRlFUrdY1MV9exUsxcAeHOqvv5MV1GTlTNzrl4TJnehAZAXAkbgOGVEy7kHcuufW+/0ouPHcRTHtgX6XAcaN1tIQ9OVC0X/lTKoEg7ZWHt3uuD9igpQGJa/q061sJyhQt5FN3K7/rGCyV8DQ+UHnSC1CJqmMKnMLq7xOmdGNm3jVdM5ZVMGAdoKMYeWc/BHeTtxrDQeAwjZXT4VtDINnS05kbLND+RBNgint82sdfHRbHcgzQiJuqoHocqfS0Mm8b73DVsWKuadto/B3SSBGRd3XZ7h6NYHLyq9mGQz5bCsLJeJoneOfXMw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=MDkxxBBzcvDRMCHSrrM6lTHkshXNbiauFHPC6f6TXjQ=; b=iwkimOPev2bv0EURuFowHWJmlX4wCX7MW1uOyAc7pTdAfiFZVVPUvVRlRt31RUczv6vm6gK49diX6WPyNs5x+kO8+xYyFDbZtqBtRXXg1IaUjZc7uCNuWm4BZ3wDdPEKWlMbkkkAR4/H8qxXpN4WvntDJ5fyktr7vvreVu2ta+W4pyNqYO72xOZQzml+ukcUioZcKbtQpjDit7GN9scGZhWUIfahCIOIPW2fuyh398KJj5pl8p5BW2kn0pKUd3aXliPZr2BjYk24UxqBkEo9cyi+IsddzEA4PXWVPsCK8ENkY+xISmtNAojkKpR12iqn7oxwd1okDlpiavwWCpMDgg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MDkxxBBzcvDRMCHSrrM6lTHkshXNbiauFHPC6f6TXjQ=; b=BrEGZHE/7QjbC61IeHq11+GC/x+ig1BQrTAsKz/wtUA5v6KSnlQvgk2AnUlILMeK9hpO9dfnskgDhsBH7AdX3gejwxNkMIKNYEb1Yomy52rB7e0x6DFpUWfGlKx37gAJ6bcV4F8l6uXL42dTFPi1/uxWKeB5AmlDlPH2+5MSrvE= Authentication-Results: marvell.com; dkim=none (message not signed) header.d=none;marvell.com; dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5207.namprd11.prod.outlook.com (2603:10b6:510:32::15) by PH0PR11MB4984.namprd11.prod.outlook.com (2603:10b6:510:34::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.22; Fri, 3 Sep 2021 16:08:19 +0000 Received: from PH0PR11MB5207.namprd11.prod.outlook.com ([fe80::c42e:f6ab:d4d6:dc8a]) by PH0PR11MB5207.namprd11.prod.outlook.com ([fe80::c42e:f6ab:d4d6:dc8a%6]) with mapi id 15.20.4478.023; Fri, 3 Sep 2021 16:08:19 +0000 To: Bruce Richardson , CC: , , References: <20210826183301.333442-1-bruce.richardson@intel.com> <20210901163216.120087-1-bruce.richardson@intel.com> <20210901163216.120087-5-bruce.richardson@intel.com> From: Conor Walsh Message-ID: <16d8e1cb-f75d-b2f7-677f-d49ab9184244@intel.com> Date: Fri, 3 Sep 2021 17:08:14 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 In-Reply-To: <20210901163216.120087-5-bruce.richardson@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-ClientProxiedBy: DB6P193CA0019.EURP193.PROD.OUTLOOK.COM (2603:10a6:6:29::29) To PH0PR11MB5207.namprd11.prod.outlook.com (2603:10b6:510:32::15) MIME-Version: 1.0 Received: from [192.168.1.20] (109.79.134.22) by DB6P193CA0019.EURP193.PROD.OUTLOOK.COM (2603:10a6:6:29::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.17 via Frontend Transport; Fri, 3 Sep 2021 16:08:18 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 0b93bc9b-4334-48c8-f6cb-08d96ef50ba2 X-MS-TrafficTypeDiagnostic: PH0PR11MB4984: X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:6790; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: jF1VBqGcg+1NKJCCKalXcgoBKM9NcZHSu2lITbW3hhBzDlMdK2a/W12OWjUji0wv/1HYYYDoYgkxFb2nwGqlMTaYcdK4cOk4rOBJCr+ZeiYUnFziAYHUlTBG3Wo3cJbrLD498BwtfCgvgVh7GmNofO2E+FXsD13hYZu9MKLIGpZjKfqrgFgAH9m+6alwJc4oO/lPfxYfkvrVGRKEg7sQVKGJfH+fd1edaFBycJtFqYmazgl4I3dXLFh8Lwh9XbxLG41QNYz4MpNh+R1Cy65L/jM5IX79dkl7IoTisycZmZCmiwS2naGzUVXUJ3CEEkRzDwJhyEVip4zssHs+fozNdJ3JSjpykry9MvYL7ZdBiV6jVDsnqvzwv3WRaY+AxHE3RH8ibs8Tc+kJizQwYKpKgAC/Vzvg8ZIhVk5Q/ai6wQi0sQPUrGG13vFZNf+d4RkbFXrobOe8jD7rILiFjRJy3xp8lrFgPbIYmYhp+f1rT9+EXE0E/J6cYY+1Q0mmJ/hoF12nLNiwfzyYV7bF4skLWoYafLkL2dbpVq9hpfvMEPp1R7oljLmSzo3Llsk9El1YMLlvJxcuIskq5VmObBSWn+MvPtZSGwAyzLkdKvu/tEtETgqERlP6EpKliq4af2OLMcCqNn2Of74vZr/EAUz5otbr+LVB0Lv0ZmrLq8croIsS6cUkfGnucfQqVWlSX/jHClVj70a93g6++q6MwXbI19AefKH2jaGI5AmQEg7HH+Y= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5207.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(376002)(346002)(366004)(39860400002)(136003)(396003)(2906002)(2616005)(4744005)(5660300002)(956004)(31696002)(86362001)(38100700002)(44832011)(8676002)(16576012)(36756003)(316002)(4326008)(8936002)(31686004)(66556008)(66476007)(66946007)(478600001)(186003)(26005)(6486002)(6666004)(45980500001)(43740500002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?K0U2NE5FcWJrWDZ0Y3NUT1hab2VBTllscU52UjFnSnREQjg4K2EycmJteTBl?= =?utf-8?B?TTNwSGY0Y3duZW1xWjljaU9PNS8yQWtydUpDYktqejlRRGdQbm5PUUJveFVV?= =?utf-8?B?b1J0ajEwd0JDQnlsK1NpNjNsaFE1RGl0NHJ1aVdtQnl6TWdnKzN4cGpoa1l6?= =?utf-8?B?dzRoWVdscEhNNEIyR0xmMVVrUlJ3T2Jlc1k3c0NFL1dPVzFNem1wRkl0Qkxi?= =?utf-8?B?K3dXSXBqeHRaWTlFUENpOU1KUGJDRUlxb3dHYjFkM3lSRVF2UHVGMG1uMSti?= =?utf-8?B?Zk50NmNSNkVoSXpLWGRoRmRrdUQ5QTV0Uzk3QUtocmVvQmxndytiWVpRZG94?= =?utf-8?B?cFc5VzRuVmtqSGdqTm1haXZaSVdFUW9Iclpva2NPSmVWYXRrTmQxS0UyYWZy?= =?utf-8?B?bXZ2YlpreEV3TVYvd1RVWGphTGNaVFF4d0Q1NWtwZEZwQ2gyMzZXYU5NYnBK?= =?utf-8?B?cDQvYXlWL09VR0swaUxvZkRTL1JsQ2Vab3JhM0NTdUxDaFJJbmRCaGxuNUVB?= =?utf-8?B?ZEl4T0VoTTZ2c0hxeDBTYjhRQkliRzVlSnNncEFUbzR6QUxndTVFWWZCa2Jt?= =?utf-8?B?cStBTmRqRTNyVzV5bmV1M1hwcFVMdnN1ZU1Id0swY3crK3VPa0ZWTzRDYmJ1?= =?utf-8?B?ZnYzMTVLalovUE1MbDdZWkFDeXNpKy9BWGl2TUQ5Vml5blFmV2NaUHlYeVpo?= =?utf-8?B?KzlmZlJiWHlKdUEvdjhGSjBXUS9kdXZVcUJrN1lSSFlSa1Y2ZVNvQVYwQWZY?= =?utf-8?B?V1lYMEY5OFR3L3pjUjF4SFFwYlZqY2RyOUh5TGpjaHhKSGljV21yRHc5eVNt?= =?utf-8?B?SnhHbFJEVW51MHFRS0pSLzJqU3pBbFNTc1NMOC96ZG0wL1FCWW5sY0wrRHpS?= =?utf-8?B?L3pRbXl6U0tWZm82U0dFcnoyNGhHR3ljaXlVRWtsOWxKcnhvYWtTVmFtSzln?= =?utf-8?B?b0cwL2lqUXhPYUdmZnpxNk1NNU8xUnVKUFpkTnFiVVlxeFJZSEJoOWtoQksx?= =?utf-8?B?aHpHanU2ZjE0Z3AyMDYvVUVxVys1dkQzOEM3cDVNR2tVTjRIZHVhdFJmMEcy?= =?utf-8?B?eWIxUUlzZWMxa1djZWViaGUxVTVYazVkK05RdzlaOEg4WlpqRXk2cDZjTE9a?= =?utf-8?B?MVF0aTZVVDN1Z09melNpQWxFWnkyVnd5WE8zaEt2Wm1iN3JWSHFpem8ybkFU?= =?utf-8?B?WGpyR0x5QUxwNTJiUkVKdFh3VnNld3lheVZHcHhoU2p0ZnpzUFJqdVlwOW1W?= =?utf-8?B?djlVN2FmSFZabHBoSWx4eTVoaVJhUUVRdXpKQXNpTmpPNmJ0OXcxOHJjUUFC?= =?utf-8?B?Z3JrTTBhZUE0ZUFBOVBDSzFQck04VytkSFFBVmhsWDZFNHN3QmJmY0Q4bUlj?= =?utf-8?B?cFJhaHB5Qnp4OW5xbGk5aEFTUEJEYkYzWEZ3bEgvelJuYWhHSnUvWVU4THZn?= =?utf-8?B?NENSYi9veHZ0ajBNZFRyU1FNZnBvMklBVjNmNnM2OXJSdWZlV1dWdHdNbmRh?= =?utf-8?B?ajg2bzFsRm1QUFdRMGw5dDhEZitaSHl0TDFtUk9BdjNqbTlFVHE4bUhPYnU2?= =?utf-8?B?Nis3ZzUyYm9XMXdVUUlEbzhYczVOSSs2UjZxOFdXWTdhR1dmdWdOYnRuRXFG?= =?utf-8?B?cW9OYjdCRGxTK21UQjNRY08rdkhRTDJVSHZTMmxHVG8xOEE4QTNMUzBvalBR?= =?utf-8?B?N1lwYXk0T09saWMzMFc4ZlBGcExITEtndEloL0VCNnFvb3UwclBZLzhiV2dY?= =?utf-8?Q?ZrPNHX/5GWm3XxtgXbE/M+bXabl0QB+xI6lFjfK?= X-MS-Exchange-CrossTenant-Network-Message-Id: 0b93bc9b-4334-48c8-f6cb-08d96ef50ba2 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5207.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Sep 2021 16:08:19.2192 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: VXExhMT8fvgA4Z1plg+8XYxG4detqFFXSGRlvUL2rF9IrLIBW05ojGM2htOKj8VI4BCS2pZebaxzkPQBOeGAhA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4984 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v2 4/6] app/test: add more comprehensive dmadev copy tests X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > Add unit tests for various combinations of use for dmadev, copying > bursts of packets in various formats, e.g. > > 1. enqueuing two smaller bursts and completing them as one burst > 2. enqueuing one burst and gathering completions in smaller bursts > 3. using completed_status() function to gather completions rather than > just completed() > > Signed-off-by: Bruce Richardson > --- > +static inline int > +check_stats(struct rte_dmadev_stats *stats, bool check_errors) > +{ > + if (stats->completed != stats->submitted) { > + PRINT_ERR("Error, not all submitted jobs are reported as completed\n"); > + return -1; > + } Need to double check with Chengwen about the definitive meaning of the completed stat. Reviewed-by: Conor Walsh