From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR03-DB5-obe.outbound.protection.outlook.com (mail-eopbgr40067.outbound.protection.outlook.com [40.107.4.67]) by dpdk.org (Postfix) with ESMTP id 587201B668 for ; Fri, 13 Apr 2018 12:22:13 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=0wwKkcGgb2wMnV+sWGkzCAkRcAz0i0ekoWNFa52QeP4=; b=oqno0SAi2526c3unVDKWtBlEORbi2Wh3Q573FMS/ddSu5hGbn7G0xAyBaFp0mOwiEtAKcqMVU+nJOTuON2qKknVo0UfPlLlPnWN0EZXSFL2fLLT0IkfGV2uX3ryX9322hrMzqOlHsKMJDm6O3GxuPAFGSbbcd279wYxQ9dv8Z9U= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=shreyansh.jain@nxp.com; Received: from [10.232.14.39] (14.142.187.166) by VI1PR0402MB2783.eurprd04.prod.outlook.com (2603:10a6:800:ad::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.675.11; Fri, 13 Apr 2018 10:22:10 +0000 To: gowrishankar muthukrishnan Cc: dev@dpdk.org References: <5438d3242ebb9d995d0a52a63feba80efd783e6f.1523595487.git.gowrishankar.m@linux.vnet.ibm.com> <4074558.oWdUdNoPZr@xps> <893c8705-858c-336d-c600-c4a23e8fea5b@nxp.com> From: Shreyansh Jain Message-ID: <16f772e5-71f6-6116-3750-d6e7a6293249@nxp.com> Date: Fri, 13 Apr 2018 16:07:11 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Originating-IP: [14.142.187.166] X-ClientProxiedBy: OSBPR01CA0023.jpnprd01.prod.outlook.com (2603:1096:603::35) To VI1PR0402MB2783.eurprd04.prod.outlook.com (2603:10a6:800:ad::13) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(5600026)(4534165)(7168020)(4627221)(201703031133081)(201702281549075)(48565401081)(2017052603328)(7153060)(7193020); SRVR:VI1PR0402MB2783; X-Microsoft-Exchange-Diagnostics: 1; VI1PR0402MB2783; 3:vpLEmFK2taCgsOfFZmC866U+0uDvQAoMgh+7qb5ji4bXas9+sByhZReIO/Qk82BslqAQZsbrqTnmYuXXauRHtt6fr3dmd8LGHRshlniIWZZyBN3ljUjeJQydOYi7PVKyhtMnj508QfSVqT7psB8XXXo2E42QwmykDjqul4OwKriIF8+nXCaxSk6og0RUe/IgtVsAJE0qDHIyPfe7CcE5/zauX0ruyWEDDjImIxVNGTDgPqjGHUPOnz35xEXo073y; 25:okGAJ5u6NhSf+JhnDAqIN561uur8Q9S3U2Sd0BO8UfDaBnV5C5zO63AkWwNCDOyhVBw1ISa/UdyM+xvzYk7qSBN3QPzLA/P/70CJC8VurMx+ybrddLOzuCiu96hkeMX/YDFRfroNECqoQnjyKRXcYJuS12a3HaqhryLxFGBJKEpyrBvIQPqzrWmRx8VrmhMW2QWgmoCp7G0o/mkqMj3p0I+u2MmIXhhzmIOSQvmHG9zFBdlq4en8AKdoxOnj53uBDTzMa24W+wakweXN8ka0X3u8KP20CteoZ0eX+4kVo5rRDnrtcj7Jh+odgawqaJpLq5+1p5lxx8NK+Ryb2BNEUg==; 31:i13f9/njntB1K/mWOGDUQWK/VqjAVA8abgWLxb5tJ10MhrdcdSv8ObmuLs3zQ3buuO8ez+6HCLsrTYgMI7+iPNUDArBQLM/P77LnB7yqssxJG+c//lTwCSbHfebYpf8AhTNydZjn0+z5gcgeUgXZHeFtofBZkkNBOy1mfBA0rO2ztD7ItMrNjVi9G3wU409FbIq9Mop8fZ/BUiyMK+n3wrSrgpffOGOSr+LyHWEHEDU= X-MS-TrafficTypeDiagnostic: VI1PR0402MB2783: X-Microsoft-Exchange-Diagnostics: 1; VI1PR0402MB2783; 20:RgYOVC8gs/H+CqqJ88jwYd3LzUXdAQ/NmsXmgDRCdC1rxICYWSz1SvXYLV7z4g7qbWki2hKhspiB/9+CneTinsB2qwp9WMP/WlrKj+ifxXHEH3asP7iGjYJxBIWznV2+AFXdFmwv3oX4mI46dCJovEp8r+C3w3RHr6wSCoydGIGZqwRBbkX6ouNnKR3df3Zi3W1rmxxtN2MKuILsXBr2HkgbPWfiqAPSoHzmxRhbum2LRLR1rGW4zBHlKf9MZkMPWg1/Ho/m5w/iiT1nCQobslbE3mC5f+78S+uY1hfH49wdhh7P8zOyJHhv+g3k62q9xoxFSGemEXvnpyDN38lslik0gyTpwDiiNn84XesacgBF5t97RBip2/YYwJVkdNSIEMyHuW0Yvcp08SOkn/XW4sNb020cQxsXu98YdtlLMXaCHfka+lVEM629+hm0Juwal75tS9Xl4R2zyWl57Qf/Dft+mTrAEgyht+UQkGTUbASatiReTccs32Xd7nIni2CE; 4:nFOfUFcOey5OW1gORNhoGuAHKtc8N39JbIb8xu/OWLb749h4VTgC1usNJkHS5OB4nPR/BvfzPgaSHRStbiaZZE31qkHoolSoB3dd5OWIJeJMN1uy0vILYeCP1y/kxuZH7tZbM6PUFy1tH7pc9bQZ4SfR/i5D3Kt3QcgbSSA5fJ1VF6H8KJdC7t2/EdJU61HraQSS/0m83NZBgM6VJsUKLPGfKSP/pCA7Qh3fYYqOENN1axM5ks4XrNlVDQQr2TLrRBAS7ddxPDKpbrLXPCurX5XcVk2qIeZGhgu3JcUSXNXLBthhS/e/CUSWkNzYdkF9 X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(788757137089); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3231232)(944501327)(52105095)(93006095)(93001095)(3002001)(10201501046)(6055026)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123564045)(20161123562045)(20161123558120)(6072148)(201708071742011); SRVR:VI1PR0402MB2783; BCL:0; PCL:0; RULEID:; SRVR:VI1PR0402MB2783; X-Forefront-PRVS: 0641678E68 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6049001)(376002)(366004)(346002)(396003)(39380400002)(39860400002)(189003)(199004)(53474002)(43544003)(36756003)(2906002)(67846002)(8936002)(229853002)(6916009)(6246003)(386003)(44832011)(53936002)(58126008)(11346002)(93886005)(64126003)(486006)(476003)(2616005)(446003)(5009440100003)(16576012)(316002)(2870700001)(3846002)(16526019)(6116002)(26005)(50466002)(77096007)(956004)(81166006)(186003)(81156014)(8676002)(31686004)(6486002)(97736004)(65826007)(23676004)(52146003)(86362001)(52116002)(68736007)(305945005)(2486003)(76176011)(25786009)(66066001)(65956001)(55236004)(31696002)(7736002)(105586002)(478600001)(47776003)(65806001)(59450400001)(5660300001)(4326008)(106356001)(110426005); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR0402MB2783; H:[10.232.14.39]; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; Received-SPF: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtWSTFQUjA0MDJNQjI3ODM7MjM6TmRCeUw1N3JuZ0t3bHRpWmhkdDltYTRq?= =?utf-8?B?NWViQ1FGZllNcjNYb3VFQytObHM5dmNGUU1rVlJteWtRd1dnOUw5TG1TcitQ?= =?utf-8?B?eGRhM1kzYWdLZVB1eWJtcXI1UGorR2FjTFBaRlVKYlJzREtrTW45eHZIWWtZ?= =?utf-8?B?L0RtMUlpTVF2ZmZTTUI3VlJrQ0VXY0grNnNYQTdLakh1NGdYZ2poMUNiMmhU?= =?utf-8?B?NWcwVXRZYkJKRWs1eFN6MVFZY1RBMldIcGNMQ2pISWw5OFV1TWhvV0FsbU9r?= =?utf-8?B?cURubi9adFFPS0RyMXhpQXhYcW1kaC82VGlMdnFsbU9SQWRYOVlMTDYwWEJ0?= =?utf-8?B?SG1zR0NIR1VTY1ZKTWVWRHFUUkhnMmMyZlJBbmFrVDJha2x3Q2w4MnEwM2g5?= =?utf-8?B?dEcybzJpUVBDQjF4OEh1eTVCZHZyRnQySTJXMnRKM3JqRzIwK01JOU8rK1Fn?= =?utf-8?B?RXVKM0pwSS9ycFRoMDlHUG11OThmYU5KOHZVdjFTVWJnY1JoYVRVV2dJdWls?= =?utf-8?B?NE5JM3NqdFMwWHlqVDk5dmhhcGZZZmRycW1EUmlyUmF0R3BraTY5U2wvUXhS?= =?utf-8?B?VjAvcmMzZ0tDSEQ2ZUJWcUR5c0lWdFRxeXFaRCtjMlVYV05Pc1g5djIxOUUw?= =?utf-8?B?QU5tODZIQjFRTUpFN25SMjNBK0VVVWhUZC9RRDVDUDJtaWUzdWlEcHRsMDAx?= =?utf-8?B?amw1R0psYzJHWjVqSm1XR0M3cE5LUDZUMUF1b3krSFFDSjBFQjlrd2d4OHEx?= =?utf-8?B?Rk1tRWtPTkpRTHVPeEorUGRWeGl3NHlNeDhtWElaZHovVE1jcUxaUnJVMFgx?= =?utf-8?B?eTIxOU8xVDFsa2x6alNoRFY0VnVpY1JONXZ2Z29nT2VpM1RoOE84R1FOc3FQ?= =?utf-8?B?eHdmVE5yNGg3eHlkWG54MzM4TzMyWEEvRGQyRjErc0t3SG5MNEVKU1oxRUwz?= =?utf-8?B?WDM1MzYyUTlyYW5Ecll2R251MktNRjhleGZNajI2RnF6MkFHeTk4VFRmZTVU?= =?utf-8?B?azJIalEyeENKSVg3MjAyZXhaOWthbitmNGpuMi8vZ0xwOWRvQ2xTYzZCem4w?= =?utf-8?B?dzlDNlR6cllpNi81SWpEbVhtYzJ4SG45ZlhLUGZud1BrbjZKS0NYZzVvRUx3?= =?utf-8?B?ZjBVdzhvdTBPa0d6NkZ4Qk9kS09CeTdqMWhXSzdVc2I1M21pTE9lK0NBbkZs?= =?utf-8?B?U3ZtUkV4cDFhV2FqOGVLMzkrclp6ZHc3REtIaHBPRXArZDZpclUwRXZHYUta?= =?utf-8?B?aXE4UDZ4dlh4L2dzNGdyWENkT2tvZG8vUWhzN05lWkgwMG9qMWR5ZlMwOXBH?= =?utf-8?B?cUlsVWYrMlpYR28zR3ZEaDNQWmVrTlpvbFdpV1dqUW0xY2NBM1VBbkR3Vlpw?= =?utf-8?B?bC8zTHIrMWRlZzBodDQ0dUkrSUJjc0FIS2dTbmQxRzRtL3VwQ2dzM3NOK2NB?= =?utf-8?B?RWVUbnV5QzkvVS9tVldtTUg1eTBEVzhFQWl5ejVvLy9NcmhCWitzK2VLRW9E?= =?utf-8?B?RzBJb1hzSGZVbDB1UGFBNXQyT3IraXAyR0c2MGV1ME40RDhiM09UVFo2dGdD?= =?utf-8?B?YzV4dHhXM0hrWlJpcDlnRFI0VjhBZFRNV20yV0FZRWNsSTBBRGVpd0YwOVkv?= =?utf-8?B?TVlYQTA1dDZLRGJhNXpvLzZnOUdaOElTS3FocVRJVjhGUkdzNCtXU3VzdW1r?= =?utf-8?B?QnM1Q21nMi8xMFZSeFdSNHNpL0J3Q25lNjdzUGh3azd4ODQzaE5CTVhNazRr?= =?utf-8?B?SmpLMzhHYUN6clFNOXJUN3VuMjVnT2ZKeUhid2h0a1lJVVdGK053cEFsbmlB?= =?utf-8?B?UlpsRGxiaHVXUWluR2c0b0dzTkZZRWtDTkdxTmFCaEhyaE5kSndGTHZvMFp6?= =?utf-8?B?SHNuVFVjS0R1U3FBNE14cUlkZEpReFk0aGQyc1NUb2dHbEtSREVPbUZDR3oy?= =?utf-8?B?TS9QNWxRSlJYSngrZHVUVi9oTVR1VEk2WTRFb0tUQmEzQ1kwRHQ3S1FzUWlx?= =?utf-8?B?WmUyMVpwTkZ0UlU1WllQNE82QStsMHVPWXhnOHkydUtUSU5idUZWK21YWHEr?= =?utf-8?B?aUF4eDR3OUFFZWpNNmhYMjNONU5tdHFCbUt0Rm1xdkNmMlREc0lrSHkwV2lM?= =?utf-8?Q?r++4QJAeeVr1vy1ouxKRDSER5G++/fdAv2vD7XtHOJ6XhY?= X-Microsoft-Antispam-Message-Info: BCt4G99C6/5lSGGtVzyynEUpUIFbvrOC4fRM5xjtWbW08RAfrnfWNj8HzzGMKmcLHha1pV+eswbIqC3qmXms+7cbpBdLxWchZ95S59toLr452p8pZ+QLayH6Su6xxB7OktA/w9gMarMr3GT4A4E2Ed3FyWVAfiP1/+wtAl1uWJwoAdj1KohSWjGihSvJr+l9 X-Microsoft-Exchange-Diagnostics: 1; VI1PR0402MB2783; 6:yja1ZoSUWmSLbDh22a6nSlN8EdCj2XCPpkvuM4N5A6DEL4a9/71Iq6XspJ49wELk2Uy3NUCerG60h+h/sQ9d7cRXfJYucEJoVjN+3xAegfPM9I7L4l8Pr7hQXY9jy371zYG1cMZXGR8dDOP5+0agWYFWGp+2/Q4MeYNGhyZX5YAdZOY1dGL7lVB8llkUAh9pnORZ/xqwL+JDzGwcmm6m/jJJ2Aqvh/TjhMt7Q+QE/H43yGJZEOr0PuH6nwx7VO8pLbGcoyD/STAfAHdJH6Ayy5I1p64vEvlhXX54cqy7Vq2h6/kl1qj8x4AlmczVvmH/GSXauW89KS2y8VvwFkFJ+L5+rJQXDQ51fXg2VFuabK07K26hA5OklANF2UABV5N8v6PXfLZcdKTB/XZDysl8yu6I73p7iYiuKbov2/EXuOjxEH5RvGV+v+2uqLO71OYb7yp1pW8TVrbI1+cOyHwK4Q==; 5:CLlWYBdCOw9Iz2KyaTx0brY5UOYtTWvARjHvVUaF5Lrw4Ji7o6pkb2sDRaBrxyn18ymn8IXeJjFM6882+eouHFpR0fnIB6/rWMJRmN+HpViWvAbL+WFAAabWSS8ghdUZUXSb3fw0ZDH05fS51IKu1Vof8ry4qR1B1HJsf+ImXUM=; 24:51HwnPb+9OiSlNP+ZFHnF5Rd6X2Jc+0UlFK5GK9yglAtSFRW5j95OvdO8Q+eTNDIg5AP878oFhRB9qvpDKyiNEf6PhWjzDe/PKXvXcUsopc= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; VI1PR0402MB2783; 7:wRzeka1PHRnycpQCN14dgOzCcOPf794FUHoBNGSJAJcHrdNMUxEq5giGhXfcnnwFpXjtEYslChZLPUkZoQ4VCBbeMG/bm6+a95Jhqla0GIZjLQ9/V1Vdg9gjpVPoQ6vjBoCk86QEcufirAdRRZn3qBHmdyHd/+kYtiF4hYEMVy04ZllLGGMpaN1S5G4z/hnYivuv2n4Jdn3ELUt5tx2py0aWjd5GWN74YxOiASTDGwVe1dlrCyFeJLgyTh52vn1a X-MS-Office365-Filtering-Correlation-Id: 099463c2-6ca1-4f91-6701-08d5a1286bb2 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Apr 2018 10:22:10.4473 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 099463c2-6ca1-4f91-6701-08d5a1286bb2 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB2783 Subject: Re: [dpdk-dev] [PATCH] bus/fslmc: use PRIu64 instead of llX in format specifier X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Apr 2018 10:22:13 -0000 On Friday 13 April 2018 02:13 PM, gowrishankar muthukrishnan wrote: > On Friday 13 April 2018 02:26 PM, Shreyansh Jain wrote: >> On Friday 13 April 2018 01:11 PM, Thomas Monjalon wrote: >>> 13/04/2018 07:04, Gowrishankar: >>>> -    DPAA2_BUS_DEBUG("--> Map address: %llX, size: 0x%llX", >>>> +    DPAA2_BUS_DEBUG("--> Map address: %"PRIu64", size: 0x%"PRIu64"", >>> >>> You cannot replace hexadecimal by decimal. >>> You need to use PRIx64. >>> >>> >> >> Now that Thomas has pointed out, I think the log message can be >> improved. Len as hex is not helpful and is out of sync with other >> messages in this file. >> >> While on this, I think it should be corrected. >> I will fix this. >> >> @gowrishankar, I will post a patch in reply to your patch - can you >> please help me with ppc64le check? I will take care of Hemant's comment. > > Yup, I check for it. Thanks Shreyansh. > Can you please check this: --->8--- @@ -270,8 +270,8 @@ fslmc_map_dma(uint64_t vaddr, rte_iova_t iovaddr __rte_unused, size_t len) return -1; } - DPAA2_BUS_DEBUG("--> Map address: %llX, size: 0x%llX", - dma_map.vaddr, dma_map.size); + DPAA2_BUS_DEBUG("--> Map address: 0x%"PRIx64", size: %"PRIu64"", + (uint64_t)dma_map.vaddr, (uint64_t)dma_map.size); ret = ioctl(group->container->fd, VFIO_IOMMU_MAP_DMA, &dma_map); if (ret) { DPAA2_BUS_ERR("VFIO_IOMMU_MAP_DMA API(errno = %d)", @@ -303,8 +303,8 @@ fslmc_unmap_dma(uint64_t vaddr, uint64_t iovaddr __rte_unused, size_t len) return -1; } - DPAA2_BUS_DEBUG("--> Unmap address: %llX, size: 0x%llX", - dma_unmap.iova, dma_unmap.size); + DPAA2_BUS_DEBUG("--> Unmap address: 0x%"PRIx64", size: %"PRIu64"", + (uint64_t)dma_unmap.iova, (uint64_t)dma_unmap.size); ret = ioctl(group->container->fd, VFIO_IOMMU_UNMAP_DMA, &dma_unmap); if (ret) { DPAA2_BUS_ERR("VFIO_IOMMU_UNMAP_DMA API(errno = %d)", @@ -401,8 +401,8 @@ static int64_t vfio_map_mcp_obj(struct fslmc_vfio_group *group, char *mcp_obj) goto MC_FAILURE; } - DPAA2_BUS_DEBUG("Region offset = %llx , region size = %llx", - reg_info.offset, reg_info.size); + DPAA2_BUS_DEBUG("Region offset = 0x%"PRIx64", region size = %"PRIu64"", + (uint64_t)reg_info.offset, (uint64_t)reg_info.size); v_addr = (size_t)mmap(NULL, reg_info.size, PROT_WRITE | PROT_READ, MAP_SHARED, --->8--- gcc for i686/x86_64/ARM64 are compiling fine for me. If this works fine, feel free to use it in your patch. - Shreyansh