From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <thomas@monjalon.net> Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 8FB741B58E; Sun, 5 Aug 2018 22:14:32 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id EBB6B20CA5; Sun, 5 Aug 2018 16:14:31 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Sun, 05 Aug 2018 16:14:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=zCRinuzJKwGVDNs1RyjWxd/cuB wwLqDZD8K3JMA0bKc=; b=F5gdfgNvyhSerdOKcgN0SG6tnme3cro9cfpTGf3NvK OPihyLsZjIdY3adOEurT5sa/Mlnkvpo0m+wfHrI5619xnmGeGGISYfh0kfXq8AZv zCFh0deTBW3N5T2I5SAuRkcuKKorL4JQeUucpwVL1wCrtQMsHhRMmb2VfsJUsyb4 M= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=zCRinu zJKwGVDNs1RyjWxd/cuBwwLqDZD8K3JMA0bKc=; b=mlf5ASpBe4SDgYsH62Mzat cRZie5m70rub9ZqZOyL0bdxG1a59aWN44MhLl58JLayTyNNWxDA/0xTavWWknkwB MBvnJajKkbZE+z89C9ncNOXtFZRjbSn2obskdcPlC0hKlXPRrnt46lcaLyUTmnlI FQUk6O8XKV+GvRDliyS5ZtCst8cAJGf1ZroBJfjZ06L01HdtXbYr7ArMf99FYOvs +he78vvnkg1yLsTW8/Qk0oFj4tU/o69yuGRab+OELbUdHgvh7HwRmFijKn+BfAjO bZNa9bv+IAdrJpelvvkze2teCzP/oWkJ7e4eehgrB42Y7J1xrmGO8p86FAYrsfVg == X-ME-Proxy: <xmx:p1pnW8q47XTXPYrbansoMM025lKIWby5-1bxx25IDwN_OeYydHBW4g> <xmx:p1pnWy0gvhd9eUJtugZSbQcSAbrmnam3oXtzGQow17SUha7j9_3xlQ> <xmx:p1pnWzBqMsTycRWWTQD6sYTLlzhExkWJTKQvSrjYFMdLc5L6xyCNEw> <xmx:p1pnWyfU5ELs8jeF7UpxDzWX0kNhRB_dGltBrz41mBo44W9EbWf4Hw> <xmx:p1pnWwhKlRXdnCb_jpK8XsMjm05Zrx94VN9OExz8QTsRUTKgiBX07w> <xmx:p1pnWyHOAmBvJaDEPCO7Sy9yYVA3BNV6hLdzBJscIEyVwry6PIZSxQ> X-ME-Sender: <xms:p1pnW5XOPmN0IhNbGqhEeC479g5JS85bf905aoHg7Wn3FGVwYjd9TA> Received: from xps.localnet (197.15.136.77.rev.sfr.net [77.136.15.197]) by mail.messagingengine.com (Postfix) with ESMTPA id 0C2F3E465F; Sun, 5 Aug 2018 16:14:25 -0400 (EDT) From: Thomas Monjalon <thomas@monjalon.net> To: Rosen Xu <rosen.xu@intel.com> Cc: dev@dpdk.org, ferruh.yigit@intel.com, orika@mellanox.com, walter.e.gilmore@intel.com, qi.z.zhang@intel.com, stable@dpdk.org Date: Sun, 05 Aug 2018 22:13:29 +0200 Message-ID: <1700882.CoqFyXHoSW@xps> In-Reply-To: <1533041560-164321-1-git-send-email-rosen.xu@intel.com> References: <1531361387-116027-1-git-send-email-rosen.xu@intel.com> <1533041560-164321-1-git-send-email-rosen.xu@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v4] examples/flow_filtering: add rte_fdir_conf initialization X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Sun, 05 Aug 2018 20:14:32 -0000 31/07/2018 14:52, Rosen Xu: > Rte_fdir_conf of rte_eth_conf should be initialized before > port initialization. It is a workaround solution when working > with Intel I40e. > > Fixes: 4a3ef59a10c8 ("examples/flow_filtering: add simple demo of flow API") > Cc: stable@dpdk.org > > Signed-off-by: Rosen Xu <rosen.xu@intel.com> > Acked-by: Ori Kam <orika@mellanox.com> > Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com> > > v4 updates: > =========== > - Fix typo and lack of punctuation. > - Add why it is needed, and what are we waiting to remove the workaround. Applied, thanks