From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <thomas@monjalon.net> Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 5A01C152A for <dev@dpdk.org>; Tue, 6 Jun 2017 11:11:24 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id EC97320C75; Tue, 6 Jun 2017 05:11:23 -0400 (EDT) Received: from frontend1 ([10.202.2.160]) by compute1.internal (MEProxy); Tue, 06 Jun 2017 05:11:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc:x-sasl-enc; s=mesmtp; bh=tWFsq5rtQm9lkd1 if7ehaVvyGq/j4atmKDQa6j8RU3U=; b=b3WO0WK7YmcnZc0VzMa8IKsyJZ6NZYn MILQQT6L7dYJglkQW0+N6zcDJzOy9lPLfGuGHE2nxpcp0NsULzn2QMMvkDEoL7dU JSu8QlCjiX1zbJSmP/o0YffBNrjbfGPjStSZ+DN47qUZC5eg0shCVaruclvvij0l WcC86mlNiZK4= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s= fm1; bh=tWFsq5rtQm9lkd1if7ehaVvyGq/j4atmKDQa6j8RU3U=; b=T8x5XGoL NLgk7P8aOlGijY1nNgLgPyChUkkLRb/bLL29W3k0YJQ6c30t3P4OzyMfDsyevxd/ anSNSP2WmmhB/jus8+TSGOBhlpq1ttsGRuwFb3tmS+DBe6BifQ4xeF34vJpchOPD mO71fpI0NdJ8A0EkHGkn9SJ5z+Wndtt9XlLD8mG0s4wR3FZgQ1wXiLwoAuRHSAnQ J/tjNKeod3FQxpFt69T0owZroqCy6jsA+8tL+h5sBtXFdEuCuGWsA8WX88v+bDbn pG5VjgKRHRPW1wKqeI6eBGFlGukaUOEhNTnUrhtEXctXJawBzAX2rfcnOZ7hu7Jk ZVPcK1WCX+KN1Q== X-ME-Sender: <xms:u3E2WWu4tz4T2M1v20PrWT_cWT4nP2LgPzOBeZV-k3uLHcBX4qKDmw> X-Sasl-enc: yViNFygbi2+ixuF4h76eRjgdnPlUeQIlQRsvLD6GnLwS 1496740283 Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id A0F8A7E712; Tue, 6 Jun 2017 05:11:23 -0400 (EDT) From: Thomas Monjalon <thomas@monjalon.net> To: Jerin Jacob <jerin.jacob@caviumnetworks.com> Cc: dev@dpdk.org Date: Tue, 06 Jun 2017 11:11:22 +0200 Message-ID: <1701124.bcg6lUXj3m@xps> In-Reply-To: <20170606090527.GB25773@jerin> References: <20170606063650.31434-1-jerin.jacob@caviumnetworks.com> <20170606075042.GA10303@jerin> <20170606090527.GB25773@jerin> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] mk: allow exec-env specific targets X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Tue, 06 Jun 2017 09:11:24 -0000 06/06/2017 11:05, Jerin Jacob: > From: Jerin Jacob <jerin.jacob@caviumnetworks.com> > > From: Thomas Monjalon <thomas@monjalon.net> > > > 06/06/2017 09:02, Jerin Jacob: > > > > From: Thomas Monjalon <thomas@monjalon.net> > > > > > Please explain how it can help with a real example. > > > > > > > > We are evaluating on running DPDK on a nonstandard execution environment like > > > > bare metal where I would to keep all my execution environment specific > > > > change at following location. So that I can easy move around different > > > > version of DPDK without merge conflict. > > > > > > > > $(RTE_SDK)mk/exec-env/my-exec-env > > > > $(RTE_SDK)lib/librte_eal/my-exec-env > > > > > > > > I believe, The existing target like "exec-env-appinstall" in mk/exec-env/linuxapp/rte.app.mk, > > > > solves the same purpose. > > > > > > I do not understand. > > > If you want to add a new environment, why not just adding it? > > > > I do not understand it either. In exiting makefile infrastructure, > > How do you add an exec environment specific target(s) with out changing > > the common code? > > As disucssed in IRC, I will send the v2 with following changes, > - Change mk/exec-env/$(RTE_EXEC_ENV)/rte.extra.mk to > mk/exec-env/$(RTE_EXEC_ENV)/rte.custom.mk > - Remove empty files and include through -include It will help defining some new local environments. However, in the general case, it is better to upstream environment changes and make everybody able to use it.