From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id ACBCFA318B for ; Fri, 18 Oct 2019 11:42:51 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id ED5AB1C1B9; Fri, 18 Oct 2019 11:42:50 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 2291A1C13A for ; Fri, 18 Oct 2019 11:42:47 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Oct 2019 02:42:46 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.67,311,1566889200"; d="scan'208";a="200662267" Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.237.221.10]) ([10.237.221.10]) by orsmga006.jf.intel.com with ESMTP; 18 Oct 2019 02:42:44 -0700 To: Andrew Rybchenko , pbhagavatula@marvell.com, jerinj@marvell.com Cc: dev@dpdk.org, Adrien Mazarguil , Thomas Monjalon , Xiaolong Ye , Bruce Richardson References: <20191010105130.3382-1-pbhagavatula@marvell.com> <20191017120245.984-1-pbhagavatula@marvell.com> <868c4186-a899-3974-ce1a-9d0d395b2f81@intel.com> From: Ferruh Yigit Openpgp: preference=signencrypt Autocrypt: addr=ferruh.yigit@intel.com; prefer-encrypt=mutual; keydata= mQINBFXZCFABEADCujshBOAaqPZpwShdkzkyGpJ15lmxiSr3jVMqOtQS/sB3FYLT0/d3+bvy qbL9YnlbPyRvZfnP3pXiKwkRoR1RJwEo2BOf6hxdzTmLRtGtwWzI9MwrUPj6n/ldiD58VAGQ +iR1I/z9UBUN/ZMksElA2D7Jgg7vZ78iKwNnd+vLBD6I61kVrZ45Vjo3r+pPOByUBXOUlxp9 GWEKKIrJ4eogqkVNSixN16VYK7xR+5OUkBYUO+sE6etSxCr7BahMPKxH+XPlZZjKrxciaWQb +dElz3Ab4Opl+ZT/bK2huX+W+NJBEBVzjTkhjSTjcyRdxvS1gwWRuXqAml/sh+KQjPV1PPHF YK5LcqLkle+OKTCa82OvUb7cr+ALxATIZXQkgmn+zFT8UzSS3aiBBohg3BtbTIWy51jNlYdy ezUZ4UxKSsFuUTPt+JjHQBvF7WKbmNGS3fCid5Iag4tWOfZoqiCNzxApkVugltxoc6rG2TyX CmI2rP0mQ0GOsGXA3+3c1MCdQFzdIn/5tLBZyKy4F54UFo35eOX8/g7OaE+xrgY/4bZjpxC1 1pd66AAtKb3aNXpHvIfkVV6NYloo52H+FUE5ZDPNCGD0/btFGPWmWRmkPybzColTy7fmPaGz cBcEEqHK4T0aY4UJmE7Ylvg255Kz7s6wGZe6IR3N0cKNv++O7QARAQABtCVGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBpbnRlbC5jb20+iQJUBBMBCgA+AhsDAh4BAheABQsJCAcDBRUK CQgLBRYCAwEAFiEE0jZTh0IuwoTjmYHH+TPrQ98TYR8FAl1meboFCQlupOoACgkQ+TPrQ98T YR9ACBAAv2tomhyxY0Tp9Up7mNGLfEdBu/7joB/vIdqMRv63ojkwr9orQq5V16V/25+JEAD0 60cKodBDM6HdUvqLHatS8fooWRueSXHKYwJ3vxyB2tWDyZrLzLI1jxEvunGodoIzUOtum0Ce gPynnfQCelXBja0BwLXJMplM6TY1wXX22ap0ZViC0m714U5U4LQpzjabtFtjT8qOUR6L7hfy YQ72PBuktGb00UR/N5UrR6GqB0x4W41aZBHXfUQnvWIMmmCrRUJX36hOTYBzh+x86ULgg7H2 1499tA4o6rvE13FiGccplBNWCAIroAe/G11rdoN5NBgYVXu++38gTa/MBmIt6zRi6ch15oLA Ln2vHOdqhrgDuxjhMpG2bpNE36DG/V9WWyWdIRlz3NYPCDM/S3anbHlhjStXHOz1uHOnerXM 1jEjcsvmj1vSyYoQMyRcRJmBZLrekvgZeh7nJzbPHxtth8M7AoqiZ/o/BpYU+0xZ+J5/szWZ aYxxmIRu5ejFf+Wn9s5eXNHmyqxBidpCWvcbKYDBnkw2+Y9E5YTpL0mS0dCCOlrO7gca27ux ybtbj84aaW1g0CfIlUnOtHgMCmz6zPXThb+A8H8j3O6qmPoVqT3qnq3Uhy6GOoH8Fdu2Vchh TWiF5yo+pvUagQP6LpslffufSnu+RKAagkj7/RSuZV25Ag0EV9ZMvgEQAKc0Db17xNqtSwEv mfp4tkddwW9XA0tWWKtY4KUdd/jijYqc3fDD54ESYpV8QWj0xK4YM0dLxnDU2IYxjEshSB1T qAatVWz9WtBYvzalsyTqMKP3w34FciuL7orXP4AibPtrHuIXWQOBECcVZTTOdZYGAzaYzxiA ONzF9eTiwIqe9/oaOjTwTLnOarHt16QApTYQSnxDUQljeNvKYt1lZE/gAUUxNLWsYyTT+22/ vU0GDUahsJxs1+f1yEr+OGrFiEAmqrzpF0lCS3f/3HVTU6rS9cK3glVUeaTF4+1SK5ZNO35p iVQCwphmxa+dwTG/DvvHYCtgOZorTJ+OHfvCnSVjsM4kcXGjJPy3JZmUtyL9UxEbYlrffGPQ I3gLXIGD5AN5XdAXFCjjaID/KR1c9RHd7Oaw0Pdcq9UtMLgM1vdX8RlDuMGPrj5sQrRVbgYH fVU/TQCk1C9KhzOwg4Ap2T3tE1umY/DqrXQgsgH71PXFucVjOyHMYXXugLT8YQ0gcBPHy9mZ qw5mgOI5lCl6d4uCcUT0l/OEtPG/rA1lxz8ctdFBVOQOxCvwRG2QCgcJ/UTn5vlivul+cThi 6ERPvjqjblLncQtRg8izj2qgmwQkvfj+h7Ex88bI8iWtu5+I3K3LmNz/UxHBSWEmUnkg4fJl Rr7oItHsZ0ia6wWQ8lQnABEBAAGJAjwEGAEKACYCGwwWIQTSNlOHQi7ChOOZgcf5M+tD3xNh HwUCXWZ5wAUJB3FgggAKCRD5M+tD3xNhH2O+D/9OEz62YuJQLuIuOfL67eFTIB5/1+0j8Tsu o2psca1PUQ61SZJZOMl6VwNxpdvEaolVdrpnSxUF31kPEvR0Igy8HysQ11pj8AcgH0a9FrvU /8k2Roccd2ZIdpNLkirGFZR7LtRw41Kt1Jg+lafI0efkiHKMT/6D/P1EUp1RxOBNtWGV2hrd 0Yg9ds+VMphHHU69fDH02SwgpvXwG8Qm14Zi5WQ66R4CtTkHuYtA63sS17vMl8fDuTCtvfPF HzvdJLIhDYN3Mm1oMjKLlq4PUdYh68Fiwm+boJoBUFGuregJFlO3hM7uHBDhSEnXQr5mqpPM 6R/7Q5BjAxrwVBisH0yQGjsWlnysRWNfExAE2sRePSl0or9q19ddkRYltl6X4FDUXy2DTXa9 a+Fw4e1EvmcF3PjmTYs9IE3Vc64CRQXkhujcN4ZZh5lvOpU8WgyDxFq7bavFnSS6kx7Tk29/ wNJBp+cf9qsQxLbqhW5kfORuZGecus0TLcmpZEFKKjTJBK9gELRBB/zoN3j41hlEl7uTUXTI JQFLhpsFlEdKLujyvT/aCwP3XWT+B2uZDKrMAElF6ltpTxI53JYi22WO7NH7MR16Fhi4R6vh FHNBOkiAhUpoXRZXaCR6+X4qwA8CwHGqHRBfYFSU/Ulq1ZLR+S3hNj2mbnSx0lBs1eEqe2vh cA== Message-ID: <1701432f-d080-8772-3612-3710f0f9eae0@intel.com> Date: Fri, 18 Oct 2019 10:42:43 +0100 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v12 0/7] ethdev: add new Rx offload flags X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/18/2019 8:32 AM, Andrew Rybchenko wrote: > Hi Ferruh, > > since I've reviewed I'll reply as I understand it. > > On 10/17/19 8:43 PM, Ferruh Yigit wrote: >> On 10/17/2019 1:02 PM, pbhagavatula@marvell.com wrote: >>> From: Pavan Nikhilesh >>> >>> Add new Rx offload flags `DEV_RX_OFFLOAD_RSS_HASH` and >>> `DEV_RX_OFFLOAD_FLOW_MARK`. These flags can be used to >>> enable/disable PMD writes to rte_mbuf fields `hash.rss` and `hash.fdir.hi` >>> and also `ol_flags:PKT_RX_RSS` and `ol_flags:PKT_RX_FDIR`. >> Hi Pavan, >> >> Initially sorry for involving late, >> >> When we expose an interface to the applications, they will expect those will be >> respected by underlying PMDs. >> As far as I can see drivers are updated to report new added Rx offload flags as >> supported capabilities but drivers are not using those flags at all, so >> application providing that flag won't really enable/disable anything, I think >> this is a problem and it is wrong to lie even for the PMDs J > > It is required to let applications know that the offload is supported. > There are a number of cases when an offload cannot be disabled, > but it does not mean that the offload must not be advertised. Can't disable is something else, although I believe that is rare case, in this case driver can enable/disable the RSS and representing this as an offload capability. But when user want to configure this offload by setting or unsetting in offload config, driver just ignores it. > If driver see benefits from disabling the offload (e.g. avoid delivery > of RSS hash from NIC to host), it can do it after the patchset. Yes but I think this patchset shouldn't ignore that disabling the feature is not implemented yet. If those PMDs that has been updated to report the HASH capability has RSS enabled by default, I suggest adding a check for this offload in PMD, if it is requested to disable (which means not requested for enable), print a log saying disabling HASH is not supported and set this flag in the offload configuration to say PMD is configured to calculate the HASH. Later PMD maintainers may prefer to replace that error log with actual disable code. > >> Specific to `DEV_RX_OFFLOAD_RSS_HASH`, we have already some RSS config >> structures and it is part of the 'rte_eth_dev_configure()' API, won't it create >> multiple way to do same thing? > > No, a new offload is responsible for RSS hash delivery from NIC to host > and fill in in mbuf returned to application on Rx. What you have described is already happening without the new offload flag and this is my concern that we are duplicating it. There is a 'struct rte_eth_rxmode' (under 'struct rte_eth_conf') which has 'enum rte_eth_rx_mq_mode mq_mode;' If "mq_mode == ETH_MQ_RX_NONE" hash calculation is disabled, and 'mbuf::hash::rss' is not updated. (Thanks Bruce to helping finding it out) > >> And for the `ol_flags:PKT_RX_RSS` flag, it was already used to mark that >> 'mbuf::hash::rss' is valid, right? Is there anything new related that in the set? > > As I understand you mean, ol_flags::PKT_RX_RSS_HASH. > Yes, the new offload allows say if application needs it or now. > Basically it decouples RSS distribution and hash delivery. Setting 'ol_flags::PKT_RX_RSS_HASH' and 'mbuf::hash::rss' already there and not changing. I just want to clarify since this is not clear in the commit log. Only addition is to add a new flag to control PMD to enable/disable hash calculation (which PMDs ignore in the patch ???) > >> Specific to the `DEV_RX_OFFLOAD_FLOW_MARK` and `RTE_FLOW_ACTION_FLAG`, they are >> rte_flow actions, application can verify and later request these actions via >> rte_flow APIs. Why we are adding an additional RX_OFFLOAD flag for them? > > The reason is basically the same as above. HW needs to know in advance, > if application is going to use flow marks and configure Rx queue to enable > the information delivery. What you described is done via 'rte_flow_create()' API, application will request those actions via API and Rx queue will be configured accordingly, this is more dynamic approach. Why application need to set this additional configuration flag? And as above the new RX offload flags ignored by PMDs, hard to understand what is the intention here. Above usage of flags feels like the intention is adding some capability information for the PMDs more that adding new offload configuration. If so this is bigger/older problem, and instead of abusing the offload flags we can think of an API to present device capabilities, and move features.ini content to the API in long term. > >>> Add new packet type set function `rte_eth_dev_set_supported_ptypes`, >>> allows application to inform PMDs about the packet types it is interested >>> in. Based on ptypes requested by application PMDs can optimize the Rx path. >> OK to the API, but why "Packet type parsing" feature updated to say it should >> implement this API? >> Is this API really required to say "Packet type parsing" supported by PMD? > > As I understand it is not strictly required, but related to the feature. I am OK with "related", but it is documented as "implements", so doc says it is required. > >>> For example, if a given PMD doesn't support any packet types that the >>> application is interested in then the application can disable[1] writes to >>> `mbuf.packet_type` done by the PMD and use a software ptype parser. >>> [1] rte_eth_dev_set_supported_ptypes(*port_id*, RTE_PTYPE_UNKNOWN, >>> NULL, 0); >> And for the 7/7 patch, why we are updating all examples, is the API something do >> we really need to call for any DPDK application? I am for leaving the default >> behavior unless there is a very specific case for set or disable packet typing. >> Instead implement a command in testpmd to test this feature. > > If an application does not use packet types provided in mbuf, it is > better to inform PMD that the information is not required to allow PMD > to do optimizations. > I can see disabling packet type detection may increase the performance but sample applications are to demonstrate a specific feature, adding these kind of APIs will pollute them. 'skeleton' app that shows the most basic code for forwarding sample, why it is now having "experimental" 'set_supported_ptypes()' API? Same for other. As said before I think a testpmd command suits better here. > Yes, may be it would be better to have it as the > default behaviour, but it would be behaviour change in comparison > to previous DPDK releases and it is better to avoid it. Sorry I missed why not calling this function cause behavior change? I think it is other way around, no? > Thanks, > Andrew. > >>> v12 Changes: >>> ----------- >>> - Rebase onto next-net. >>> >>> v11 Changes: >>> ----------- >>> - Use RTE_DIM to get array size. >>> - Since we are using a list of MASKs to validate ptype_mask return -EINVAL >>> if any unknown mask is set. >>> - Rebase to TOT. >>> >>> v10 Changes: >>> ----------- >>> - Modify ptype_mask validation in set_supported_ptypes.(Andrew) >>> >>> v9 Changes: >>> ---------- >>> - Add ptype_mask validation in set_supported_ptypes.(Andrew) >>> - Make description more verbose. >>> >>> v8 Changes: >>> ---------- >>> - Make description more verbose. >>> - Set RTE_PTYPE_UNKNOWN in set_ptypes array when either get ot set ptypes >>> is not supported by ethernet device. >>> >>> v7 Changes: >>> ---------- >>> - Fix unused variable in net/octeontx2 >>> >>> v6 Changes: >>> ---------- >>> - Add additional checks for set supported ptypes.(Andrew) >>> - Clarify `rte_eth_dev_set_supported_ptypes` documentation. >>> - Remove DEV_RX_OFFLOAD_FLOW_MARK emulation from net/octeontx2. >>> >>> v5 Changes: >>> ---------- >>> - Fix typos. >>> >>> v4 Changes: >>> ---------- >>> - Set the last element in set_ptype array as RTE_PTYPE_UNKNOWN to mark the end >>> of array. >>> - Fix invalid set ptype function call in examples. >>> - Remove setting rte_eth_dev_set_supported_ptypes to UNKNOWN in l3fwd-power. >>> >>> v3 Changes: >>> ---------- >>> - Add missing release notes. (Andrew) >>> - Re-word various descriptions. >>> - Fix ptype set logic. >>> >>> v2 Changes: >>> ---------- >>> - Update release notes. (Andrew) >>> - Redo commit logs. (Andrew) >>> - Disable ptype parsing for unsupported examples. (Jerin) >>> - Disable RSS write only in generic mode eventdev_pipeline. (Jerin) >>> - Modify set_supported_ptypes function to return successfuly set mask >>> instead of failure. >>> - Dropped set_supported_ptypes to drivers by handling in library >>> layer, interested PMD can add it in. >>> >>> Pavan Nikhilesh (7): >>> ethdev: add set ptype function >>> ethdev: add mbuf RSS update as an offload >>> ethdev: add flow action type update as an offload >>> drivers/net: update Rx RSS hash offload capabilities >>> drivers/net: update Rx flow flag and mark capabilities >>> examples/eventdev_pipeline: add new Rx RSS hash offload >>> examples: disable Rx packet type parsing >> <...> >