From: Thomas Monjalon <thomas@monjalon.net>
To: huichao cai <chcchc88@163.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"stable@dpdk.org" <stable@dpdk.org>,
"Ananyev, Konstantin" <konstantin.ananyev@intel.com>
Subject: Re: [dpdk-dev] [PATCH v2] ip_frag: fix fragmenting IPv4 fragment
Date: Thu, 14 Oct 2021 08:51:13 +0200 [thread overview]
Message-ID: <17025089.1yWGkTkiXE@thomas> (raw)
In-Reply-To: <DM6PR11MB4491ED2E255B96761AC907249AB69@DM6PR11MB4491.namprd11.prod.outlook.com>
> > Current implementation of rte_ipv4_fragment_packet() doesn’t take
> > into account offset and flag values of the given packet, but blindly
> > assumes they are always zero (original packet is not fragmented).
> > According to RFC791, fragment and flag values for new fragment
> > should take into account values provided in the original IPv4 packet.
> >
> > Fixes: 4c38e5532a07 ("ip_frag: refactor IPv4 fragmentation into a proper library")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: huichao cai <chcchc88@163.com>
>
> Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
Applied, thanks.
next prev parent reply other threads:[~2021-10-14 6:51 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-27 10:06 [dpdk-dev] [PATCH] ip_frag: modify the fragment offset and mf huichao cai
2021-10-07 17:26 ` Ananyev, Konstantin
2021-10-08 8:05 ` 蔡慧超
2021-10-08 8:33 ` Ananyev, Konstantin
2021-10-08 9:37 ` 蔡慧超
2021-10-08 10:24 ` Ananyev, Konstantin
2021-10-09 7:27 ` [dpdk-dev] [PATCH v2] ip_frag: fix fragmenting IPv4 fragment huichao cai
2021-10-12 10:16 ` Ananyev, Konstantin
2021-10-13 6:53 ` 蔡慧超
2021-10-13 9:12 ` Ananyev, Konstantin
2021-10-13 9:50 ` 蔡慧超
2021-10-14 6:51 ` Thomas Monjalon [this message]
2021-10-13 21:11 ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon
2021-10-14 3:30 ` 蔡慧超
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=17025089.1yWGkTkiXE@thomas \
--to=thomas@monjalon.net \
--cc=chcchc88@163.com \
--cc=dev@dpdk.org \
--cc=konstantin.ananyev@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).