From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id 8D9991B495; Thu, 7 Feb 2019 13:08:05 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id C60AB2202E; Thu, 7 Feb 2019 07:08:04 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Thu, 07 Feb 2019 07:08:04 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=4HNYmZa9oDICdbvpRaXcaapAEM2I4zh/aUoSo5RlTx8=; b=Qp3DxuX2rVpi 0LDCKNSkJ3ZU0fu8ci7o+LRU0y4mILESL67Ii/h2TfVMfpX2ijCRYC7RoCnBbSX6 q1hkxrzw7fA/KHDcRb1BifBavpV2YVPkDb35jy9vb6g+aCuMTQLNfcPVv4hdchX0 8i48hz8OE2eI4D7wknUphIKCW7nBhW4= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=4HNYmZa9oDICdbvpRaXcaapAEM2I4zh/aUoSo5RlT x8=; b=hZWTvWu0yCaLDpX59W41qvwCETvBRaCNG7+PPhajgZAt7oDDhgug4bGqB dyq7MMMq89yt/H8XycMzM1jL1w8uCpMYVV2v6kVv2R1o5QeutN3fdySdvKyMlkvE aCDRzM6VV4j9hZr68Z9ybkw22omGEhCSiAx6/LGpI54UX5kbvODHCLZc/PfUqtsA sriaR/hSURqB5hNz1NhQnATl+TnYqCgRgmZLXRdkVH6PZM2So5aurowJ00NXEcjj QDYKJ5DNrN/14rZYrVf4Z8cGMZIrN4Q+t6bsofZe4vJv1XeTQ5/rHlAbYbjid1AY n0Es6PjjXw0WmHcxlQmpmMEwg8e2A== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedtledrledtgdefkecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfhuthenuceurghilhhouhhtmecufedt tdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhephffvufffkfgjfh gggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgrshcuofhonhhjrghlohhnuceo thhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecukfhppeejjedrudefgedrvddtfe drudekgeenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhho nhdrnhgvthenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 130E910319; Thu, 7 Feb 2019 07:08:01 -0500 (EST) From: Thomas Monjalon To: Ferruh Yigit Cc: "Parthasarathy, JananeeX M" , "dev@dpdk.org" , "rmody@marvell.com" , "Pattan, Reshma" , "shshaikh@marvell.com" , "Xing, Beilei" , "Zhang, Qi Z" , "alejandro.lucero@netronome.com" , "De Lara Guarch, Pablo" , "Doherty, Declan" , "Chaitanya Babu, TalluriX" , "stable@dpdk.org" , Bruce Richardson Date: Thu, 07 Feb 2019 13:08:00 +0100 Message-ID: <17028779.ipLFek0gqz@xps> In-Reply-To: References: <1547445875-24601-1-git-send-email-tallurix.chaitanya.babu@intel.com> <7AE31235A30B41498D1C31348DC858BD5B5217F4@IRSMSX103.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2] drivers: fix to replace strcat with strncat X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Feb 2019 12:08:05 -0000 07/02/2019 12:56, Ferruh Yigit: > On 1/21/2019 10:43 AM, Parthasarathy, JananeeX M wrote: > > > > > >> -----Original Message----- > >> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Chaitanya Babu Talluri > >> Sent: Friday, January 18, 2019 8:54 PM > >> To: dev@dpdk.org > >> Cc: rmody@marvell.com; Pattan, Reshma ; > >> shshaikh@marvell.com; Xing, Beilei ; Zhang, Qi Z > >> ; alejandro.lucero@netronome.com; De Lara Guarch, > >> Pablo ; Doherty, Declan > >> ; Chaitanya Babu, TalluriX > >> ; stable@dpdk.org > >> Subject: [dpdk-dev] [PATCH v2] drivers: fix to replace strcat with strncat > >> > >> Strcat does not check the destination length and there might be chances of > >> string overflow so insted of strcat, strncat is used. > >> > >> Fixes: 540a211084 ("bnx2x: driver core") > >> Fixes: e163c18a15 ("net/i40e: update ptype and pctype info") > >> Fixes: ef28aa96e5 ("net/nfp: support multiprocess") > >> Fixes: 6f4eec2565 ("test/crypto: enhance scheduler unit tests") > >> Cc: stable@dpdk.org > >> > >> Signed-off-by: Chaitanya Babu Talluri > > <...> > > > > > Any Review Please!! > > > > cc'ed Bruce & Thomas. > > What do you think getting strlcat() patch first and updating this patch to use > strlcat()? > > Are we OK to get strlcat as the default API? No problem