From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas@monjalon.net>
Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com
 [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id 156B658FE
 for <dev@dpdk.org>; Wed, 25 Apr 2018 12:32:40 +0200 (CEST)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
 by mailout.nyi.internal (Postfix) with ESMTP id 93CE421C94;
 Wed, 25 Apr 2018 06:32:39 -0400 (EDT)
Received: from mailfrontend1 ([10.202.2.162])
 by compute1.internal (MEProxy); Wed, 25 Apr 2018 06:32:39 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
 cc:content-transfer-encoding:content-type:date:from:in-reply-to
 :message-id:mime-version:references:subject:to:x-me-sender
 :x-me-sender:x-sasl-enc; s=mesmtp; bh=FeWZX1XopVX9oh0fLTwqGhWX46
 4nQQRtm2G5bZZeRzU=; b=W8ZUhp5E/360F0Ig46Ef0LiW23nxYftvxsPieRB8JY
 q26u9CY17bgdChBIeXDlaDpWfOOAbCJ+r9EKzZU4N3BZtW6PUBBUoMBRGDh+i9TA
 Xg7z9F5wg26b/+t2RnjUwz5slT0qq+e2uihFZUBbFsR0MdY65L1bMS/MSr9jeYuN
 g=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-transfer-encoding:content-type
 :date:from:in-reply-to:message-id:mime-version:references
 :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=FeWZX1
 XopVX9oh0fLTwqGhWX464nQQRtm2G5bZZeRzU=; b=A6QvOp27h+aNkwAh/+HmfF
 ZzgOyueSsNHHHHhLEuMd6vKnQK4KQvx/rTSgugKflGHrH5sN0QDVTDxhONw3vVKv
 7IQaj8VfljDjQkVQwiuaj/FX2jk8qgTXMPwdclCSzzBnJCVQsNiN6NO0hdUpFnfp
 xnCrbfvtqJVZKpT7iQHCxkLEswCC94RkT+66otc7E4xQiiDG71PolQQozH3718JC
 nuG0VPf+32/oy7ee/Q8n9iq+LLEewYqNfMpZCgPoxPkozjnar+Zsh8PrkUijONkJ
 BTIosKcvtsboSXCkT/3dR5aeBKDRw2CeYQBp/AIv8Y3Pi3bFNeLQVcuFhcOv+9kQ
 ==
X-ME-Sender: <xms:R1ngWtSAl8g7BrH4gMyfJIQO6yDgvjLf-5tVa4vZP4d_0nUE8we_sQ>
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
 by mail.messagingengine.com (Postfix) with ESMTPA id E8D1BE4B94;
 Wed, 25 Apr 2018 06:32:38 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: Anatoly Burakov <anatoly.burakov@intel.com>
Cc: dev@dpdk.org
Date: Wed, 25 Apr 2018 12:32:37 +0200
Message-ID: <1703557.Am3HRJYA0H@xps>
In-Reply-To: <9061a11d7dbba7452207c0943b05796f15a0af1d.1524650784.git.anatoly.burakov@intel.com>
References: <cover.1524650784.git.anatoly.burakov@intel.com>
 <9061a11d7dbba7452207c0943b05796f15a0af1d.1524650784.git.anatoly.burakov@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH v2] eal: remove call to unlock
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 25 Apr 2018 10:32:40 -0000

25/04/2018 12:08, Anatoly Burakov:
> Coverity was complaining about not checking result of call to
> fcntl() for unlocking the file. Disregarding the fact that error
> value returned from fcntl() unlock call is highly unlikely in the
> first place, we are subsequently calling close() on that same fd,
> which will drop the lock, which makes call to fcntl() unnecessary.
> 
> Fix this by removing a call to fcntl() altogether.
> 
> Coverity issue: 272607
> 
> Fixes: 66cc45e293ed ("mem: replace memseg with memseg lists")
> Cc: anatoly.burakov@intel.com
> 
> Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>

Applied, thanks