From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 669B3374 for ; Tue, 27 Jun 2017 16:28:22 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id D0249212DE; Tue, 27 Jun 2017 10:28:21 -0400 (EDT) Received: from frontend2 ([10.202.2.161]) by compute1.internal (MEProxy); Tue, 27 Jun 2017 10:28:21 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc:x-sasl-enc; s=mesmtp; bh=/a2XO8RYl+EgN+C soPkHA1Qk0ODy3dCImzUmh87BtWk=; b=PTuAc2sXIMnOo5+7VRgB8DxWZ0vtqDn mAbqBrvCQZ0Gg0kt1DLPuQn/1V712RF7ltgJCzl32tD+T6V+ne8ejkepkNdFALCY HWek6vUUxUodhqFndXgOPW5yjUhDAkSlwanwcz1Vcl5AjT+gMP8p+4kwHXD7gLZM No8FabnZEiY4= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s= fm1; bh=/a2XO8RYl+EgN+CsoPkHA1Qk0ODy3dCImzUmh87BtWk=; b=q1VQ1xTm ccZSsl/vv4XCRbV4nRPe++KweoUteeWYjyrMNjofIpPV6zOFH2ly4ijAgE0B4qr1 nfcij1mYGkUU9d5V1Dl2DsScXXlx2xWnS+ft6vie2wBIfHErifvpWZud+5JGaxQD lwCzj3K2tlQoFeebXBVteertT9ls7KPR/4v+97SEdxEm/ZlIUUwylb+4LbRgIGav /Zyv4DJGnVuvp0lP4J6np1YWOxNRS6P2/9F9Mb9ScUTKQ8Vdw9Cr+G7oYiQ9viXD 9F/Hl+x7s+gjRP6ObrtKZK/bBjMeqhRtG0yIlxjmZ1fdizpb5RS/km0mrnbEvM9D V6TGfpyVhNpbPA== X-ME-Sender: X-Sasl-enc: 8djFbgs3tPchnu1NNYmvVgdvVLVI3JC+FfWtAE0CSGN0 1498573701 Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 824872458E; Tue, 27 Jun 2017 10:28:21 -0400 (EDT) From: Thomas Monjalon To: "De Lara Guarch, Pablo" Cc: dev@dpdk.org, "Doherty, Declan" Date: Tue, 27 Jun 2017 16:28:20 +0200 Message-ID: <1703981.y8KKVdfaY4@xps> In-Reply-To: References: <1495639634-74846-1-git-send-email-pablo.de.lara.guarch@intel.com> <2058861.mNNx7DgSpj@xps> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2 06/12] cryptodev: move vdev functions to a separate file X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Jun 2017 14:28:22 -0000 27/06/2017 11:51, De Lara Guarch, Pablo: > From: Thomas Monjalon [mailto:thomas@monjalon.net] > > 23/06/2017 14:52, Declan Doherty: > > > On 21/06/2017 7:28 AM, Pablo de Lara wrote: > > > > Move all functions handling virtual devices to a separate header > > > > file "rte_cryptodev_vdev.h", in order to leave only generic > > > > functions for any device in the rest of the files. > > > > > > > > Signed-off-by: Pablo de Lara > > > > > > Acked-by: Declan Doherty > > > > This patch is moving some code from a .c to a .h. > > The consequence is that driver are now compiling new functions from the .h > > and require librte_kvargs to link with. > > It is a build error in shared lib mode. > > > > Please keep the code in a .c file if possible. > > Sorry about this. I just fixed it in the subtree, so pull it whenever you are ready. > Also, since ethdev have separated pci and vdev functions in separate .h files, > I preferred to be consistent and do the same. There is no reason to implement these functions in .h files. I prefer to keep them in a .c file and just export the proto in .h.