From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CC865A0543; Tue, 24 May 2022 19:52:04 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B1139400EF; Tue, 24 May 2022 19:52:04 +0200 (CEST) Received: from wout3-smtp.messagingengine.com (wout3-smtp.messagingengine.com [64.147.123.19]) by mails.dpdk.org (Postfix) with ESMTP id 86F0E400D6 for ; Tue, 24 May 2022 19:52:03 +0200 (CEST) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id C3C4732004ED; Tue, 24 May 2022 13:52:00 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Tue, 24 May 2022 13:52:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm1; t=1653414720; x= 1653501120; bh=8yolbKfFl1D/XGJs+V46lUAZW/DJ9Y6MERYPYMQFlsM=; b=W KxTURERJyChCMqgP04M4chtwieVXkeZB4r1uq82LS/H4suhTcuXKcKQSYFV0ZiUe xL2siVi9eQi5/5/Un5YpHNFYD6o+xPrh0Ai2ikawITGJ/+e0WP8aV0Hrj2TuU+Ac 5ba0aS9Bk52d84WZFy0AciQJu99eJA2VtUVjMkqB0y5HbD1wWHVxeAc7m8T2TPxl mJ7yd638UqRZ290sRTiJcXSpUTXrsxuys0F9YBsXIgEqOFGPEqruYfqJK6NaytRV Mm28ILUh9n2w9dEjCQIaNth+8dM81vQYI4q/i7Q/C0UXl0gJaEfVTurRbKFabxex HIbVcPwG3b1k/ScAtRLfw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1653414720; x= 1653501120; bh=8yolbKfFl1D/XGJs+V46lUAZW/DJ9Y6MERYPYMQFlsM=; b=t dZEMbLY9Kal5Z0+idUnKLtgrnwlHRn7fKcOKQNjRw3KTpksvZlqc9TFjeO26SMZj TlDeIIpeR4AH0C9SXrk3wOpm8U+L+O9LD5ZJhc3kcVf5GseEItI65+AMhyoYFlo+ FH7MpT5CGTzDtDZjPH3TVhpKAeM6E4ibNH6jWz+vks9EOlSvHcuhDmSUAycE9YiZ TMRdCfaIkG9DBS6q6DCMtOQkoC2P/5d+567ebv2uVzDs3WfujdguNqlBnoWqhQ/M DbKA+WqLXexp98nyZEPHMGXdz3dmAJQt6cVboPU5dwjvUBXQbLevrobNjcvSTcxR Zr18EoF5Mo4QB8ckFseYA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrjeefgdduudejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedtjeeiieefhedtfffgvdelteeufeefheeujefgueetfedttdei kefgkeduhedtgfenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 24 May 2022 13:51:58 -0400 (EDT) From: Thomas Monjalon To: David Marchand Cc: dev , Andrew Rybchenko , Ferruh Yigit , Xiaoyun Li , Aman Singh , Yuying Zhang , Bruce Richardson , spiked@nvidia.com Subject: Re: [PATCH 2/6] app/testpmd: register driver specific commands Date: Tue, 24 May 2022 19:51:50 +0200 Message-ID: <1704192.KUTt5R2Mg1@thomas> In-Reply-To: References: <20220513075718.18674-1-david.marchand@redhat.com> <2203012.AOvM4ru3NT@thomas> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 24/05/2022 19:44, David Marchand: > On Tue, May 24, 2022 at 7:21 PM Thomas Monjalon wrote: > > 23/05/2022 09:10, David Marchand: > > > +# Driver specific sources include some testpmd headers. > > > > Suggested reword: > > Driver-specific commands are located in driver directories. > > At the moment, it's only about testpmd commands. > Maybe in the future we can have other specific code in those driver sources. > That's why I preferred a generic term. It is a comment in the context of testpmd here. [...] > > > +#define TESTPMD_ADD_DRIVER_COMMANDS(c) \ > > > > Why not TESTPMD_ADD_COMMANDS? > > I forgot to align both the function and macro. > Please note though that for now, the registered commands through this > API get displayed in the "Driver specific" usage section. > So maybe the API should state it is about driver specific commands. > > WDYT? You're right, it should be driver-specific commands. > > [...] > > > --- a/drivers/meson.build > > > +++ b/drivers/meson.build > > > + if testpmd_sources.length() != 0 > > > + testpmd_drivers_sources += testpmd_sources > > > + testpmd_drivers_deps += dependency_name > > > + endif > > > > Are you sure the check is required? > > What happens if adding an empty string? > > We don't want to push a driver dependency to testpmd if there is nothing to add. Oh yes, OK.