From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: "Doherty, Declan" <declan.doherty@intel.com>, dev@dpdk.org
Subject: Re: [dpdk-dev] crypto drivers in the API
Date: Tue, 14 Feb 2017 12:04:24 +0100 [thread overview]
Message-ID: <1704265.GvoO55czvH@xps13> (raw)
In-Reply-To: <ee8ebdc0-45bf-0389-c056-a3f03221a610@intel.com>
2017-02-14 10:44, Doherty, Declan:
> On 13/02/2017 1:25 PM, Thomas Monjalon wrote:
> > In the crypto API, the drivers are listed.
> > In my opinion, it is a wrong designed and these lists should be removed.
> > Do we need a deprecation notice to plan this removal in 17.05, while
> > working on bus abstraction?
> >
> ...
> >
>
> Hey Thomas,
> I agree that these need to be removed, and I had planned on doing this
> for 17.05 but I have a concern on the requirements for ABI breakage in
> relation to this. This enum is unfortunately used in both the
> rte_cryptodev and rte_crypto_sym_session structures which are part of
> the libraries public API. I don't think it would be feasible to maintain
> a set of 17.02 compatible APIs with the changes this would introduce, as
> it would require a large number of functions to have 2 versions? Is it
> OK to break the ABI for this case?
Yes
If you were planning to do this, you should have sent a deprecation notice
few weeks ago.
Please send it now and we'll see if we have enough supporters shortly.
next prev parent reply other threads:[~2017-02-14 11:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-13 13:25 Thomas Monjalon
2017-02-13 13:29 ` Thomas Monjalon
2017-02-14 10:44 ` Doherty, Declan
2017-02-14 11:04 ` Thomas Monjalon [this message]
2017-02-14 14:46 ` Doherty, Declan
2017-02-14 15:47 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1704265.GvoO55czvH@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=declan.doherty@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).