From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f180.google.com (mail-wr0-f180.google.com [209.85.128.180]) by dpdk.org (Postfix) with ESMTP id C9ECCA2F for ; Tue, 14 Feb 2017 12:04:25 +0100 (CET) Received: by mail-wr0-f180.google.com with SMTP id o16so167601981wra.1 for ; Tue, 14 Feb 2017 03:04:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:subject:date:message-id:user-agent:in-reply-to:references :mime-version:content-transfer-encoding; bh=hJfR7UHmVfLW7D6l00yO1iFscqR9sOavo/reAOmRsTw=; b=FovzP7GIxz6BhE7l5CszcWpPl0OV/OvPHDACDKubZnKCJwlbzKzyd8pJaySm2qTqBK 3yy4PSx+16oUs9b7vdw5btIc+8Qg8/jzzoXMI6rG9oj33dRzfDu96zvTDZKED4c/VjM/ ZolhU7cf/iFNeY8DoI8rNBbY2jlGSbPFLgRmj2a3r9gpn0annc98AWhW3FuKKw5OzSru pXgy8UHq/wSZtzR0KnTqX/SnC5KKf42EQU0YqxVd41w8InK0gswVbBJwyCPqQS6mO+sV VS5wYt7nI/o7+VTHodLUBLdF/grbPK3y58PnL9MpXlk/GJeCl4UpaXMq11MBwjLjSVLB 3znQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=hJfR7UHmVfLW7D6l00yO1iFscqR9sOavo/reAOmRsTw=; b=YUnS4yRrrIfAsL3pCnrSqGqe0EuwwfZyrPxbq7WS+r1zCNz4xYV8s4j25vyh4B86jH 9Tw00SDLi2H0LfmhCfU7JSB52k3igstPgQdt+cGErMO+pbiWe3n0bCNizYTpDgWUm3QJ PmTW5wzmSMMN6QUqLbTzW92GyPsQ6W3ifiazN/F+CtG6cRxMC3E13F6dWKnVwph0TsZw pYC0w+J3X2ayfzq5SpxfawIB9LzMmHiw4pmModoVorNdH3WYPgMQG54bEQVZyZiKFDcd 6ozZs4AolZsexTJ7H0CUTVSCJQzOQUU8GTUjyWNiNILz4pUXLAW04ubOFWufqNlth08u Cq7g== X-Gm-Message-State: AMke39ld/2QEeitoGzgCbE0u1YwD4wqlqr0Oy219XH8tibfnOoD4SNogD+atKUNvBU4UIRL4 X-Received: by 10.223.151.53 with SMTP id r50mr22934561wrb.129.1487070265643; Tue, 14 Feb 2017 03:04:25 -0800 (PST) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id i29sm325905wrc.25.2017.02.14.03.04.24 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 14 Feb 2017 03:04:25 -0800 (PST) From: Thomas Monjalon To: "Doherty, Declan" , dev@dpdk.org Date: Tue, 14 Feb 2017 12:04:24 +0100 Message-ID: <1704265.GvoO55czvH@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: References: <1522880.cuOTJ3FilR@xps13> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] crypto drivers in the API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Feb 2017 11:04:26 -0000 2017-02-14 10:44, Doherty, Declan: > On 13/02/2017 1:25 PM, Thomas Monjalon wrote: > > In the crypto API, the drivers are listed. > > In my opinion, it is a wrong designed and these lists should be removed. > > Do we need a deprecation notice to plan this removal in 17.05, while > > working on bus abstraction? > > > ... > > > > Hey Thomas, > I agree that these need to be removed, and I had planned on doing this > for 17.05 but I have a concern on the requirements for ABI breakage in > relation to this. This enum is unfortunately used in both the > rte_cryptodev and rte_crypto_sym_session structures which are part of > the libraries public API. I don't think it would be feasible to maintain > a set of 17.02 compatible APIs with the changes this would introduce, as > it would require a large number of functions to have 2 versions? Is it > OK to break the ABI for this case? Yes If you were planning to do this, you should have sent a deprecation notice few weeks ago. Please send it now and we'll see if we have enough supporters shortly.