DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Ciara Power <ciara.power@intel.com>
Cc: ferruh.yigit@intel.com, arybchenko@solarflare.com, dev@dpdk.org,
	olivier.matz@6wind.com, stable@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] ethdev: fix include for ether header file
Date: Wed, 23 Oct 2019 16:01:34 +0200	[thread overview]
Message-ID: <1705631.EIreq0Hp37@xps> (raw)
In-Reply-To: <20191023125300.45569-1-ciara.power@intel.com>

23/10/2019 14:53, Ciara Power:
> The include for rte_ether.h in each of these files should not use
> quotes, as the header file is not in the librte_ethdev directory.  These
> are now updated to use <> symbols, to search directories pre-designated
> by the compiler.
> 
> Fixes: 57668ed7bc08 ("net: move ethernet definitions to the net library")
> Cc: olivier.matz@6wind.com
> Cc: stable@dpdk.org
> 
> Signed-off-by: Ciara Power <ciara.power@intel.com>
> ---
>  lib/librte_ethdev/rte_eth_ctrl.h | 2 +-
>  lib/librte_ethdev/rte_ethdev.c   | 2 +-
>  lib/librte_ethdev/rte_ethdev.h   | 2 +-
>  3 files changed, 3 insertions(+), 3 deletions(-)

Good change.
Acked-by: Thomas Monjalon <thomas@monjalon.net>

I'm curious, is it triggering any compilation issue?



  reply	other threads:[~2019-10-23 14:01 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-23 12:53 Ciara Power
2019-10-23 14:01 ` Thomas Monjalon [this message]
2019-10-23 14:47   ` Power, Ciara
2019-10-23 19:14   ` Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1705631.EIreq0Hp37@xps \
    --to=thomas@monjalon.net \
    --cc=arybchenko@solarflare.com \
    --cc=ciara.power@intel.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=olivier.matz@6wind.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).