DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: David Marchand <david.marchand@redhat.com>,
	John Levon <john.levon@nutanix.com>
Cc: dev <dev@dpdk.org>,
	"Burakov, Anatoly" <anatoly.burakov@intel.com>,
	Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
Subject: Re: [dpdk-dev] [PATCH v3] eal: allow hugetlbfs sub-directories
Date: Fri, 23 Jul 2021 09:29:54 +0200	[thread overview]
Message-ID: <1705686.Ar61aiJpx4@thomas> (raw)
In-Reply-To: <20210722210603.GA1799660@movementarian.org>

22/07/2021 23:06, John Levon:
> On Thu, Jul 22, 2021 at 10:29:45PM +0200, David Marchand wrote:
> 
> > On Thu, Jul 8, 2021 at 1:00 PM John Levon <john.levon@nutanix.com> wrote:
> > >
> > > get_hugepage_dir() was implemented in such a way that a --huge-dir
> > > option had to exactly match the mountpoint, but there's no reason for
> > > this restriction. Fix the implementation to allow a sub-directory within
> > > a suitable hugetlbfs mountpoint to be specified, preferring the closest
> > > match.
> > >
> > > Signed-off-by: John Levon <john.levon@nutanix.com>
> > 
> > This change in EAL hugetlbfs discovery is too dangerous to be taken after -rc1.
> 
> Sure.
> 
> > Could you give some usecases/examples on why this change is needed?
> 
> Would you like me to expand the commit message?

Yes please add some examples of directories explaining the issue you hit.

> I had hoped it was clear enough,
> but I suppose not. Simply put, DPDK above is assuming its the only user of
> hugepages on the system - including clear_hugedir(). That is certainly not the
> case for our use cases.
> 
> > Updating the documentation
> 
> https://doc.dpdk.org/guides/linux_gsg/linux_eal_parameters.html
> 
> """
> --huge-dir <path to hugetlbfs directory>
> 
> Use specified hugetlbfs directory instead of autodetected ones.
> """
> 
> That is, it already says "directory", not "mount". You'd like something
> additional saying it can be below a mount point?

Yes

> > and the unit test also seem necessary.
> 
> You're talking about app/test/test_eal_flags.c or something else?

Yes

Thanks



  reply	other threads:[~2021-07-23  7:29 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-10 21:05 [dpdk-dev] [PATCH] " John Levon
2021-06-25 10:44 ` [dpdk-dev] [PATCH RESEND] " John Levon
2021-07-06  9:43   ` David Marchand
2021-07-07 20:06   ` Dmitry Kozlyuk
2021-07-07 21:58     ` John Levon
2021-07-08  9:36     ` [dpdk-dev] [PATCH] " John Levon
2021-07-08  9:36       ` John Levon
2021-07-08 10:59     ` [dpdk-dev] [PATCH v3] " John Levon
2021-07-15 22:37       ` Dmitry Kozlyuk
2021-07-22 20:29       ` David Marchand
2021-07-22 21:06         ` John Levon
2021-07-23  7:29           ` Thomas Monjalon [this message]
2021-08-09 11:24             ` [dpdk-dev] [PATCH] " John Levon
2021-08-09 13:45               ` Jerin Jacob
2021-08-17 20:05               ` John Levon
2021-10-12 12:38                 ` David Marchand
2021-10-12 16:05                   ` [dpdk-dev] [PATCH] eal/linux: " John Levon
2021-10-12 19:03                     ` David Marchand
2021-10-12 19:58                       ` John Levon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1705686.Ar61aiJpx4@thomas \
    --to=thomas@monjalon.net \
    --cc=anatoly.burakov@intel.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=dmitry.kozliuk@gmail.com \
    --cc=john.levon@nutanix.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).