From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D493EA0A0C; Fri, 23 Jul 2021 09:29:37 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5666A40040; Fri, 23 Jul 2021 09:29:37 +0200 (CEST) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by mails.dpdk.org (Postfix) with ESMTP id CB87B4003C for ; Fri, 23 Jul 2021 09:29:35 +0200 (CEST) Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 698D25C0192; Fri, 23 Jul 2021 03:29:35 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Fri, 23 Jul 2021 03:29:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= /zwxw7FeLsK+PNU2YSKkG0dx2ZumnwHOC6JtMUgr9kY=; b=WgwnC9rsz0k0gI7L h7Tf9zvSa82xjZPUjfzq2KB1DaM3aTM0xoW6FtHOI5nxMiC7n76BGid6eVS5rGbt Pfh5HoJc5LksXrJI1gMDMafWfqVrvDDzW1HLRRSkYEF5AI/CQGc/I5ZWHSb/bE24 v53a6dqOkYXvcdlJtfFWQh/oxkRQH6SNFr1QRaSJ+f/QakkD3OCeiGOwkoLoRnC3 yM188E4LK4a+yhwHW0Vz3U3OXMMTaGF0cXDjoRg+u7zR8Y9G4VOH57vFesaT8YmC 2fROAPIlbOlUrLqjs72pSXQSGCQ/NicnKpvOrlU52hvc/2CDMvBlzTJY37xCz7yg icGnfw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=/zwxw7FeLsK+PNU2YSKkG0dx2ZumnwHOC6JtMUgr9 kY=; b=aRXAfMlSVCO3e04801Ajb3P/kOn5/eiuitRpRq91vkdN2LhvBeHEOObU/ d9BbGYifpXB0UUSlxdW3Q8yhSH+ij8Ud44zlnoi2qEl84GsZvHpXBUPHcvi8M4w8 XZR6q+HhAs7IHnfsn9NjTC+A7rLAJl24QFFDQgweCbZyzUuqofI8Au1xiNFs223e 7NxzkW/NN+9j/TYy2UDzpTbVPtqHcaZLr5Z99JVueoxZR56//5COzsXY6tFT74Uo oUVhx32koTnhEyrhtrEdPWeKsdtWRYaKKg6uPgPPImlOVaaBzJ3u6moNAonY2Lzt LZn8EYdAhI+8bGkZFvwJXYH4/+qsw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrfeejgdduudeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepffdvffejueetleefieeludduuefgteejleevfeekjeefieegheet ffdvkeefgedunecuffhomhgrihhnpeguphgukhdrohhrghenucevlhhushhtvghrufhiii gvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghlohhn rdhnvght X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 23 Jul 2021 03:29:33 -0400 (EDT) From: Thomas Monjalon To: David Marchand , John Levon Cc: dev , "Burakov, Anatoly" , Dmitry Kozlyuk Date: Fri, 23 Jul 2021 09:29:54 +0200 Message-ID: <1705686.Ar61aiJpx4@thomas> In-Reply-To: <20210722210603.GA1799660@movementarian.org> References: <20210707230605.58a79a47@sovereign> <20210722210603.GA1799660@movementarian.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v3] eal: allow hugetlbfs sub-directories X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 22/07/2021 23:06, John Levon: > On Thu, Jul 22, 2021 at 10:29:45PM +0200, David Marchand wrote: > > > On Thu, Jul 8, 2021 at 1:00 PM John Levon wrote: > > > > > > get_hugepage_dir() was implemented in such a way that a --huge-dir > > > option had to exactly match the mountpoint, but there's no reason for > > > this restriction. Fix the implementation to allow a sub-directory within > > > a suitable hugetlbfs mountpoint to be specified, preferring the closest > > > match. > > > > > > Signed-off-by: John Levon > > > > This change in EAL hugetlbfs discovery is too dangerous to be taken after -rc1. > > Sure. > > > Could you give some usecases/examples on why this change is needed? > > Would you like me to expand the commit message? Yes please add some examples of directories explaining the issue you hit. > I had hoped it was clear enough, > but I suppose not. Simply put, DPDK above is assuming its the only user of > hugepages on the system - including clear_hugedir(). That is certainly not the > case for our use cases. > > > Updating the documentation > > https://doc.dpdk.org/guides/linux_gsg/linux_eal_parameters.html > > """ > --huge-dir > > Use specified hugetlbfs directory instead of autodetected ones. > """ > > That is, it already says "directory", not "mount". You'd like something > additional saying it can be below a mount point? Yes > > and the unit test also seem necessary. > > You're talking about app/test/test_eal_flags.c or something else? Yes Thanks