From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <thomas@monjalon.net> Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id 8747A1B1BA for <dev@dpdk.org>; Thu, 25 Jan 2018 23:11:48 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id D7C9721381; Thu, 25 Jan 2018 17:11:47 -0500 (EST) Received: from frontend2 ([10.202.2.161]) by compute1.internal (MEProxy); Thu, 25 Jan 2018 17:11:47 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=UAy1XNEDsSnphKmkQQuIvZ2AmU YRO82PQP1k8wyAwJs=; b=njXuTxODcwjRscMYtyIWd9UpN/KvM35BmSLrJeqgSY 4nZ1G2z8sctcRHgl0hIegLqVC2ILISzCYWs3q3wLTaI1b8CvkugAC4GuB9B81RdO QK0vI5RB31wP/7Xvy/e0LdvfoIn5q83A+dbj9pTBCQOPRAzqrZuzLuQHmS/By3HD g= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=UAy1XN EDsSnphKmkQQuIvZ2AmUYRO82PQP1k8wyAwJs=; b=eJ2fcpX1eXTz8Y0wVbLOxp M57WCSFRtncPtg7s2hRD0MSFMAusDDqmWktEyGg/nA/04TkmjGehx2Mj9oM+B+8a Gt0o0fFQGaktSB3Mxs/TXzVRAcgUySMLLweOymPTZCY7jLWQBhmPIsafIui4BU1D Ek5cR6KeEQbH2J5Lm/JD816JREAibm6Kf/91sJ8mTDQCLqnTU7ogp9QNjE3LJd7R PkA6mvwS5Jv4Rtw+5jMSuSBmBfJYwGgXwFfLFN/odh897EoVaCa571Syet74OiMy uRradC11LhN4gwXPCrBySivvaI32U6Xp7E/yxl0Rh2G2Kwxi47EUzkZ7yNZq0s6A == X-ME-Sender: <xms:I1ZqWsa44XMQ9XugL5o4GtN1UPYjnNASH2Mx2kM7sG1zAvvj94x1cA> Received: from xps.localnet (unknown [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 831E824406; Thu, 25 Jan 2018 17:11:47 -0500 (EST) From: Thomas Monjalon <thomas@monjalon.net> To: Vipin Varghese <vipin.varghese@intel.com> Cc: dev@dpdk.org, harry.van.haaren@intel.com, bruce.richardson@intel.com Date: Thu, 25 Jan 2018 23:10:57 +0100 Message-ID: <1706116.QiZev3mjbx@xps> In-Reply-To: <1515694853-7949-1-git-send-email-vipin.varghese@intel.com> References: <1514731568-3979-1-git-send-email-vipin.varghese@intel.com> <1515694853-7949-1-git-send-email-vipin.varghese@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2] service: fix memory leak by rte_service_init X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Thu, 25 Jan 2018 22:11:48 -0000 11/01/2018 19:20, Vipin Varghese: > This patch fixes the memory leak created by rte_service_init. When > secondary application which shares the huge page from primary, is > executed multiple times memory is initialized but not freed on exit > > The rte_service_finalize checks if the service is initialized. If yes, > it frees up rte_services & lcore_states. The API has to be called at > end of application run. > > renamed the function from rte_service_deinit to rte_service_finalize. This is a changelog. It should appear below --- > Signed-off-by: Vipin Varghese <vipin.varghese@intel.com> Why not keeping previous ack? Your patches have been set to "Not Applicable" in patchwork. What happened?