DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Chengwen Feng <fengchengwen@huawei.com>,
	"Min Hu (Connor)" <humin29@huawei.com>
Cc: dev@dpdk.org, ferruh.yigit@intel.com
Subject: Re: [dpdk-dev] [PATCH 1/2] examples/ethtool: fix Rx/Tx queue setup with rte socket id
Date: Tue, 20 Apr 2021 11:37:00 +0200	[thread overview]
Message-ID: <1706834.A6OOkbCCPt@thomas> (raw)
In-Reply-To: <f8bdb513-5959-d4e0-9643-99813b9d9b15@huawei.com>

20/04/2021 11:05, Min Hu (Connor):
> 在 2021/4/20 8:57, Thomas Monjalon 写道:
> > 08/04/2021 12:14, Min Hu (Connor):
> >> From: Chengwen Feng <fengchengwen@huawei.com>
> >>
> >> The ethtool use the socket_id which get from rte_eth_dev_socket_id API
> >> in the init stage, but use the rte_socket_id API to get socket_id when
> >> setting ringparam.
> >>
> >> This patch make sure it call rte_eth_dev_socket_id API to get
> >> socket_id when setting ringparam.
> >>
> >> Fixes: bda68ab9d1e7 ("examples/ethtool: add user-space ethtool sample application")
> >> Cc: stable@dpdk.org
> > 
> > The explanation is missing something.
> > Please tell why it is wrong.
> > 
> > 
> Hi, Thomas,
> It is advised that bind queue resources to the NUMA node where the
> device resides, not the NUMA node corresponding to the thread where the
> command line resides. And that will be better.

I know, but in the commit message, you give function name
without saying that rte_socket_id is the running socket
while rte_eth_dev_socket_id is the device socket.

Please make your commit messages more obvious for anyone reading.
Story telling is usually a good approach.



  reply	other threads:[~2021-04-20  9:37 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-08 10:14 [dpdk-dev] [PATCH 0/2] fix bugs for ethtool APP Min Hu (Connor)
2021-04-08 10:14 ` [dpdk-dev] [PATCH 1/2] examples/ethtool: fix Rx/Tx queue setup with rte socket id Min Hu (Connor)
2021-04-20  0:57   ` Thomas Monjalon
2021-04-20  9:05     ` Min Hu (Connor)
2021-04-20  9:37       ` Thomas Monjalon [this message]
2021-04-08 10:14 ` [dpdk-dev] [PATCH 2/2] examples/ethtool: add closing port operation Min Hu (Connor)
2021-04-20  0:59   ` Thomas Monjalon
2021-04-20  9:10     ` Min Hu (Connor)
2021-04-20  9:38       ` Thomas Monjalon
2021-05-06  3:46 ` [dpdk-dev] [PATCH v2 0/2] fix bugs for ethtool APP Min Hu (Connor)
2021-05-06  3:46   ` [dpdk-dev] [PATCH v2 1/2] examples/ethtool: fix Rx/Tx queue setup with rte socket id Min Hu (Connor)
2021-09-28  1:34     ` Min Hu (Connor)
2021-05-06  3:46   ` [dpdk-dev] [PATCH v2 2/2] examples/ethtool: add closing port operation Min Hu (Connor)
2021-09-28  1:22     ` Min Hu (Connor)
2021-11-17 17:15     ` David Marchand
2021-06-28  3:22   ` [dpdk-dev] [PATCH v2 0/2] fix bugs for ethtool APP Min Hu (Connor)
2021-07-17  2:24     ` Min Hu (Connor)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1706834.A6OOkbCCPt@thomas \
    --to=thomas@monjalon.net \
    --cc=dev@dpdk.org \
    --cc=fengchengwen@huawei.com \
    --cc=ferruh.yigit@intel.com \
    --cc=humin29@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).