* [dpdk-dev] [PATCH] eal/rwlocks: Try read/write and relock write to read locks added.
@ 2018-05-21 9:08 Leonid Myravjev
2018-07-12 13:55 ` Thomas Monjalon
0 siblings, 1 reply; 3+ messages in thread
From: Leonid Myravjev @ 2018-05-21 9:08 UTC (permalink / raw)
To: dev; +Cc: Leonid Myravjev
From: Leonid Myravjev <myravjev@amicon.ru>
Signed-off-by: Leonid Myravjev <myravjev@amicon.ru>
---
lib/librte_eal/common/include/generic/rte_rwlock.h | 61 ++++++++++++++++++++++
1 file changed, 61 insertions(+)
diff --git a/lib/librte_eal/common/include/generic/rte_rwlock.h b/lib/librte_eal/common/include/generic/rte_rwlock.h
index 899e9bc43..11212e2b8 100644
--- a/lib/librte_eal/common/include/generic/rte_rwlock.h
+++ b/lib/librte_eal/common/include/generic/rte_rwlock.h
@@ -76,6 +76,30 @@ rte_rwlock_read_lock(rte_rwlock_t *rwl)
}
/**
+ * Try take lock a read lock.
+ *
+ * @param rwl
+ * A pointer to a rwlock structure.
+ * @return
+ * 1 if the lock is successfully taken; 0 otherwise.
+ */
+static inline int
+rte_rwlock_read_trylock(rte_rwlock_t *rwl)
+{
+ int32_t x;
+ int success = 0;
+
+ x = rwl->cnt;
+ /* write lock is held */
+ if (x < 0)
+ return 0;
+ success = rte_atomic32_cmpset((volatile uint32_t *)&rwl->cnt, x, x + 1);
+ if (success == 0)
+ return 0;
+ return 1;
+}
+
+/**
* Release a read lock.
*
* @param rwl
@@ -110,6 +134,29 @@ rte_rwlock_write_lock(rte_rwlock_t *rwl)
0, -1);
}
}
+/**
+ * Try take a write lock.
+ *
+ * @param rwl
+ * A pointer to a rwlock structure.
+ * @return
+ * 1 if the lock is successfully taken; 0 otherwise.
+ */
+static inline int
+rte_rwlock_write_trylock(rte_rwlock_t *rwl)
+{
+ int32_t x;
+ int success = 0;
+
+ x = rwl->cnt;
+ /* a lock is held */
+ if (x != 0)
+ return 0;
+ success = rte_atomic32_cmpset((volatile uint32_t *)&rwl->cnt, 0, -1);
+ if (success == 0)
+ return 0;
+ return 1;
+}
/**
* Release a write lock.
@@ -124,6 +171,20 @@ rte_rwlock_write_unlock(rte_rwlock_t *rwl)
}
/**
+ * Relock write lock to read
+ *
+ * @param rwl
+ * A pointer to a rwlock structure.
+ */
+static inline void
+rte_rwlock_write_relock_read(rte_rwlock_t *rwl)
+{
+ rte_atomic32_add((rte_atomic32_t *)(intptr_t)&rwl->cnt, 2);
+}
+
+
+
+/**
* Try to execute critical section in a hardware memory transaction, if it
* fails or not available take a read lock
*
--
2.13.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] eal/rwlocks: Try read/write and relock write to read locks added.
2018-05-21 9:08 [dpdk-dev] [PATCH] eal/rwlocks: Try read/write and relock write to read locks added Leonid Myravjev
@ 2018-07-12 13:55 ` Thomas Monjalon
2021-03-24 21:53 ` Thomas Monjalon
0 siblings, 1 reply; 3+ messages in thread
From: Thomas Monjalon @ 2018-07-12 13:55 UTC (permalink / raw)
To: Leonid Myravjev
Cc: dev, Leonid Myravjev, david.marchand, olivier.matz,
bruce.richardson, konstantin.ananyev, stephen
Hi,
Unfortunately, after 2 months, nobody reviewed this patch.
You could motivate some reviews by providing some explanations
or context of use.
21/05/2018 11:08, Leonid Myravjev:
> From: Leonid Myravjev <myravjev@amicon.ru>
>
> Signed-off-by: Leonid Myravjev <myravjev@amicon.ru>
> ---
> lib/librte_eal/common/include/generic/rte_rwlock.h | 61 ++++++++++++++++++++++
> 1 file changed, 61 insertions(+)
>
> diff --git a/lib/librte_eal/common/include/generic/rte_rwlock.h b/lib/librte_eal/common/include/generic/rte_rwlock.h
> index 899e9bc43..11212e2b8 100644
> --- a/lib/librte_eal/common/include/generic/rte_rwlock.h
> +++ b/lib/librte_eal/common/include/generic/rte_rwlock.h
> @@ -76,6 +76,30 @@ rte_rwlock_read_lock(rte_rwlock_t *rwl)
> }
>
> /**
> + * Try take lock a read lock.
> + *
> + * @param rwl
> + * A pointer to a rwlock structure.
> + * @return
> + * 1 if the lock is successfully taken; 0 otherwise.
> + */
> +static inline int
> +rte_rwlock_read_trylock(rte_rwlock_t *rwl)
> +{
> + int32_t x;
> + int success = 0;
> +
> + x = rwl->cnt;
> + /* write lock is held */
> + if (x < 0)
> + return 0;
> + success = rte_atomic32_cmpset((volatile uint32_t *)&rwl->cnt, x, x + 1);
> + if (success == 0)
> + return 0;
> + return 1;
> +}
> +
> +/**
> * Release a read lock.
> *
> * @param rwl
> @@ -110,6 +134,29 @@ rte_rwlock_write_lock(rte_rwlock_t *rwl)
> 0, -1);
> }
> }
> +/**
> + * Try take a write lock.
> + *
> + * @param rwl
> + * A pointer to a rwlock structure.
> + * @return
> + * 1 if the lock is successfully taken; 0 otherwise.
> + */
> +static inline int
> +rte_rwlock_write_trylock(rte_rwlock_t *rwl)
> +{
> + int32_t x;
> + int success = 0;
> +
> + x = rwl->cnt;
> + /* a lock is held */
> + if (x != 0)
> + return 0;
> + success = rte_atomic32_cmpset((volatile uint32_t *)&rwl->cnt, 0, -1);
> + if (success == 0)
> + return 0;
> + return 1;
> +}
>
> /**
> * Release a write lock.
> @@ -124,6 +171,20 @@ rte_rwlock_write_unlock(rte_rwlock_t *rwl)
> }
>
> /**
> + * Relock write lock to read
> + *
> + * @param rwl
> + * A pointer to a rwlock structure.
> + */
> +static inline void
> +rte_rwlock_write_relock_read(rte_rwlock_t *rwl)
> +{
> + rte_atomic32_add((rte_atomic32_t *)(intptr_t)&rwl->cnt, 2);
> +}
> +
> +
> +
> +/**
> * Try to execute critical section in a hardware memory transaction, if it
> * fails or not available take a read lock
> *
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] eal/rwlocks: Try read/write and relock write to read locks added.
2018-07-12 13:55 ` Thomas Monjalon
@ 2021-03-24 21:53 ` Thomas Monjalon
0 siblings, 0 replies; 3+ messages in thread
From: Thomas Monjalon @ 2021-03-24 21:53 UTC (permalink / raw)
To: Leonid Myravjev, Leonid Myravjev
Cc: dev, olivier.matz, bruce.richardson, konstantin.ananyev, stephen
Closing this proposal.
For reference, an implementation with test has been merged
2 years ago:
https://inbox.dpdk.org/dev/1542130061-3702-1-git-send-email-konstantin.ananyev@intel.com/
12/07/2018 15:55, Thomas Monjalon:
> Hi,
>
> Unfortunately, after 2 months, nobody reviewed this patch.
>
> You could motivate some reviews by providing some explanations
> or context of use.
>
>
> 21/05/2018 11:08, Leonid Myravjev:
> > From: Leonid Myravjev <myravjev@amicon.ru>
> >
> > Signed-off-by: Leonid Myravjev <myravjev@amicon.ru>
> > ---
> > lib/librte_eal/common/include/generic/rte_rwlock.h | 61 ++++++++++++++++++++++
> > 1 file changed, 61 insertions(+)
> >
> > diff --git a/lib/librte_eal/common/include/generic/rte_rwlock.h b/lib/librte_eal/common/include/generic/rte_rwlock.h
> > index 899e9bc43..11212e2b8 100644
> > --- a/lib/librte_eal/common/include/generic/rte_rwlock.h
> > +++ b/lib/librte_eal/common/include/generic/rte_rwlock.h
> > @@ -76,6 +76,30 @@ rte_rwlock_read_lock(rte_rwlock_t *rwl)
> > }
> >
> > /**
> > + * Try take lock a read lock.
> > + *
> > + * @param rwl
> > + * A pointer to a rwlock structure.
> > + * @return
> > + * 1 if the lock is successfully taken; 0 otherwise.
> > + */
> > +static inline int
> > +rte_rwlock_read_trylock(rte_rwlock_t *rwl)
> > +{
> > + int32_t x;
> > + int success = 0;
> > +
> > + x = rwl->cnt;
> > + /* write lock is held */
> > + if (x < 0)
> > + return 0;
> > + success = rte_atomic32_cmpset((volatile uint32_t *)&rwl->cnt, x, x + 1);
> > + if (success == 0)
> > + return 0;
> > + return 1;
> > +}
> > +
> > +/**
> > * Release a read lock.
> > *
> > * @param rwl
> > @@ -110,6 +134,29 @@ rte_rwlock_write_lock(rte_rwlock_t *rwl)
> > 0, -1);
> > }
> > }
> > +/**
> > + * Try take a write lock.
> > + *
> > + * @param rwl
> > + * A pointer to a rwlock structure.
> > + * @return
> > + * 1 if the lock is successfully taken; 0 otherwise.
> > + */
> > +static inline int
> > +rte_rwlock_write_trylock(rte_rwlock_t *rwl)
> > +{
> > + int32_t x;
> > + int success = 0;
> > +
> > + x = rwl->cnt;
> > + /* a lock is held */
> > + if (x != 0)
> > + return 0;
> > + success = rte_atomic32_cmpset((volatile uint32_t *)&rwl->cnt, 0, -1);
> > + if (success == 0)
> > + return 0;
> > + return 1;
> > +}
> >
> > /**
> > * Release a write lock.
> > @@ -124,6 +171,20 @@ rte_rwlock_write_unlock(rte_rwlock_t *rwl)
> > }
> >
> > /**
> > + * Relock write lock to read
> > + *
> > + * @param rwl
> > + * A pointer to a rwlock structure.
> > + */
> > +static inline void
> > +rte_rwlock_write_relock_read(rte_rwlock_t *rwl)
> > +{
> > + rte_atomic32_add((rte_atomic32_t *)(intptr_t)&rwl->cnt, 2);
> > +}
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-03-24 21:53 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-21 9:08 [dpdk-dev] [PATCH] eal/rwlocks: Try read/write and relock write to read locks added Leonid Myravjev
2018-07-12 13:55 ` Thomas Monjalon
2021-03-24 21:53 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).