From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6CA14A0C4D; Thu, 17 Jun 2021 08:41:53 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E3D994067A; Thu, 17 Jun 2021 08:41:52 +0200 (CEST) Received: from wout3-smtp.messagingengine.com (wout3-smtp.messagingengine.com [64.147.123.19]) by mails.dpdk.org (Postfix) with ESMTP id A0EF840150; Thu, 17 Jun 2021 08:41:51 +0200 (CEST) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.west.internal (Postfix) with ESMTP id C152AF4B; Thu, 17 Jun 2021 02:41:49 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Thu, 17 Jun 2021 02:41:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= MAf+gXgamv64Y7qlpN9AKDOjIfeXHdkw2hMxOKyptFI=; b=kIjBnerPyj519BxS o+kxmkCTQzCb7sNYjOx1Xm/ZXiw8S7xM/z9KZ/8cQ4BigtopRbeNNlcNF5yhMe5j anNCCHPpoVh7yLWknpV1cWEQ7wDdOIrcwlEt1e5EQlAE+OrFPDtafraOehKwwEzy lSWd8Lc5SwOxVeXqDNeah+ii8OXGctSODkjxkcBqLxm19Bj8MNlIMgYN7XlZhLvf LGM6y/vhtO19oz8yrtsIJK35Y5w5qdz7UAUx7irHeMuTWbZiWscRELOmaFmJI8yn uCA8Dz2PT+l2R7tmFbNK4OOdVkMmLzoPR6+KhykUwM605JkveczeVmBSL0/73Tnl dAtkow== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=MAf+gXgamv64Y7qlpN9AKDOjIfeXHdkw2hMxOKypt FI=; b=O36vW6nzQfSURPPy9FLpD2mkj8mreB7GjFE9VIy/1LUw7TKZPjjwLyI7t iFLLUf3KctydMAc/PGfR9jjSaUv2vF7O3QYR23b+X8VEp4N2wRtlpqr9otPVX7Fc XZyST/DV58c6C0zyzMfekssqiInDw85zPecZ/qQ69GNpfIK2hjaNUcBIQm+FUk6x S0gi00k2xO8ESRY2zbRQetNI9bSJgHZuNpzsBicWJmS5TmAnBg6jykgE24VABEFl 79ViJct7xBDEveo/QSSzarbfygX6d0cPmkuoSSBVmr7wt5zVlZehdug2FYWKrfqa TRiU5eMIhYIks4AqBoVEfJGZySLTw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrfeeftddguddtiecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpeegjeffhffhgefhteevffegffetleevkefhgffhfeegvdelueev teffgfduleevhfenucffohhmrghinhepghhithhhuhgsrdgtohhmnecuvehluhhsthgvrh fuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgr lhhonhdrnhgvth X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 17 Jun 2021 02:41:47 -0400 (EDT) From: Thomas Monjalon To: Ferruh Yigit , Christian Ehrhardt Cc: dev , dpdk stable , Thomas Bogendoerfer , "jcaamano@suse.com" , "snmohan83@gmail.com" , "ndas@suse.de" , Marco Varlese Date: Thu, 17 Jun 2021 08:41:44 +0200 Message-ID: <1708042.2qKnxoAoZE@thomas> In-Reply-To: References: <20210602143317.2333707-1-christian.ehrhardt@canonical.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] kni: fix compilation on SLES15-SP3 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 17/06/2021 08:14, Christian Ehrhardt: > On Thu, Jun 10, 2021 at 12:30 PM Christian Ehrhardt > wrote: > > On Thu, Jun 10, 2021 at 10:39 AM Christian Ehrhardt > > wrote: > > > On Tue, Jun 8, 2021 at 1:17 PM Ferruh Yigit wrote: > > > > On 6/2/2021 3:33 PM, Christian Ehrhardt wrote: > > > > > Like what was done for mainline kernel in commit 38ad54f3bc76 ("kni: fix > > > > > build with Linux 5.6"), a new parameter 'txqueue' has to be added to > > > > > 'ndo_tx_timeout' ndo on SLES 15-SP3 kernel. > > > > > > > > > > Caused by: > > > > > commit c3bf155c40e9db722feb8a08c19efd44c12d5294 > > > > > Author: Thomas Bogendoerfer > > > > > Date: Fri Sep 11 16:08:31 2020 +0200 > > > > > - netdev: pass the stuck queue to the timeout handler > > > > > (jsc#SLE-13536). > > > > > - Refresh patches.suse/sfc-move-various-functions.patch. > > > > > > > > > > That is part of the SLES 5.3.18 kernel and therefore the > > > > > version we check for. > > > > > > > > > > Cc: stable@dpdk.org > > > > > > > > > > Signed-off-by: Christian Ehrhardt > > > > > > > > Hi Christian, > > > > > > > > There is a build error reported in CI [1] with 'SUSE15-64'. > > > > Can't the check 'linux version >= 5.3.18" may hit multiple SUSE versions, with > > > > some has the patch mentioned above backported and some did not? > > > > Can 'SLE_VERSION_CODE' be used to differentiate the SUSE versions? > > > > > > I don't have a perfect insight in the SUSE distro variants and their > > > kernel versions. > > > > 5.3.18 in SLES15-SP3 was what broke it and I have hoped that this would apply in general. > > > But the error above seems we have others that are > 5.3.18 but at the > > > same time not have the backport. > > > > > > I'll try to create a v3, but do we have anyone from Suse to usually > > > directly ping for feedback on this? > > > > With the new version (not submitted since it fails me) you can have a > > look at my personal WIP branch: > > => https://github.com/cpaelzer/dpdk-stable-queue/commit/43b908fe83e9cd68b08e259c0ace26ec692bb737 > > Hello everyone, > Ferruh and I reached out to the Suse people working on DPDK in the > past as well as those doing the kernel backport that breaks it now. > (I'll add them to CC here as well) > Unfortunately there was no feedback in a week, but OTOH I also don't > want to stall releases for too long due to this. > > I'll try to summarize the current understanding of this case again > > [1] breaks our KNI build. > > SLE_VERSION isn't provided by their Kernel; it is in DPDKs > kernel/linux/kni/compat.h and not further maintained for a while. > So we can't differentiate SLE15SP2 vs SLE15SP3 via that. > > The offending change was introduced in their kernel by [1] > $ git tag --contains c3bf155c40e9 | sort | head > rpm-5.3.18-24 > ... > > But checking just the kernel version 5.3.18 (as my initial patch had) > won't work either. > The problem is that this only checks the three levels of kernel > version, but not the packaging level. > And to make things even more fun, while I don't know if opensuse leap > has the patch applied or not atm, but the kernel version there might > make this even more complex as it is 5.3.18-lp152 at the moment. > > We have now: > SLE15 SP2 5.3.18-22 > SLE15 SP3 5.3.18-57 (>=24) > opensuse_leap 5.3.18-lp152 > > Without a change SLE15SP3 is broken due to that backport. > By checking on >=5.3.18 we could fix SP3, but break SP2 and maybe opensuse_leap. > > Maybe there is something on LOCALVERSION/EXTRAVERSION we can use, but > "guessing" how the Suse kernel behaves isn't a good approach. > Once Suse lets us know how to better differentiate their packaging > version we can reconsider a proper fix for this. > > But without further input from Suse I'd (for now) ask to keep things > as is (= not applying my patch). > Due to that it will build in the same places it has built in the past. > If we find a solution it can be in the next release in ~3 months, but > I'll not further stall e.g. 19.11.9 that I'm working on right now. > > [1]: https://github.com/SUSE/kernel/commit/c3bf155c40e9 Thank you for the summary. This explains well why we should stop supporting KNI.