From: Thomas Monjalon <thomas@monjalon.net>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: dev@dpdk.org, Asaf Penso <asafp@mellanox.com>,
arybchenko@solarflare.com, viacheslavo@mellanox.com,
matan@mellanox.com, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v3] net/mlx5: add 200G link speed
Date: Wed, 06 May 2020 16:19:12 +0200 [thread overview]
Message-ID: <17084736.sWSEgdgrri@thomas> (raw)
In-Reply-To: <5403e39c-4abd-d0df-a8cc-18bdd4eaa672@intel.com>
06/05/2020 16:01, Ferruh Yigit:
> On 5/6/2020 2:17 PM, Thomas Monjalon wrote:
> > 06/05/2020 14:59, Ferruh Yigit:
> >> On 5/6/2020 1:22 PM, Asaf Penso wrote:
> >>> There is no way to report back a link speed of 200Gbps.
> >>>
> >>> Adding 200G link speed.
> >>>
> >>> Signed-off-by: Asaf Penso <asafp@mellanox.com>
> >>> ---
> >>> v2 - reword commit log and remove 400G
> >>>
> >>> v3 - rebase and fix checkpatch warning
> >>> ---
> >>> app/test-pmd/cmdline.c | 12 +++++++-----
> >>> doc/guides/rel_notes/release_20_05.rst | 2 ++
> >>> doc/guides/testpmd_app_ug/testpmd_funcs.rst | 2 +-
> >>> drivers/net/mlx5/mlx5_ethdev.c | 22 +++++++++++++++++++++-
> >>> lib/librte_ethdev/rte_ethdev.c | 2 ++
> >>> lib/librte_ethdev/rte_ethdev.h | 2 ++
> >>> 6 files changed, 35 insertions(+), 7 deletions(-)
> >>
> >> Hi Asaf,
> >>
> >> Patch looks good, but it updates ethdev & testpmd to have 200G defines and mlx5
> >> to use it, so net/mlx5 prefix not really fits to the patch, can you separate
> >> mlx5 changes into another patch?
> >
> > I think I was the one advising to squash all.
> > The reason is that the changes in testpmd and ethdev are
> > simple and mechanical.
> > The real change is in mlx5 in my opinion, but I'm fine with splitting as well.
> >
>
> Agree the real change is in the PMD and rest is mechanical, my concern was if we
> need to refer the ethdev or testpmd change later, we will need to use commit
> "net/mlx5: ..." which may be confusing.
>
> I think ethdev, testpmd & doc can be combined into one "ethdev: ..." and PMD
> implementation into other patch.
>
> Does it make sense?
Yes I understand your concern about future reference.
I am OK with what you propose:
1/ ethdev: add 200G link speed
2/ net/mlx5: support 200G link speed
next prev parent reply other threads:[~2020-05-06 14:19 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-21 13:44 [dpdk-dev] [PATCH] net/mlx5: add 200G and 400G " Asaf Penso
2020-04-22 16:29 ` Ajit Khaparde
2020-05-06 10:58 ` [dpdk-dev] [PATCH v2] net/mlx5: add 200G " Asaf Penso
2020-05-06 12:07 ` [dpdk-dev] [PATCH v3] " Asaf Penso
2020-05-06 13:43 ` Slava Ovsiienko
2020-05-06 12:22 ` Asaf Penso
2020-05-06 12:59 ` Ferruh Yigit
2020-05-06 13:17 ` Thomas Monjalon
2020-05-06 14:01 ` Ferruh Yigit
2020-05-06 14:19 ` Thomas Monjalon [this message]
2020-05-06 14:22 ` Ferruh Yigit
2020-05-06 14:23 ` Asaf Penso
2020-05-06 20:24 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=17084736.sWSEgdgrri@thomas \
--to=thomas@monjalon.net \
--cc=arybchenko@solarflare.com \
--cc=asafp@mellanox.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=matan@mellanox.com \
--cc=viacheslavo@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).