From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 04A86A034F; Wed, 6 May 2020 16:19:17 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 9208D1D96E; Wed, 6 May 2020 16:19:17 +0200 (CEST) Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 5D04C1D8DA for ; Wed, 6 May 2020 16:19:16 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id CF8A45C0081; Wed, 6 May 2020 10:19:15 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Wed, 06 May 2020 10:19:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= U4K1ANurWcivkmMdkFBcs5CzFt66qlhhvpbwoRPM1RQ=; b=Zmc7cg36kywzgRQ9 ef4Du286g3OyVzh3USWrYVJ6e5oxKeib+CoymlgtOjpkdGDDr08MKzMOl432IdHP kt54Ep+hTPOnLdd/KEHG5K/5VRlNfUAjceBgY41M3xnJa/KgLymjA7Ex4bbeOgAK vDxBbLYhXrPWaraSj7GPjcgiRzBVTqH79VFE6HwjLniCrqHrBc/kwi9Rl6CEpxdl lFr/PXoyPT6mrTcDLjtiYYKh8wId/ERiiTajl/Qa2tX1Ypfb2CPnlq12ISPgdp8o UcSh75le4qMmGMbjwqD4AmcfB7L60xmOW47f2zJo4ukCIQwJzTjwUKJbMIor3mb3 Pmml+Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=U4K1ANurWcivkmMdkFBcs5CzFt66qlhhvpbwoRPM1 RQ=; b=z+ceaBCy6AnzLZ5BpJIq6q3JslSuzr7UobnZhUnp29TYrvmJV+D/LG33Y NH9mgcJFR6/TjETkR8OfRil53lfHMnTE9MyMYsveaF3fr+bS2AhD8QLOT9as0KuH g9je8rdAeJpQzFSUmnPLjycBoYCDFKUcNHKI83U+N9ga1QB2nfpKfM4ygRVzgBaX XMxLC4rVETi8yY4BkFDfkDR//OiQK+x837ukkSsBqgZpWllvgp2k4KDqq70zgQLL XGWdGfxHO0kXatG1gR+SoL0hXnZ3l01P21nZgPKfj8r9tZPC//18T0qeznBLQCxp xs8a1RDyTN2/QtJ/VVqKXoDEB3JdQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrjeekgdejvdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdejueei iedvffegheenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuih iivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhho nhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 55A2E3066118; Wed, 6 May 2020 10:19:14 -0400 (EDT) From: Thomas Monjalon To: Ferruh Yigit Cc: dev@dpdk.org, Asaf Penso , arybchenko@solarflare.com, viacheslavo@mellanox.com, matan@mellanox.com, dev@dpdk.org Date: Wed, 06 May 2020 16:19:12 +0200 Message-ID: <17084736.sWSEgdgrri@thomas> In-Reply-To: <5403e39c-4abd-d0df-a8cc-18bdd4eaa672@intel.com> References: <1588762695-2489-1-git-send-email-asafp@mellanox.com> <1774318.eGJsNajkDb@thomas> <5403e39c-4abd-d0df-a8cc-18bdd4eaa672@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v3] net/mlx5: add 200G link speed X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 06/05/2020 16:01, Ferruh Yigit: > On 5/6/2020 2:17 PM, Thomas Monjalon wrote: > > 06/05/2020 14:59, Ferruh Yigit: > >> On 5/6/2020 1:22 PM, Asaf Penso wrote: > >>> There is no way to report back a link speed of 200Gbps. > >>> > >>> Adding 200G link speed. > >>> > >>> Signed-off-by: Asaf Penso > >>> --- > >>> v2 - reword commit log and remove 400G > >>> > >>> v3 - rebase and fix checkpatch warning > >>> --- > >>> app/test-pmd/cmdline.c | 12 +++++++----- > >>> doc/guides/rel_notes/release_20_05.rst | 2 ++ > >>> doc/guides/testpmd_app_ug/testpmd_funcs.rst | 2 +- > >>> drivers/net/mlx5/mlx5_ethdev.c | 22 +++++++++++++++++++++- > >>> lib/librte_ethdev/rte_ethdev.c | 2 ++ > >>> lib/librte_ethdev/rte_ethdev.h | 2 ++ > >>> 6 files changed, 35 insertions(+), 7 deletions(-) > >> > >> Hi Asaf, > >> > >> Patch looks good, but it updates ethdev & testpmd to have 200G defines and mlx5 > >> to use it, so net/mlx5 prefix not really fits to the patch, can you separate > >> mlx5 changes into another patch? > > > > I think I was the one advising to squash all. > > The reason is that the changes in testpmd and ethdev are > > simple and mechanical. > > The real change is in mlx5 in my opinion, but I'm fine with splitting as well. > > > > Agree the real change is in the PMD and rest is mechanical, my concern was if we > need to refer the ethdev or testpmd change later, we will need to use commit > "net/mlx5: ..." which may be confusing. > > I think ethdev, testpmd & doc can be combined into one "ethdev: ..." and PMD > implementation into other patch. > > Does it make sense? Yes I understand your concern about future reference. I am OK with what you propose: 1/ ethdev: add 200G link speed 2/ net/mlx5: support 200G link speed