From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id E4B5A160 for ; Mon, 15 Oct 2018 10:51:06 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 4BA2421FE0; Mon, 15 Oct 2018 04:51:05 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Mon, 15 Oct 2018 04:51:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=/qFEpVDS7DdjNOLkmbtkMsyBlJvfQ4yNBrQ5rueuXUI=; b=Pm03D8+8DGzX dHdzQifaKtFruC9skVtZx11LwzvS2ShddG0hAslc8YHzEDwHUUYZO9i1VL/U4Bj7 YxRjXzwZoZjom2l02SaOx00wW/Fv3hctvv9kZrmO2+q6Ozu2LVcsFGDz0tr9uhoq x8W0jwwbyU4/fRf/bA/E99WJ/1NedHs= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=/qFEpVDS7DdjNOLkmbtkMsyBlJvfQ4yNBrQ5rueuX UI=; b=RM3qK0AqEYp5+euuPyriuCn0juENAYUn9tGxRwyVYzSR7K3Jgn/d0KP9r iIsmzwIrENcfP6qXVIbe/gKZcqHrGRwkY2czjos7SCUFlFtrcQFK6DvynsWXwyOa Z+DJWWNBIum2NamLwIia9/iQ4CC5lnCSoBEr5yTtWv74ooD+xL2wrxzYKSzDQEfy Sbg2Rwmvrk6WfxQM3U3cMTqbdQ5vDQJqLab2z93ZqWS5/zTQdlNYQsK7+oKk+jG6 A50XisZSM6KTwkU/ppvQdDg/QibhSF8+AzU6Pv3sVwiWEB/P9rbGrBCmpu4OJ2q5 oeDPpDVG2Bkt+sU4mVbVWwp1g1ztQ== X-ME-Sender: X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id D8020E455F; Mon, 15 Oct 2018 04:51:03 -0400 (EDT) From: Thomas Monjalon To: dev@dpdk.org Cc: gaetan.rivet@6wind.com, ophirmu@mellanox.com, qi.z.zhang@intel.com, ferruh.yigit@intel.com, Declan Doherty Date: Mon, 15 Oct 2018 10:51:04 +0200 Message-ID: <1708821.o1i3cNID5q@xps> In-Reply-To: <20181014204747.26621-4-thomas@monjalon.net> References: <20180907230958.21402-1-thomas@monjalon.net> <20181014204747.26621-1-thomas@monjalon.net> <20181014204747.26621-4-thomas@monjalon.net> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v5 3/7] cryptodev: remove driver name from logs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Oct 2018 08:51:07 -0000 +Cc Declan 14/10/2018 22:47, Thomas Monjalon: > The logs printed by CDEV_LOG_* were prefixed with the driver name. > > In order to avoid assigning the driver before the end of the probing, > the driver name is removed from the cryptodev library logs. > > Signed-off-by: Thomas Monjalon > --- > lib/librte_cryptodev/rte_cryptodev_pmd.c | 23 ++++++++--------------- > 1 file changed, 8 insertions(+), 15 deletions(-) > > diff --git a/lib/librte_cryptodev/rte_cryptodev_pmd.c b/lib/librte_cryptodev/rte_cryptodev_pmd.c > index 2088ac3f3..f03bdbd5e 100644 > --- a/lib/librte_cryptodev/rte_cryptodev_pmd.c > +++ b/lib/librte_cryptodev/rte_cryptodev_pmd.c > @@ -93,24 +93,20 @@ rte_cryptodev_pmd_create(const char *name, > struct rte_cryptodev *cryptodev; > > if (params->name[0] != '\0') { > - CDEV_LOG_INFO("[%s] User specified device name = %s\n", > - device->driver->name, params->name); > + CDEV_LOG_INFO("User specified device name = %s\n", params->name); > name = params->name; > } > > - CDEV_LOG_INFO("[%s] - Creating cryptodev %s\n", > - device->driver->name, name); > + CDEV_LOG_INFO("Creating cryptodev %s\n", name); > > - CDEV_LOG_INFO("[%s] - Initialisation parameters - name: %s," > + CDEV_LOG_INFO("Initialisation parameters - name: %s," > "socket id: %d, max queue pairs: %u", > - device->driver->name, name, > - params->socket_id, params->max_nb_queue_pairs); > + name, params->socket_id, params->max_nb_queue_pairs); > > /* allocate device structure */ > cryptodev = rte_cryptodev_pmd_allocate(name, params->socket_id); > if (cryptodev == NULL) { > - CDEV_LOG_ERR("[%s] Failed to allocate crypto device for %s", > - device->driver->name, name); > + CDEV_LOG_ERR("Failed to allocate crypto device for %s", name); > return NULL; > } > > @@ -123,9 +119,8 @@ rte_cryptodev_pmd_create(const char *name, > params->socket_id); > > if (cryptodev->data->dev_private == NULL) { > - CDEV_LOG_ERR("[%s] Cannot allocate memory for " > - "cryptodev %s private data", > - device->driver->name, name); > + CDEV_LOG_ERR("Cannot allocate memory for cryptodev %s" > + " private data", name); > > rte_cryptodev_pmd_release_device(cryptodev); > return NULL; > @@ -145,9 +140,7 @@ rte_cryptodev_pmd_destroy(struct rte_cryptodev *cryptodev) > { > int retval; > > - CDEV_LOG_INFO("[%s] Closing crypto device %s", > - cryptodev->device->driver->name, > - cryptodev->device->name); > + CDEV_LOG_INFO("Closing crypto device %s", cryptodev->device->name); > > /* free crypto device */ > retval = rte_cryptodev_pmd_release_device(cryptodev); >