From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from new4-smtp.messagingengine.com (new4-smtp.messagingengine.com [66.111.4.230]) by dpdk.org (Postfix) with ESMTP id 72E2C1B478 for ; Sun, 21 Apr 2019 23:10:37 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailnew.nyi.internal (Postfix) with ESMTP id 5645311118; Sun, 21 Apr 2019 17:10:36 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Sun, 21 Apr 2019 17:10:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=1sfBlbUYSyb+VN5lkx6ckDWgzsK8diEzoZdhiwuplX8=; b=JU0rjhhvW4wN NY0YKZApAF2/3Pj7o+9x/TiEQ0LhgXiruUnTWuQQU3IzUWcw9sPE8uGKr/L1k9Ao DM4HmKBDmQo1gMmKgNDRCYTDAf6NjWM8Y6ZCD4bJAZJSQi1jyY0pATrR+9k1yIIM Lcykw1/snT+8PmrskSPg14SiD/BJJR0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=1sfBlbUYSyb+VN5lkx6ckDWgzsK8diEzoZdhiwupl X8=; b=6JH3NVIeF5RfXphBbfZ2sZHmcsJjcOIGheAlt2YeHa2+gRLJiduzU0uBg fKs8526hAxDdAL8TAd9rIXcb/AKVkQLXPOHholHffnNPunax6/ImTn8RapvGc70S U2Y/DXAR3RTERivrt50b+RYHRfgoioFBS6h7AcG1rlIEVt/6eXO8voaCL7cKJYYL 2ezqSWp8I+QIyOzBtslRGlSEyzoIi969U/SG4mZsAZbfEj2x6iF11frPSCwfUFjw D+xyl/4gnBEXyP9cXodOymFElv9vAceTsIZjrLFjHKxR47X98dIgBSsCH3IOGw0b mWQua1EvH5yJIjNh1gyjtctKcc33g== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrgeeggddufeefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecukf hppeeltddrvdelrdduheekrdduheelnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhho mhgrshesmhhonhhjrghlohhnrdhnvghtnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (alyon-655-1-477-159.w90-29.abo.wanadoo.fr [90.29.158.159]) by mail.messagingengine.com (Postfix) with ESMTPA id D75BF10316; Sun, 21 Apr 2019 17:10:32 -0400 (EDT) From: Thomas Monjalon To: Arnon Warshavsky Cc: dev@dpdk.org, "Burakov, Anatoly" , "Lu, Wenzhuo" , "Doherty, Declan" , Jerin Jacob , Bruce Richardson , "Yigit, Ferruh" , ranjit.menon@intel.com, anand.rawat@intel.com, Pallavi Kadam , Harini Ramakrishnan , "O'Hare, Cathal" Date: Sun, 21 Apr 2019 23:10:30 +0200 Message-ID: <1708848.QKHxId02lC@xps> In-Reply-To: References: <1524552123-31378-1-git-send-email-arnon@qwilt.com> <3131803.2ETXjPmY0d@xps> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v6 00/11] al: replace calls to rte_panic and refrain from new instances X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 21 Apr 2019 21:10:37 -0000 21/04/2019 21:16, Arnon Warshavsky: > Hi, > I should be able to address this for 19.08, at least the straight forward > parts. > I need to touch base again with this patchset later this week, > to see what changed since then, and see what deprecation notices are > required. > I would like to address the ones that are a direct part of the > initialization sequence, > and mostly change functions and their callers from void to return a value > that propagates upwards. > The 2nd kind under lib that I wanted to remove at the time are the ones > that live in threads and I would not like to handle them now. > Given a 3rd kind that is found inside PMDs that may panic during callbacks, > the former poses a similar challenge of managing the device state after a > panic event which is not trivial, > and tmho deserves either a separate patchset or a defeat recognition. > > In this respect , In addition to removing the ones from the initialization > sequence, > I would like to revive my original proposal to add a callback registration > to the panic event. > As I do not expect all the PMD callback panics to disappear completely, > I still need to allow the running process to do some kind of orderly > tear-down to other modules when possible. > > Does this sound ok for 19.08? That would be great to get some progress in 19.08. Do not hesitate to split in several patchsets, getting easy ones first and open discussions other ones. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 1C205A05D3 for ; Sun, 21 Apr 2019 23:10:39 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 02E4F1B4C0; Sun, 21 Apr 2019 23:10:38 +0200 (CEST) Received: from new4-smtp.messagingengine.com (new4-smtp.messagingengine.com [66.111.4.230]) by dpdk.org (Postfix) with ESMTP id 72E2C1B478 for ; Sun, 21 Apr 2019 23:10:37 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailnew.nyi.internal (Postfix) with ESMTP id 5645311118; Sun, 21 Apr 2019 17:10:36 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Sun, 21 Apr 2019 17:10:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=1sfBlbUYSyb+VN5lkx6ckDWgzsK8diEzoZdhiwuplX8=; b=JU0rjhhvW4wN NY0YKZApAF2/3Pj7o+9x/TiEQ0LhgXiruUnTWuQQU3IzUWcw9sPE8uGKr/L1k9Ao DM4HmKBDmQo1gMmKgNDRCYTDAf6NjWM8Y6ZCD4bJAZJSQi1jyY0pATrR+9k1yIIM Lcykw1/snT+8PmrskSPg14SiD/BJJR0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=1sfBlbUYSyb+VN5lkx6ckDWgzsK8diEzoZdhiwupl X8=; b=6JH3NVIeF5RfXphBbfZ2sZHmcsJjcOIGheAlt2YeHa2+gRLJiduzU0uBg fKs8526hAxDdAL8TAd9rIXcb/AKVkQLXPOHholHffnNPunax6/ImTn8RapvGc70S U2Y/DXAR3RTERivrt50b+RYHRfgoioFBS6h7AcG1rlIEVt/6eXO8voaCL7cKJYYL 2ezqSWp8I+QIyOzBtslRGlSEyzoIi969U/SG4mZsAZbfEj2x6iF11frPSCwfUFjw D+xyl/4gnBEXyP9cXodOymFElv9vAceTsIZjrLFjHKxR47X98dIgBSsCH3IOGw0b mWQua1EvH5yJIjNh1gyjtctKcc33g== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrgeeggddufeefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecukf hppeeltddrvdelrdduheekrdduheelnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhho mhgrshesmhhonhhjrghlohhnrdhnvghtnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (alyon-655-1-477-159.w90-29.abo.wanadoo.fr [90.29.158.159]) by mail.messagingengine.com (Postfix) with ESMTPA id D75BF10316; Sun, 21 Apr 2019 17:10:32 -0400 (EDT) From: Thomas Monjalon To: Arnon Warshavsky Cc: dev@dpdk.org, "Burakov, Anatoly" , "Lu, Wenzhuo" , "Doherty, Declan" , Jerin Jacob , Bruce Richardson , "Yigit, Ferruh" , ranjit.menon@intel.com, anand.rawat@intel.com, Pallavi Kadam , Harini Ramakrishnan , "O'Hare, Cathal" Date: Sun, 21 Apr 2019 23:10:30 +0200 Message-ID: <1708848.QKHxId02lC@xps> In-Reply-To: References: <1524552123-31378-1-git-send-email-arnon@qwilt.com> <3131803.2ETXjPmY0d@xps> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v6 00/11] al: replace calls to rte_panic and refrain from new instances X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190421211030.rNX5Zm29u-TxhJ0Un-qwBYgfW-Fqyb6cAGpc8nmJjRU@z> 21/04/2019 21:16, Arnon Warshavsky: > Hi, > I should be able to address this for 19.08, at least the straight forward > parts. > I need to touch base again with this patchset later this week, > to see what changed since then, and see what deprecation notices are > required. > I would like to address the ones that are a direct part of the > initialization sequence, > and mostly change functions and their callers from void to return a value > that propagates upwards. > The 2nd kind under lib that I wanted to remove at the time are the ones > that live in threads and I would not like to handle them now. > Given a 3rd kind that is found inside PMDs that may panic during callbacks, > the former poses a similar challenge of managing the device state after a > panic event which is not trivial, > and tmho deserves either a separate patchset or a defeat recognition. > > In this respect , In addition to removing the ones from the initialization > sequence, > I would like to revive my original proposal to add a callback registration > to the panic event. > As I do not expect all the PMD callback panics to disappear completely, > I still need to allow the running process to do some kind of orderly > tear-down to other modules when possible. > > Does this sound ok for 19.08? That would be great to get some progress in 19.08. Do not hesitate to split in several patchsets, getting easy ones first and open discussions other ones.