From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id F333D43C5A; Wed, 6 Mar 2024 21:14:09 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9CDBE42E6F; Wed, 6 Mar 2024 21:14:01 +0100 (CET) Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mails.dpdk.org (Postfix) with ESMTP id 94C05427E9 for ; Wed, 6 Mar 2024 21:13:58 +0100 (CET) Received: by linux.microsoft.com (Postfix, from userid 1086) id E77F320B74C4; Wed, 6 Mar 2024 12:13:57 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com E77F320B74C4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1709756037; bh=C4ChNHoTZjDU7zaHOjsbjq3hGdbyETRhoART1yeyAbs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=i6LgHlGBbj3qukPx5g1op70wkVosCQ+Swn7ODBuQ4MuV20N7osAXlrBp/c+raLp/n pEi9uWLomLuHKdiPHLWYKxBEQ/Yl755GtPDgLYnK443NNbJRGmDz7tPFalF+EYf9/a Gu6vW2gAcp8T2mc8WlOxN3TS5iYcy4rzXqasZUY8= From: Tyler Retzlaff To: dev@dpdk.org Cc: Bruce Richardson , Cristian Dumitrescu , Honnappa Nagarahalli , Sameh Gobriel , Vladimir Medvedkin , Yipeng Wang , mb@smartsharesystems.com, fengchengwen@huawei.com, Tyler Retzlaff Subject: [PATCH v5 4/6] pipeline: replace zero length array with flex array Date: Wed, 6 Mar 2024 12:13:54 -0800 Message-Id: <1709756036-24068-5-git-send-email-roretzla@linux.microsoft.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1709756036-24068-1-git-send-email-roretzla@linux.microsoft.com> References: <1706134657-17446-1-git-send-email-roretzla@linux.microsoft.com> <1709756036-24068-1-git-send-email-roretzla@linux.microsoft.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Zero length arrays are GNU extension. Replace with standard flex array. Add a temporary suppression for rte_pipeline_table_entry libabigail bug: Bugzilla ID: https://sourceware.org/bugzilla/show_bug.cgi?id=31377 Signed-off-by: Tyler Retzlaff Reviewed-by: Morten Brørup Acked-by: Stephen Hemminger --- devtools/libabigail.abignore | 2 ++ lib/pipeline/rte_pipeline.h | 2 +- lib/pipeline/rte_port_in_action.c | 2 +- 3 files changed, 4 insertions(+), 2 deletions(-) diff --git a/devtools/libabigail.abignore b/devtools/libabigail.abignore index 25c73a5..5292b63 100644 --- a/devtools/libabigail.abignore +++ b/devtools/libabigail.abignore @@ -33,6 +33,8 @@ ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;; ; Temporary exceptions till next major ABI version ; ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;; +[suppress_type] + name = rte_pipeline_table_entry [suppress_type] name = rte_rcu_qsbr diff --git a/lib/pipeline/rte_pipeline.h b/lib/pipeline/rte_pipeline.h index ec51b9b..0c7994b 100644 --- a/lib/pipeline/rte_pipeline.h +++ b/lib/pipeline/rte_pipeline.h @@ -220,7 +220,7 @@ struct rte_pipeline_table_entry { uint32_t table_id; }; /** Start of table entry area for user defined actions and meta-data */ - __extension__ uint8_t action_data[0]; + uint8_t action_data[]; }; /** diff --git a/lib/pipeline/rte_port_in_action.c b/lib/pipeline/rte_port_in_action.c index bbacaff..4127bd2 100644 --- a/lib/pipeline/rte_port_in_action.c +++ b/lib/pipeline/rte_port_in_action.c @@ -283,7 +283,7 @@ struct rte_port_in_action_profile * struct rte_port_in_action { struct ap_config cfg; struct ap_data data; - alignas(RTE_CACHE_LINE_SIZE) uint8_t memory[0]; + alignas(RTE_CACHE_LINE_SIZE) uint8_t memory[]; }; static __rte_always_inline void * -- 1.8.3.1