* [dpdk-dev] [PATCH] ixgbe: Fix vf tx issue
@ 2015-03-02 6:36 Ouyang Changchun
2015-03-02 12:25 ` [dpdk-dev] [PATCH v2] " Ouyang Changchun
0 siblings, 1 reply; 4+ messages in thread
From: Ouyang Changchun @ 2015-03-02 6:36 UTC (permalink / raw)
To: dev
X550 should use the correct macro to set the VFTDT and VFRDT register address.
This patch fixes the VF TX issue for Sageville.
Signed-off-by: Changchun Ouyang <changchun.ouyang@intel.com>
---
lib/librte_pmd_ixgbe/ixgbe_rxtx.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/lib/librte_pmd_ixgbe/ixgbe_rxtx.c b/lib/librte_pmd_ixgbe/ixgbe_rxtx.c
index 3059375..ae1ea64 100644
--- a/lib/librte_pmd_ixgbe/ixgbe_rxtx.c
+++ b/lib/librte_pmd_ixgbe/ixgbe_rxtx.c
@@ -1935,7 +1935,8 @@ ixgbe_dev_tx_queue_setup(struct rte_eth_dev *dev,
* Modification to set VFTDT for virtual function if vf is detected
*/
if (hw->mac.type == ixgbe_mac_82599_vf ||
- hw->mac.type == ixgbe_mac_X540_vf)
+ hw->mac.type == ixgbe_mac_X540_vf ||
+ hw->mac.type == ixgbe_mac_X550_vf)
txq->tdt_reg_addr = IXGBE_PCI_REG_ADDR(hw, IXGBE_VFTDT(queue_idx));
else
txq->tdt_reg_addr = IXGBE_PCI_REG_ADDR(hw, IXGBE_TDT(txq->reg_idx));
@@ -2200,7 +2201,8 @@ ixgbe_dev_rx_queue_setup(struct rte_eth_dev *dev,
* Modified to setup VFRDT for Virtual Function
*/
if (hw->mac.type == ixgbe_mac_82599_vf ||
- hw->mac.type == ixgbe_mac_X540_vf) {
+ hw->mac.type == ixgbe_mac_X540_vf ||
+ hw->mac.type == ixgbe_mac_X550_vf) {
rxq->rdt_reg_addr =
IXGBE_PCI_REG_ADDR(hw, IXGBE_VFRDT(queue_idx));
rxq->rdh_reg_addr =
--
1.8.4.2
^ permalink raw reply [flat|nested] 4+ messages in thread* [dpdk-dev] [PATCH v2] ixgbe: Fix vf tx issue
2015-03-02 6:36 [dpdk-dev] [PATCH] ixgbe: Fix vf tx issue Ouyang Changchun
@ 2015-03-02 12:25 ` Ouyang Changchun
2015-03-06 3:46 ` Liang, Cunming
0 siblings, 1 reply; 4+ messages in thread
From: Ouyang Changchun @ 2015-03-02 12:25 UTC (permalink / raw)
To: dev
X550 should use the correct macro to set the VFTDT and VFRDT register address.
This patch fixes the VF TX issue for Sageville.
Signed-off-by: Changchun Ouyang <changchun.ouyang@intel.com>
---
Change in v2
-- Fix one more mac type: ixgbe_mac_X550EM_x_vf.
lib/librte_pmd_ixgbe/ixgbe_rxtx.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/lib/librte_pmd_ixgbe/ixgbe_rxtx.c b/lib/librte_pmd_ixgbe/ixgbe_rxtx.c
index 3059375..9217cbe 100644
--- a/lib/librte_pmd_ixgbe/ixgbe_rxtx.c
+++ b/lib/librte_pmd_ixgbe/ixgbe_rxtx.c
@@ -1935,7 +1935,9 @@ ixgbe_dev_tx_queue_setup(struct rte_eth_dev *dev,
* Modification to set VFTDT for virtual function if vf is detected
*/
if (hw->mac.type == ixgbe_mac_82599_vf ||
- hw->mac.type == ixgbe_mac_X540_vf)
+ hw->mac.type == ixgbe_mac_X540_vf ||
+ hw->mac.type == ixgbe_mac_X550_vf ||
+ hw->mac.type == ixgbe_mac_X550EM_x_vf)
txq->tdt_reg_addr = IXGBE_PCI_REG_ADDR(hw, IXGBE_VFTDT(queue_idx));
else
txq->tdt_reg_addr = IXGBE_PCI_REG_ADDR(hw, IXGBE_TDT(txq->reg_idx));
@@ -2200,7 +2202,9 @@ ixgbe_dev_rx_queue_setup(struct rte_eth_dev *dev,
* Modified to setup VFRDT for Virtual Function
*/
if (hw->mac.type == ixgbe_mac_82599_vf ||
- hw->mac.type == ixgbe_mac_X540_vf) {
+ hw->mac.type == ixgbe_mac_X540_vf ||
+ hw->mac.type == ixgbe_mac_X550_vf ||
+ hw->mac.type == ixgbe_mac_X550EM_x_vf) {
rxq->rdt_reg_addr =
IXGBE_PCI_REG_ADDR(hw, IXGBE_VFRDT(queue_idx));
rxq->rdh_reg_addr =
--
1.8.4.2
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [dpdk-dev] [PATCH v2] ixgbe: Fix vf tx issue
2015-03-02 12:25 ` [dpdk-dev] [PATCH v2] " Ouyang Changchun
@ 2015-03-06 3:46 ` Liang, Cunming
2015-03-09 8:18 ` Thomas Monjalon
0 siblings, 1 reply; 4+ messages in thread
From: Liang, Cunming @ 2015-03-06 3:46 UTC (permalink / raw)
To: Ouyang Changchun; +Cc: dev
Hi,
On 3/2/2015 8:25 PM, Ouyang Changchun wrote:
> X550 should use the correct macro to set the VFTDT and VFRDT register address.
> This patch fixes the VF TX issue for Sageville.
>
> Signed-off-by: Changchun Ouyang <changchun.ouyang@intel.com>
> ---
>
> Change in v2
> -- Fix one more mac type: ixgbe_mac_X550EM_x_vf.
>
> lib/librte_pmd_ixgbe/ixgbe_rxtx.c | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/lib/librte_pmd_ixgbe/ixgbe_rxtx.c b/lib/librte_pmd_ixgbe/ixgbe_rxtx.c
> index 3059375..9217cbe 100644
> --- a/lib/librte_pmd_ixgbe/ixgbe_rxtx.c
> +++ b/lib/librte_pmd_ixgbe/ixgbe_rxtx.c
> @@ -1935,7 +1935,9 @@ ixgbe_dev_tx_queue_setup(struct rte_eth_dev *dev,
> * Modification to set VFTDT for virtual function if vf is detected
> */
> if (hw->mac.type == ixgbe_mac_82599_vf ||
> - hw->mac.type == ixgbe_mac_X540_vf)
> + hw->mac.type == ixgbe_mac_X540_vf ||
> + hw->mac.type == ixgbe_mac_X550_vf ||
> + hw->mac.type == ixgbe_mac_X550EM_x_vf)
> txq->tdt_reg_addr = IXGBE_PCI_REG_ADDR(hw, IXGBE_VFTDT(queue_idx));
> else
> txq->tdt_reg_addr = IXGBE_PCI_REG_ADDR(hw, IXGBE_TDT(txq->reg_idx));
> @@ -2200,7 +2202,9 @@ ixgbe_dev_rx_queue_setup(struct rte_eth_dev *dev,
> * Modified to setup VFRDT for Virtual Function
> */
> if (hw->mac.type == ixgbe_mac_82599_vf ||
> - hw->mac.type == ixgbe_mac_X540_vf) {
> + hw->mac.type == ixgbe_mac_X540_vf ||
> + hw->mac.type == ixgbe_mac_X550_vf ||
> + hw->mac.type == ixgbe_mac_X550EM_x_vf) {
> rxq->rdt_reg_addr =
> IXGBE_PCI_REG_ADDR(hw, IXGBE_VFRDT(queue_idx));
> rxq->rdh_reg_addr =
Acked-by:Cunming Liang <cunming.liang@intel.com
<mailto:cunming.liang@intel.com>>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [dpdk-dev] [PATCH v2] ixgbe: Fix vf tx issue
2015-03-06 3:46 ` Liang, Cunming
@ 2015-03-09 8:18 ` Thomas Monjalon
0 siblings, 0 replies; 4+ messages in thread
From: Thomas Monjalon @ 2015-03-09 8:18 UTC (permalink / raw)
To: Ouyang Changchun; +Cc: dev
> > X550 should use the correct macro to set the VFTDT and VFRDT register address.
> > This patch fixes the VF TX issue for Sageville.
> >
> > Signed-off-by: Changchun Ouyang <changchun.ouyang@intel.com>
>
> Acked-by:Cunming Liang <cunming.liang@intel.com
> <mailto:cunming.liang@intel.com>>
Applied, thanks
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-03-09 11:50 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-03-02 6:36 [dpdk-dev] [PATCH] ixgbe: Fix vf tx issue Ouyang Changchun
2015-03-02 12:25 ` [dpdk-dev] [PATCH v2] " Ouyang Changchun
2015-03-06 3:46 ` Liang, Cunming
2015-03-09 8:18 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).