From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2F178A0032; Fri, 18 Feb 2022 11:52:35 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BF30740150; Fri, 18 Feb 2022 11:52:34 +0100 (CET) Received: from wout3-smtp.messagingengine.com (wout3-smtp.messagingengine.com [64.147.123.19]) by mails.dpdk.org (Postfix) with ESMTP id 2453840141 for ; Fri, 18 Feb 2022 11:52:34 +0100 (CET) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id AD70C3201061; Fri, 18 Feb 2022 05:52:30 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Fri, 18 Feb 2022 05:52:31 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; bh=rWbArQzWShTPtG edyeKU4c5nCehGLOvKNouCJ0vdcrM=; b=bIcIQs8UEJ96eHEmAGARJo3X64qwoc tvTAJyiE32N3e7DGk2JXUWxXaj/dyjzBgjcb1VtewiQBXHLtk2Rhzk+pCN2xVPIz j5ioN1jnuImTKh6Jxy1kNQqRh8x64rqunQbmXIaeOW+yTPGqWvUxUGRK7D4a3qgy fJcZMh4oGmKkuILHOVty/t36NTLcE1tAH7j/uCo0PpGF5tHtDUVILKNlDpDJ/4u1 ioSUuBLj0iDw45wFa3qJ9d2q9MGijsnu/QVT7qFGEVXRsaROU0fNDMY4In5wKqCg BMSy0l1VmpgjfkzrPEYv2rdwVWIj3hOC4Z6MbgjdXYCQD9SUnG0BWXdg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=rWbArQzWShTPtGedyeKU4c5nCehGLOvKNouCJ0vdc rM=; b=mJPB6rM9/pDRGmYQWmFsL5l57edzkqMDVLyAtXAWoFRJ+vZSdTkbecy4G B7f5K0TpcTHWV0U+pP+Pd7zx1Tdlom8Mlq6iRRiLbOrBfdfEm+niK5tU17DKcTtu agKhXUtEgbL2XSI3mVy3PYMPB6PwzrZ1CCw4rODklFQLUvqKUPczr4Nx7d0WUbJL RvNz4BN8Aj+7wwhAArpwWVfLNYZqdH77YKBqpeGejaFeXa3AYqa8dVv0S+nywPHW AVzOe4sQxoSwojVYzuRR838/asrAY2RBEUQoZw8VBgU+wC7E0LGoX9l5WY1Yq+lS z7UoJEJjT4WCZ/1lEWnSQ75zugN8w== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrkedtgddulecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdejueei iedvffegheenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhroh hmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 18 Feb 2022 05:52:29 -0500 (EST) From: Thomas Monjalon To: Megha Ajmera Cc: dev@dpdk.org, jasvinder.singh@intel.com, cristian.dumitrescu@intel.com, david.marchand@redhat.com Subject: Re: [PATCH v2 1/4] sched: Cleanup qos scheduler defines from rte_config Date: Fri, 18 Feb 2022 11:52:27 +0100 Message-ID: <1712219.4herOUoSWf@thomas> In-Reply-To: <20220218093650.2549927-2-megha.ajmera@intel.com> References: <20220218093650.2549927-1-megha.ajmera@intel.com> <20220218093650.2549927-2-megha.ajmera@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 18/02/2022 10:36, Megha Ajmera: > Cleanup of sched config options those are by-default not defined. > > Signed-off-by: Megha Ajmera > Acked-by: Cristian Dumitrescu > --- > config/rte_config.h | 8 ++------ > doc/guides/sample_app_ug/qos_scheduler.rst | 3 +-- > lib/sched/rte_sched.c | 4 ++++ > 3 files changed, 7 insertions(+), 8 deletions(-) > > diff --git a/config/rte_config.h b/config/rte_config.h > index 91d96eeecb..917097630e 100644 > --- a/config/rte_config.h > +++ b/config/rte_config.h > @@ -88,12 +88,8 @@ > /* rte_power defines */ > #define RTE_MAX_LCORE_FREQS 64 > > -/* rte_sched defines */ > -#undef RTE_SCHED_CMAN So what is the purpose of the code under RTE_SCHED_CMAN #ifdef? Is it a dead code? Should it be enabled with a hidden option? > -#undef RTE_SCHED_COLLECT_STATS RTE_SCHED_COLLECT_STATS should be removed from config in the same patch removing the #ifdef in the code. > -#undef RTE_SCHED_SUBPORT_TC_OV RTE_SCHED_SUBPORT_TC_OV should be removed from config in the same patch removing the #ifdef in the code. > -#define RTE_SCHED_PORT_N_GRINDERS 8 > -#undef RTE_SCHED_VECTOR RTE_SCHED_VECTOR should be removed while removing code in patch 4. Maybe start the series with patch 4. A good cleanup series starts with removing useless code. While removing, you should justify in the commit log why it is useless. > +/* KNI defines */ > +#define RTE_KNI_PREEMPT_DEFAULT 1 The KNI addition is unrelated. > > /* rte_graph defines */ > #define RTE_GRAPH_BURST_SIZE 256 > diff --git a/doc/guides/sample_app_ug/qos_scheduler.rst b/doc/guides/sample_app_ug/qos_scheduler.rst > index 49c14a00da..7016ca4078 100644 > --- a/doc/guides/sample_app_ug/qos_scheduler.rst > +++ b/doc/guides/sample_app_ug/qos_scheduler.rst > @@ -42,8 +42,7 @@ The application is located in the ``qos_sched`` sub-directory. > .. note:: > > To get statistics on the sample app using the command line interface as described in the next section, > - DPDK must be compiled defining *RTE_SCHED_COLLECT_STATS*, which can be done by changing the relevant > - entry in the ``config/rte_config.h`` file. > + DPDK must be compiled after defining *RTE_SCHED_COLLECT_STATS* in the ``config/rte_config.h`` file. No we should not modify rte_config.h It should be modified via CFLAGS. > +#ifndef RTE_SCHED_PORT_N_GRINDERS > +#define RTE_SCHED_PORT_N_GRINDERS 8 > +#endif Do you expect users to modify it? Given the #ifndef, it seems yes. So you should document it with CFLAGS.