From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f44.google.com (mail-wm0-f44.google.com [74.125.82.44]) by dpdk.org (Postfix) with ESMTP id 6D7E72C49 for ; Mon, 21 Mar 2016 14:24:38 +0100 (CET) Received: by mail-wm0-f44.google.com with SMTP id l68so121783736wml.1 for ; Mon, 21 Mar 2016 06:24:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=Ov4ZNKrSPyQOVfOuFNd9QjEYda68FSrYo5NeoXPXlrQ=; b=ZOoOCfl5KneCYewaedkWJ6rEbmh1s4IyGA0jganS1w2iraGjHPfOu5fvMKCM8/HLgU 8LeDs8hyGgNPDNfcO4usCq8ckHAWywnV1V92c+C1TApvMs681okXEA4KXGOhvF0+Yl3w k0LxRMqqpAB0vd71dAFZgHryW/cVrYhihWLWgJ/ZdAPkJvezEPWEA797y3htsQMKTTuB ncWgxhHRkUwfQ9aqncTITuXqjbObudH/8vIUXEBw3Q1PdP0EqeC0F/O3ozQWFEnOJOeQ hTTThvsjFqfn6VtoTccpIy/chpKGTXohjrvUPFNmvSmKHei7ST9xCJQo1+sITHiBIty6 lcmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding; bh=Ov4ZNKrSPyQOVfOuFNd9QjEYda68FSrYo5NeoXPXlrQ=; b=mnk9KwF2+uBKPpHhoOr0es8/pPy/k43NccGSxauXVEYS5X12PdZawAomo/cH3ld1vr 4McqoQGCzA3VuCB4el2b2lATe3R+GvY0hGMPmm8j70LUWO7O3vac/t0OauxpN5VVT+Ow aE+eqvPJPZbgiQBSIr0Eh5QMqmVh5QIcNRzGVojUImQQF2c9eUcKP0kOHa1B0EIsCb56 es4sf+eOP60LWl11cyBigMZ69lULte1WfkYfQQT9cZw9hf8i2jIl+j3YFx0sXVhq45Df oTk9btHbuCH2syEl2Mfxb3YE20QmcviIjLq0iFVslCm985/uiEo1Xyyib0FJWy84aUmo MQGA== X-Gm-Message-State: AD7BkJLdghXVAbR/7zHqF7T4FIUYMsGlLn76jcm5YSxRKbYqS9bHdigRNYchNhsyFbLlVJay X-Received: by 10.194.22.35 with SMTP id a3mr30514988wjf.165.1458566678318; Mon, 21 Mar 2016 06:24:38 -0700 (PDT) Received: from xps13.localnet (91.111.75.86.rev.sfr.net. [86.75.111.91]) by smtp.gmail.com with ESMTPSA id c144sm12439738wmd.12.2016.03.21.06.24.37 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 21 Mar 2016 06:24:37 -0700 (PDT) Date: Mon, 21 Mar 2016 06:24:37 -0700 (PDT) X-Google-Original-Date: Mon, 21 Mar 2016 14:23 +0100 From: Thomas Monjalon To: Jan Viktorin Cc: Jianbo Liu , dev@dpdk.org, Jerin Jacob , tomaszx.kulasek@intel.com Message-ID: <1712744.RpfQ3k7ngE@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <20160321132131.5d5f0354@pcviktorin.fit.vutbr.cz> References: <1458379590-18618-1-git-send-email-viktorin@rehivetech.com> <20160321132131.5d5f0354@pcviktorin.fit.vutbr.cz> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v3 4/4] eal/arm: introduce CONFIG_RTE_ARCH_ARM_NEON_MEMCPY X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Mar 2016 13:24:38 -0000 2016-03-21 13:21, Jan Viktorin: > On Mon, 21 Mar 2016 13:42:31 +0800 > Jianbo Liu wrote: > > > On 20 March 2016 at 03:58, Jan Viktorin wrote: > > > The flag is used to enable memcpy optimizations in EAL. As it is not always > > > the performance benefit, the flag allows to disable it. > > > > > > Signed-off-by: Jan Viktorin > > > --- > > > config/defconfig_arm-armv7a-linuxapp-gcc | 1 + > > > lib/librte_eal/common/include/arch/arm/rte_memcpy_32.h | 8 ++++++-- > > > 2 files changed, 7 insertions(+), 2 deletions(-) > > > > > > diff --git a/config/defconfig_arm-armv7a-linuxapp-gcc b/config/defconfig_arm-armv7a-linuxapp-gcc > > > index 96c3343..2c60c2c 100644 > > > --- a/config/defconfig_arm-armv7a-linuxapp-gcc > > > +++ b/config/defconfig_arm-armv7a-linuxapp-gcc > > > @@ -36,6 +36,7 @@ CONFIG_RTE_ARCH="arm" > > > CONFIG_RTE_ARCH_ARM=y > > > CONFIG_RTE_ARCH_ARMv7=y > > > CONFIG_RTE_ARCH_ARM_TUNE="cortex-a9" > > > +CONFIG_RTE_ARCH_ARM_NEON_MEMCPY=y > > > > > If it's not always benefit, why not disable here since it is common > > armv7a config, and enable in your or other user's own config file? > > Jianbo, you are right. In that case, I'd just turn it off by default. > And when there is a new platform-specific defconfig, it can enable it. > > Anyway, I am thinking of adding some comment into the rte_memcpy_32.h > file describing the potential of the NEON code. What about: > > /* Enable in your defconfig to accelerate memcpy operations. Consider > enabling this for Cortex-A15. For Cortex-A7 and Cortex-A9, It might > accelerate short data copies (< 64 B). */ > > Thomas, do you consider this enough? Yes it is perfect. Why not put it in defconfig_arm-armv7a-linuxapp-gcc?